[fixed]Kinship ability crashes when it triggers.

by **Aswan jaguar** » 21 May 2023, 13:15

Describe the Bug:
Kinship ability crashes when it triggers.

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Based on latest commit 9338c07 ("Weaver of Lies up to as many targets and not target all.", 2023-05-20)

What exactly should be the correct behavior/interaction?

Are any other cards possibly affected by this bug?
Certainly bugged Call to the Kindred and possibly any card using shares_creature_subtype(-1,...) setting player as -1 ( Path of Ancestry and Descendants' Paths ).

by **Aswan jaguar** » 21 May 2023, 20:11

Fixed Kinship, Path of Ancestry and Descendants' Paths in commit 56551e3.
Edit: I cant find how to fix Call to the Kindred , the bug will appear only if the top card is a creature.

by **Aswan jaguar** » 22 May 2023, 17:50

Also fixed same bug for Bloodline Shaman in commit f7b6d3e. So only Call to the Kindred still bugged.

by **drool66** » 23 May 2023, 04:10

For Call to the Kindred, what about:

Code: Select all: if( selected != -1 && shares_creature_subtype_by_iid(instance->damage_target_player, instance->damage_target_card, player, deck_ptr[player][selected]) ){

by **Aswan jaguar** » 23 May 2023, 13:37

Fixed in commit a2289fc. The issue was that it didn't change both instances of shares_creature_subtype() in code. #-o

by **drool66** » 24 May 2023, 17:44

None of these functions should pass -1 to the player parameter though. has_subtype_by_id() for example, uses the player param for the cards Conspiracy, Arcane Adaptation, and soon Maskwood Nexus, maybe others.