It is currently 18 Apr 2024, 11:40
   
Text Size

CSV errors & Legacy/Effect cards with no text

Report wrong Card behavior to get it fixed.
PLEASE ADD SAVEGAMES TO YOUR TOPIC !

Moderators: BAgate, drool66, Aswan jaguar, gmzombie, stassy, CCGHQ Admins

Re: CSV errors & Legacy/Effect cards with no text

Postby Korath » 07 Jun 2015, 02:02

Sonic wrote:To be honest guys, I've really lost interest with doing the csv files any more. I've always found working on the csv files something of a chore, and after 3 years I think it's time to pass the baton on to someone else.

You'll probably need to get hold of Gargaroz for the most recent files. I don't know how far he'd got with editing them for the next update, but the only files I've got are the same as everybody else can find in the last updates 'magic_updater' folder.

If you still need someone to compile the card artwork, get whoever decides to pick up the csv baton to contact me and I'll sort something out.
Thank you for your service.

I can maintain csvs so far as the sort of bugfixes that show up in this thread go (and certainly the requests I post - it'll be easier than what I've been doing to fix them in Shandalar without breaking compatibility with Manalink).

The base entries for new sets, and especially dealing with the artwork, are enough of a time commitment that I'd really rather someone else took responsibility for maintaining them, though. Anyone willing to step up?
User avatar
Korath
DEVELOPER
 
Posts: 3707
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1106 times

Re: CSV errors & Legacy/Effect cards with no text

Postby gmzombie » 07 Jun 2015, 17:06

Just a question what exactly is done here on the csv? Or more importantly how is it done. Is it all by hand? Is there a program that will help input items in? I don't have a lot of time on my hands but I feel like I might be able to help
can I maze of ith your snowstorm?

http://home.comcast.net/~gmzombie/index.html old stuff in here. don't use this stuff right now till I get time to get back into it and readjust.
gmzombie
 
Posts: 857
Joined: 26 Feb 2009, 01:05
Location: Wyoming, Mi
Has thanked: 200 times
Been thanked: 51 times

[fixed/closed]Metallic Mastery and Traitorous Blood

Postby Korath » 30 Jun 2015, 23:42

Last edited by Aswan jaguar on 24 Jan 2016, 10:53, edited 2 times in total.
Reason: strikethrough fixed/closed
User avatar
Korath
DEVELOPER
 
Posts: 3707
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1106 times

[fixed/closed]Mob Rule

Postby stassy » 13 Jul 2015, 10:38

Last edited by Aswan jaguar on 24 Jan 2016, 10:49, edited 1 time in total.
Reason: strikethrough fixed/closed
stassy
Moderator
 
Posts: 5274
Joined: 25 Feb 2009, 07:06
Has thanked: 471 times
Been thanked: 337 times

[fixed/closed]Scroll of the Masters

Postby stassy » 15 Jul 2015, 06:26

Last edited by Aswan jaguar on 24 Jan 2016, 10:48, edited 1 time in total.
Reason: strikethrough fixed/closed
stassy
Moderator
 
Posts: 5274
Joined: 25 Feb 2009, 07:06
Has thanked: 471 times
Been thanked: 337 times

[unconfirmed]

Postby stassy » 20 Jul 2015, 13:58

Extruder is missing its cardimage.
Last edited by Aswan jaguar on 24 Jan 2016, 10:47, edited 1 time in total.
Reason: unconfirmed
stassy
Moderator
 
Posts: 5274
Joined: 25 Feb 2009, 07:06
Has thanked: 471 times
Been thanked: 337 times

Re: CSV errors & Legacy/Effect cards with no text

Postby Sonic » 21 Jul 2015, 15:59

stassy wrote:Extruder is missing its cardimage.
Nope. You're missing Extruder's cardimage. :P

It's in the 'CardArtUpdates_2012_2014.zip' archive.
Working On: Life, the Universe, and Everything.
User avatar
Sonic
Apprentice
 
Posts: 827
Joined: 27 Feb 2010, 00:37
Has thanked: 3 times
Been thanked: 161 times

[fixed/closed]Sturdy Hatchling

Postby Korath » 22 Jul 2015, 07:54

Last edited by Aswan jaguar on 24 Jan 2016, 13:05, edited 2 times in total.
Reason: strikethrough fixed/closed
User avatar
Korath
DEVELOPER
 
Posts: 3707
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1106 times

[fixed/closed]Hammerhand legacy effect display bonus effect

Postby stassy » 04 Aug 2015, 10:58

Hammerhand legacy effect on target creature that can't block display the bonus effect text instead of the detrimental one.
Last edited by Aswan jaguar on 24 Jan 2016, 10:41, edited 2 times in total.
Reason: strikethrough fixed/closed
stassy
Moderator
 
Posts: 5274
Joined: 25 Feb 2009, 07:06
Has thanked: 471 times
Been thanked: 337 times

Re: CSV errors & Legacy/Effect cards with no text

Postby Korath » 10 Aug 2015, 01:51

Some inconsistencies I found while trying to puzzle out the Family column of ct_all.csv:

Akoum Refuge, Graypelt Refuge, Jwar Isle Refuge, Kazandu Refuge, and Sejiri Refuge all have family 12 (nonbasic land with basic land type), but don't actually have basic land types.
Conversely, Dryad Arbor, Leechridden Swamp, Madblind Mountain, Mistveil Plains, Moonring Island, and Sapseep Forest all have family -1.

That said, it's not immediately obvious whether any of the functions that look for this value still do. Originally, the cards involved were Choke, Vernal Bloom, Wood Elves, the original animate-land effect (for Living Lands and Kormus Bell), Living Lands and Kormus Bell themselves, Conversion, Serendib Djinn, Sanctimony, Goblin Caves, Goblin Shrine, Tsunami, Lifeblood, Gauntlet of Might, Lifetap, Boil, Flashfires, and Acid Rain. While all have been marked as having been recoded (except that animate-land effect), I haven't looked for duplicate cards that still point to the assembly versions, and we haven't been at all diligent in marking whether cards have been mostly recoded but still call exe functions.

Still, easier to make the data right than to verify all that.

Spine of Ish Sah inexplicably has family 7 (rat). I haven't checked whether the value is still used at all.
(fixed up to here)

Boggart Shenanigans isn't marked family 3 (goblin). Again, I haven't checked whether the value is still used at all, or if (where it's used) it's only in a context where only goblin creatures should match.
Last edited by Korath on 15 Aug 2015, 03:34, edited 1 time in total.
User avatar
Korath
DEVELOPER
 
Posts: 3707
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1106 times

Re: CSV errors & Legacy/Effect cards with no text

Postby Korath » 15 Aug 2015, 03:02

Fixed: Howl of the Horde, Otherworldly Journey, Mardu Scout, Flamerush Rider, Wild Slash, Temporal Trespass, Warden of the First Tree, Kolaghan, the Storm's Fury, Laccolith Grunt, Ashen Powder, Molting Snakeskin, Mercurial Pretender, Grimoire Thief, Dragonrage, Dragon Egg, Viridian Emissary, Jeskai Sage, Outpost Siege, Mob Rule, Scroll of the Masters, Hammerhand.

Not fixed: Armory of Iroas and Dungrove Elder (since the effect card is invisible by default), this (because I'm lazy), or the last bit of this (because it's unclear if it's needed).

Otherwise, that should be everything up until this point.
User avatar
Korath
DEVELOPER
 
Posts: 3707
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1106 times

Re: CSV errors & Legacy/Effect cards with no text

Postby stassy » 17 Sep 2015, 05:34

Gaea's Herald (though I am not sure why the legacy effect appear when it die, the effect is not supposed to least until eot)
stassy
Moderator
 
Posts: 5274
Joined: 25 Feb 2009, 07:06
Has thanked: 471 times
Been thanked: 337 times

[fixed/closed]Aluren,Sealock Monster,Sakashima the Impostor,

Postby Aswan jaguar » 18 Oct 2015, 12:27

Aluren needs values in Legacy slots.
Sealock Monster needs values moved from effect to legacy slots.
Sakashima the Impostor need values added to Legacy slots.(probably needs also values to be removed from effect slots,too I don't know if it matters and I was lazy test).
Vesuvan Shapeshiftersame as Sakashima the Impostor above.

Quicksilver Gargantuan is strange because as you cast it the legacy instead of showing Quicksilver Gargantuan 's art (like all other copy creature) in legacy card it shows the art of the card it copies until eot and then legacy vanishes.If that gets fixedthen probably it will need values moved from effect to legacy slots to work correctly.
Last edited by Aswan jaguar on 01 Sep 2016, 14:55, edited 4 times in total.
Reason: strikethrough fixed-fixed/closed
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester Elite
 
Posts: 8078
Joined: 13 May 2010, 12:17
Has thanked: 730 times
Been thanked: 458 times

[fixed/closed]Rolling Thunder

Postby Aswan jaguar » 01 Nov 2015, 16:51

Rolling Thunder has shround on ct_all and so on play=hand.
Last edited by Aswan jaguar on 24 Jan 2016, 05:40, edited 2 times in total.
Reason: strikethrough fixed/closed
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester Elite
 
Posts: 8078
Joined: 13 May 2010, 12:17
Has thanked: 730 times
Been thanked: 458 times

Re: CSV errors & Legacy/Effect cards with no text

Postby Korath » 01 Nov 2015, 17:35

Shroud fixed for Rolling Thunder. I don't understand what you mean by "on play=hand".
User avatar
Korath
DEVELOPER
 
Posts: 3707
Joined: 02 Jun 2013, 05:57
Has thanked: 496 times
Been thanked: 1106 times

PreviousNext

Return to Bug Reports

Who is online

Users browsing this forum: No registered users and 29 guests


Who is online

In total there are 29 users online :: 0 registered, 0 hidden and 29 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 29 guests

Login Form