CSV errors & Legacy/Effect cards with no text

[stassy]

Part the Waterveil Time Walk legacy effect has the Awoken legacy text instead of Time Walk when casting normally.

[Korath]

Fixed Part the Waterveil in dbd07bd.

[stassy]

Forerunner of Slaughter give haste ability create an empty legacy effect on colorless target creature.



Couldn't find an explicit ruling about that but doesn't summoning sickness return on target creature at eot? Currently it's permanently removed...

[Aswan jaguar]

Reincarnation legacy has no title and text.

[Korath]

Couldn't find an explicit ruling about that but doesn't summoning sickness return on target creature at eot? Currently it's permanently removed...

Haste is approximated in Manalink by immediately and permanently removing summoning sickness whenever a permanent has the ability even momentarily. The easiest way to demonstrate it is to give something a "gains haste until end of turn" effect like with Whip Sergeant or Flame-Kin Zealot or, yes, Forerunner of Slaughter. It'll still be able to tap to activate on your opponent's turn.

I was able to make it work correctly in Shandalar mostly because there weren't years and years of legacy hacks that depend on the old behavior (same reason as most of the things that work better there). Most of it could be backported to Manalink by sacrificing a state or status bit to mean "really hasn't started a turn under its controller's control, not kidding this time, just ignore STATE_JUST_CAST and STATE_SICKNESS and STATE_SUMMON_SICK". Getting it to work fully enough to implement Instill Energy properly, though, where the creature can attack but not tap to activate, is more trouble than it's worth.

[stassy]

Boiling Earth is missing Awaken legacy effect text on target land.

[Aswan jaguar]

Ichor Explosion no legacy title & text.

[stassy]

Wall of Dust legacy effect states that creatures blocked may not attack instead of can't attack.

[BAgate]

Aquitect's Will legacy card has no text or title.

[Korath]

Fixed everything up to here except:

• this still
• Quicksilver Gargantuan, which isn't a csv problem
• Taigam's Strike, which isn't really a csv problem either; there should be a context menu option to view any effect's source card, like there is for cards that have been made into copies of something else
• "and others like it or different" - not actionable without a list. It was hard enough parsing that paragraph to start with.
• Splinter Twin - not a csv problem
• db cardtype 2 - This is extensive and undertested enough that I'll change the deckbuilder to instead look at whether the card has anything in Mana Source Colors, which'll be more accurate.
• anything that was already struck out (though I didn't verify those)
• anything that had already been fixed

in 9d2fed5.

[Aswan jaguar]

Elemental Uprising legacy has no text and title when select to show in big card.It has title in small card.
Grip of the Roil has empty legacy text.has no text and title when select to show in big card.It has title in small card.

[Aswan jaguar]

Vent Sentinel has no play values for AI in ct_all.
edit:Shade of Trokair pump legacy is the same as the legacy of it's suspend ability and has suspend text.

[Aswan jaguar]

Needle Spires animate legacy has no text.

[Aswan jaguar]

1- Scourge of Kher Ridges is set to be played after combat only.Either set it both before and after combat or only before combat to be able to activate it's non-tap burn abilities.
2- Forked Bolt is only set to be played after combat.At least play also before combat or only before combat.
3- Guerrilla Tactics is only set to be played after combat.It is a ping instant and should be played at all times.
4- Explosive Revelation is only set to be played after combat.At least play also before combat or only before combat.
5- Thrive is only set to be played after combat.Should be played also before combat or only before combat.
6- Punish the Enemy is set to be played only after combat.It is a ping instant and should be played at all times.

[Aswan jaguar]

Singing Bell Strike legacy is still missing title & rules text.It has the values put in effect slots and they need to be transferred to legacy ones to be read from engine and make the card highlight when it can be activated.