[REL] Riiak's DotP 2014 Deck Builder v1.5.0.3

[RiiakShiNal]

Actually, I did not know about those errors, though looking at them I see what is going on. Some cards have values that I can't parse as integers for the power/toughness comparison (such as "1+*", "X", and "0.5") so the check fails with an error trying to parse the string to an integer. I do have special code in there to handle "*", but forgot the other combinations. The only creature I know of to have a floating point toughness is Little Girl from the Unhinged set. I had not considered "X" as a valid value because I don't know of any cards that use X (though several use *).

Regardless, I will address the issue to handle the cases without throwing errors. Also, since I expected there could be errors relating to the parsing it shouldn't crash the Deck Builder (but producing the errors is annoying).

[Xander9009]

It definitely doesn't crash, no. 1+ comes from Tarmogoyf of course, but I'm afraid the "X" ones are my fault. I didn't think that would cause issues. It's certain tokens that are described as X/X. I've changed all of those, so you don't have to worry about the X unless you want to. I don't know if any other modders have done that.

There's also "2+" or "2+*" from Angry Mod. "1+" or "1+*" appears on Tarmogoyf, Lhurgoyf, Haunting Apparition, and An-Havva Constable. So, not very many. I'll change the CW ones to either "#+" or "#+*" so they're consistent (or just make them "*"). Which would you prefer? Or would you want to just add them all for the sake of it and thus it doesn't matter?

[RiiakShiNal]

It definitely doesn't crash, no. 1+ comes from Tarmogoyf of course, but I'm afraid the "X" ones are my fault. I didn't think that would cause issues. It's certain tokens that are described as X/X. I've changed all of those, so you don't have to worry about the X unless you want to. I don't know if any other modders have done that.

When a token is described as X/X it is really */* as per MtG rules and formatting. The X merely makes it easier to describe how the "*" power and/or toughness change in regard to some known quantity X.

There's also "2+" or "2+*" from Angry Mod. "1+" or "1+*" appears on Tarmogoyf, Lhurgoyf, Haunting Apparition, and An-Havva Constable. So, not very many. I'll change the CW ones to either "#+" or "#+*" so they're consistent (or just make them "*"). Which would you prefer? Or would you want to just add them all for the sake of it and thus it doesn't matter?

"#+*" (and/or "#-*" from something like Shapeshifter) is the MtG consistent formatting that I should be handling. Since it is the most consistent with MtG you should be using that format (so your 1+* and 2+* values should not change as those are correct). Besides good programming states that I should account for all possible inputs (not just the correct/well-formed inputs).

[dantar]

When exporting deck, If I create a new personality, it will not export. I change the personality to a preset one and it exports fine. Does the personality really matter if I'm playing with the deck against AI?

[Xander9009]

Personality only affects things like the images used, the music, superficial stuff like that. Just use a preset one if the others are giving you trouble. When Riiak checks in, he might know why your personalities might not be exporting.

[dantar]

I didn't know if maybe the images I'm using are too big or something to that affect. It seems to be the images that cause issue after some tinkering.

[RiiakShiNal]

I have no idea why you can't export if you create a new personality. After it fails to export could you check the directory you have the Deck Builder in for an error log, if there is one could you post it (it could give some clues as to the problem).

As Xander9009 stated personality is only cosmetic, but a bug is a bug and needs to be fixed.

[dantar]

Nothing pops up in the Error Log. The only error in there is "Tried to create a core wad without the custom data wad being present" but I figured that out. I get an unhandled exception error that reads:

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.FormatException: One of the identified items was in an invalid format.
at Gibbed.Duels.FileFormats.TdxFile.Serialize(Stream output)
at RSN.DotP.WadBase.TdxToMemoryStream(TdxWrapper twImage)
at RSN.DotP.WadBase.AddAiPersonalityImage(String strFilename, TdxWrapper twImage)
at RSN.DotP.DeckBuilder.ExportWad(WadBase wad, String strGameDirectory)
at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ToolStrip.WndProc(Message& m)
at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
Assembly Version: 4.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll
----------------------------------------
DotP 2014 Deck Builder
Assembly Version: 1.4.0.0
Win32 Version: 1.4.0.0
CodeBase: file:///C:/Users/DANTAR/Desktop/Riiaks_DotP_2014_Deck_Builder_v1.4.0.0_x64/DotP%202014%20Deck%20Builder.exe
----------------------------------------
System.Windows.Forms
Assembly Version: 4.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System.Drawing
Assembly Version: 4.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
System
Assembly Version: 4.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Xml
Assembly Version: 4.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Configuration
Assembly Version: 4.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
System.Core
Assembly Version: 4.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll
----------------------------------------
Gibbed.Duels.FileFormats
Assembly Version: 1.0.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///C:/Users/DANTAR/Desktop/Riiaks_DotP_2014_Deck_Builder_v1.4.0.0_x64/Gibbed.Duels.FileFormats.DLL
----------------------------------------
Microsoft.GeneratedCode
Assembly Version: 1.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Microsoft.GeneratedCode
Assembly Version: 1.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Microsoft.GeneratedCode
Assembly Version: 1.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Gibbed.IO
Assembly Version: 1.0.4706.36265
Win32 Version: 1.0.0.0
CodeBase: file:///C:/Users/DANTAR/Desktop/Riiaks_DotP_2014_Deck_Builder_v1.4.0.0_x64/Gibbed.IO.DLL
----------------------------------------
ICSharpCode.SharpZipLib
Assembly Version: 0.86.0.518
Win32 Version: 0.86.0.518
CodeBase: file:///C:/Users/DANTAR/Desktop/Riiaks_DotP_2014_Deck_Builder_v1.4.0.0_x64/ICSharpCode.SharpZipLib.DLL
----------------------------------------
Gibbed.Squish
Assembly Version: 1.0.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///C:/Users/DANTAR/Desktop/Riiaks_DotP_2014_Deck_Builder_v1.4.0.0_x64/Gibbed.Squish.DLL
----------------------------------------
Microsoft.GeneratedCode
Assembly Version: 1.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Microsoft.GeneratedCode
Assembly Version: 1.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Microsoft.GeneratedCode
Assembly Version: 1.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Accessibility
Assembly Version: 4.0.0.0
Win32 Version: 4.5.27.0 built by: FX453PREVIEWREL
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
<system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

[RiiakShiNal]

Based on the error it looks like one of two things has happened. Either one or more of your images has an error in it (the error could have been generated by the deck builder if you used the build option for images, if this is the case then if you post an affected saved deck I should be able to reproduce and troubleshoot the problem) or you are using a wrong version of the Gibbed.Squish.dll (you should be using the version that came with the Deck Builder which was modified to support saving of compressed TDX images with mipmaps).

Also it is recommended when pasting large amounts of text to use the [spoiler] and/or [code] tags to take up less space in the posts (allowing people to scroll past posts they aren't interested in faster).

[dantar]

Code tags noted. I think it's the image. I cut it's size in half and it works fine, but the other images in the same folder that were the same size *wallpapers* work. It hangs during the export but only for like 5 seconds. If I try to use the original image again I get the unhandled exception error. Thanks for taking a look!

[RiiakShiNal]

If cutting the size worked then the problem is likely that at least one of the dimensions is greater than 2000 (or possibly equal to) as that is a known limitation of the TDX compression code in Gibbed Tools. So the error is probably occurring when trying to compress the large AI personality image. If I remember correctly the game by default uses 512x512 large AI images, but the compression code in Gibbed Tools doesn't handle larger images like 2048x2048 (it errors out).

Textures in general (which is what DotP and most other games use) tend to work best when their sizes are multiples of 2 (makes mipmap logic much easier) and DotP uses this a lot. Box art is generally 512x512, AI backplate images (the ones you see in the custom match screen for example) are usually 256x512, and the AI circular images are usually 256x256. For the images the Deck Builder creates as part of the build process it uses the default sizes. However, for the large AI personality image I didn't give a build mode (because there really isn't anything special about the large image other than being square) so that one doesn't get resized to the default texture size for that type of image.

I guess I also need to look into putting in resize code for all chosen images if they don't meet the default size to avoid errors like this in the future. Thanks for reporting.

[dantar]

The image in question was 2560 x 1600. (Waaaay bigger than necessary) The other wallpapers I used were 1920 x 1080 and from what I tried worked fine. The other information was informative though, thanks for helping me out!

[StoneyTheBear]

BUMP! I require knowledge, also, tutoring. I hope you people read this.

Arashin the Foremost: "Whenever Arashin Foremost enters the battlefield or attacks, another target Warrior creature you control gains double strike until end of turn."


If I knew how or even had the means to. I would embed an image of the card.
Right here.

The trigger... sees you. She flashes, and it happens.
She wants to you double you up.
Although. What you receive is indestructible. Falsely.
-A short story.

The moral of the story is this. Triggers work but the ability is indestructible and it never occurs.

<TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" />
<TRIGGER value="ATTACKING" simple_qualifier="self" />
<TARGET tag="CARD_QUERY_CHOOSE_PERMANENT_MAKE_INDESTRUCTIBLE" definition="0" compartment="0" count="1" />
<TARGET_DEFINITION id="0">
local filter = ClearFilter()
filter:Add(FE_CARD_INSTANCE, OP_NOT, EffectSource())
filter:Add(FE_SUBTYPE, OP_IS, CREATURE_TYPE_WARRIOR)
filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
</TARGET_DEFINITION>
<CONTINUOUS_ACTION layer="6" mode="3">
local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
if target ~= nil then
local characteristics = target:GetCurrentCharacteristics()
characteristics:Bool_Set( CHARACTERISTIC_DOUBLE_STRIKE, 1 )
end
</CONTINUOUS_ACTION>
<DURATION simple_duration="UntilEOT" />
<AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ALLIED_ONLY" />
</TRIGGERED_ABILITY>
<HELP title="MORE_INFO_BADGE_TITLE_2" body="MORE_INFO_BADGE_BODY_2" zone="ZONE_ANY" />
<SFX text="COMBAT_BLUNT_LARGE_ATTACK" power_boundary_min="4" power_boundary_max="-1" />
<SFX text="COMBAT_BLUNT_SMALL_ATTACK" power_boundary_min="1" power_boundary_max="3" />
<AUTHOR><![CDATA[Xander9009]]></AUTHOR>
<EDITORS><![CDATA[Xander9009]]></EDITORS>
<DATE><![CDATA[26-03-15]]></DATE>
</CARD_V2>

[RiiakShiNal]

| Open

BUMP! I require knowledge, also, tutoring. I hope you people read this.

Arashin the Foremost: "Whenever Arashin Foremost enters the battlefield or attacks, another target Warrior creature you control gains double strike until end of turn."


If I knew how or even had the means to. I would embed an image of the card.
Right here.

The trigger... sees you. She flashes, and it happens.
She wants to you double you up.
Although. What you receive is indestructible. Falsely.
-A short story.

The moral of the story is this. Triggers work but the ability is indestructible and it never occurs.

<TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" />
<TRIGGER value="ATTACKING" simple_qualifier="self" />
<TARGET tag="CARD_QUERY_CHOOSE_PERMANENT_MAKE_INDESTRUCTIBLE" definition="0" compartment="0" count="1" />
<TARGET_DEFINITION id="0">
local filter = ClearFilter()
filter:Add(FE_CARD_INSTANCE, OP_NOT, EffectSource())
filter:Add(FE_SUBTYPE, OP_IS, CREATURE_TYPE_WARRIOR)
filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
</TARGET_DEFINITION>
<CONTINUOUS_ACTION layer="6" mode="3">
local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
if target ~= nil then
local characteristics = target:GetCurrentCharacteristics()
characteristics:Bool_Set( CHARACTERISTIC_DOUBLE_STRIKE, 1 )
end
</CONTINUOUS_ACTION>
<DURATION simple_duration="UntilEOT" />
<AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ALLIED_ONLY" />
</TRIGGERED_ABILITY>
<HELP title="MORE_INFO_BADGE_TITLE_2" body="MORE_INFO_BADGE_BODY_2" zone="ZONE_ANY" />
<SFX text="COMBAT_BLUNT_LARGE_ATTACK" power_boundary_min="4" power_boundary_max="-1" />
<SFX text="COMBAT_BLUNT_SMALL_ATTACK" power_boundary_min="1" power_boundary_max="3" />
<AUTHOR><![CDATA[Xander9009]]></AUTHOR>
<EDITORS><![CDATA[Xander9009]]></EDITORS>
<DATE><![CDATA[26-03-15]]></DATE>
</CARD_V2>

This is not even close to being the correct topic for this. You are reporting a Community Wad card bug in the Deck Builder thread. That card has absolutely nothing to do with the Deck Builder.

That being said the only problems I see with the ability are that the Target text is wrong (CARD_QUERY_CHOOSE_PERMANENT_MAKE_INDESTRUCTIBLE) and a mode is improperly set on the CONTINUOUS_ACTION. The characteristic being set on the target is actually double strike.

[StoneyTheBear]

I honestly did not know where to post it. I just hoped someone with some insight into this would see it.

My question has been answered in the correct thread. Though now I can't delete my post here. Need some moderator assistance on that.