myk's code contributions

[moomarc]

You're awesome. Thanks, Marc (or do you prefer "moo"?)

Marc is good. (moomarc is one of those forum names that make you wonder what you were thinking when you signed up. But at least it's friendly)

[myk]

Max: Thanks -- maybe I can use that for the total count as well instead of the special case that was (and is) there (Edit: r19455). Which features are still missing from the deck editor? I haven't really used the old one (apart from one compile of an old revision just to see what it looked like when you first mentioned the old toggle buttons).

[myk]

I'm trying to get the hover/focus system working consistently. I'm going through and trying to make sure the current focus is clear in each screen and enabling tab focus traversal. The most recent change I did put an alpha channel in front of hoverable/selectable labels that are not currently hovered. What do you think? Does it make the unhovered labels too dark? Does it increase clarity? I could use some feedback from our resident Pixel Commander.

[moomarc]

I'll only be able to check in a few hours when I wake up. Just going to sleep in my part of the world.

[myk]

No worries, take your time. If it goes out as-is in the next beta, I'd be happy to hear player feedback as well.

[Max mtg]

This is also a very bad practice
http://svn.slightlymagic.net/websvn/fil ... &peg=19312
because it gives core class extra responsibility.

r19467-19468 revert this terrible change.

[myk]

+1 looks much better. Thanks!

[moomarc]

I had a look at the deck editor tabbing and it seems perfect as is. On a very dark theme like Dark Ascension, it can seem a little too dark, but it's not worth changing for. It's perfectly balanced for the other skins in my opinion.

I did notice however that if you add a Set filter, you can no longer tab around the editor. I guess focus isn't being reset.

[myk]

Cool, thanks for the review - and if I ever make a change that's doesn't gel artistic-wise, please do tell me. Good catch on the focus problem; I'll get that fixed

btw, I'll be mostly unavailable this weekend. I'll respond to any posts on Monday.

[Max mtg]

Which features are still missing from the deck editor? I haven't really used the old one (apart from one compile of an old revision just to see what it looked like when you first mentioned the old toggle buttons).

* Ability to add/remove card under cursor in table by pressing space bar or right mouse button (need a way to add cards fast)

* Ability to open decks from in-memory storages (where all the constructed, draft, sealed, planar decks are read on startup)

* That "all decks" tab looks unfinished. It has a single button and nothing else. I don't know what was the original idea, so the button might be moved to a more accessible place.

* As cursor is set on the table, typing card name should move focus towards the matching card

[myk]

Which features are still missing from the deck editor?

* Ability to add/remove card under cursor in table by pressing space bar or right mouse button (need a way to add cards fast)

Space bar to move is implemented. I'm planning on adding a r-click menu interface to several elements, including adding cards to deck/sideboard.

* Ability to open decks from in-memory storages (where all the constructed, draft, sealed, planar decks are read on startup)

will add

* That "all decks" tab looks unfinished. It has a single button and nothing else. I don't know what was the original idea, so the button might be moved to a more accessible place.

agreed. I'll see what I can do about it.

* As cursor is set on the table, typing card name should move focus towards the matching card

also on my list. shouldn't be too hard to implement.

[myk]

I did notice however that if you add a Set filter, you can no longer tab around the editor. I guess focus isn't being reset.

fixed in r19504. I may move the focus restoring code somewhere else eventually -- perhaps into SOverlayUtil -- once I get a feel for how focus should be handled program-wide. I'm sure this problem will crop up in other places too.

[myk]

I started on find-as-you-type for editor tables. Basic functionality is there. I'm going to add a popup showing the current search string next. There is an unwelcome interaction between find-as-you-type and the spacebar shortcut for adding/removing cards: every time you type a card name with a space in it, you add the currently selected card. How do people feel about changing the add/remove shortcut to something else, like the left/right arrow keys?

[friarsol]

How do people feel about changing the add/remove shortcut to something else, like the left/right arrow keys?

Maybe Ctrl+Left or Right? I use the up/down arrows to scroll through the list, and it'd be really confusing to add things if I hit the wrong key by accident (especially since I may add a few things before I notice the reason its "scrolling" is because the original selected row is missing.

[Max mtg]

I started on find-as-you-type for editor tables. Basic functionality is there. I'm going to add a popup showing the current search string next. There is an unwelcome interaction between find-as-you-type and the spacebar shortcut for adding/removing cards: every time you type a card name with a space in it, you add the currently selected card. How do people feel about changing the add/remove shortcut to something else, like the left/right arrow keys?

I speak for leaving this as it is. The main purpose of that feature is to ease the search of needed card, that is position the cursor around card's location in the table. As one enters the first 3-4 letters of cardname, one already is able find the card visually and use up/down arrows to point at the needed card, so that space will not be used to type cardname.

Left-Right keys might be good for switching between panels, while space pressed with shift or crtl would stand for "move 4 cards of that kind"