myk's code contributions

[Chris H.]

I would like to suggest that a shortcut should be listed in the appropriate tooltip as it is easy to forget the actual shortcut used and we do not want to complicate things by making people look through a lot of messages here to find an answer.

[myk]

That would be true if the list were sorted by name, but there is no guarantee that it is. Also, there are many cards that have only common words in their names. Imagine trying to get to 'goblin berserker' by typing only 'goblin' or 'berserker'. Another option is that I could intercept the spacebar while the search popup is shown -- it goes away in 5 seconds (or, it will once I get it implemented). Would that be an acceptable compromise?

Btw, I fixed it a while ago so that tab switches focus between widgets.

[Max mtg]

Well, that would be odd - finding a card in a table sorted in different way than by name.
Anyway, I like you idea of intercepting user input into a popup.

Speaking of the latter - what do you think of typing card name right into filter textbox instead of a popup when the table has focus? So that any letter typed while table is focused moves focus to filter textbox (and types that letter there). And while the filter box is focused, one may press up and down arrows to move focus into table to select the line one is looking for.
- This has its cons as well -
Will ruin the filter if player was using that filter to select cards by type.
Unapplicable to player's deck which has no filter textbox (and due to being smal enough does not need one).

[friarsol]

I noticed when deselecting the packs filter that all the other numbers also decrease.

Ex: 14 White, 13 Blue, when I deselect the 8 Packs White now displays 6 and Blue now displays 5. I just did a quick count and these 6 and 5 numbers are correct, so it looks like it's counting Packs as all 5 colors?

[myk]

will fix. Thx!

[myk]

Well, that would be odd - finding a card in a table sorted in different way than by name.

This is actually my modus operandi. While building decks, I usually have the tables sorted first by CMC, then by type, and finally by name. In the spell shop, I usually have it sorted first by owned quantity.

Anyway, I like you idea of intercepting user input into a popup.

I just got a version of this checked in. Try it out and see if you like it. Left/right arrow keys also switch focus between the tables, so management with the keyboard should be a lot easier now.

Speaking of the latter - what do you think of typing card name right into filter textbox instead of a popup when the table has focus? So that any letter typed while table is focused moves focus to filter textbox (and types that letter there). And while the filter box is focused, one may press up and down arrows to move focus into table to select the line one is looking for.
- This has its cons as well -
Will ruin the filter if player was using that filter to select cards by type.
Unapplicable to player's deck which has no filter textbox (and due to being smal enough does not need one).

I think that might be a little confusing to have different visual feedback for the two tables for the same functionality. I'd also be unwilling to lose the accessibility of the string filter functionality (unless, of course, it becomes apparent that users are not using it).

[Max mtg]

I just got a version of this checked in. Try it out and see if you like it. Left/right arrow keys also switch focus between the tables, so management with the keyboard should be a lot easier now.

Does not work right out-of-the-box.

Code: Select all

java.lang.NullPointerException
   at forge.gui.deckeditor.CDeckEditorUI$_FindAsYouType._findNextMatch(CDeckEditorUI.java:320)
   at forge.gui.deckeditor.CDeckEditorUI$_FindAsYouType.keyTyped(CDeckEditorUI.java:392)
   at java.awt.AWTEventMulticaster.keyTyped(Unknown Source)


Happens as I type any letter with focus set on the left table.

Left/right arrows work properly, thanks!

[myk]

What OS are you on? Is it possible that SwingUtilities.getWindowAncestor(popupLabel) is returning null?

[Max mtg]

What OS are you on? Is it possible that SwingUtilities.getWindowAncestor(popupLabel) is returning null?

windows 7 x64
That expression does return null - i've checked.

[myk]

Hrmph. I don't have a windows machine to test on, but I checked in a potential fix. Could you try it again and see if it works for you now?

[Max mtg]

Sorry, cannot check today, will write tomorrow morning

[RumbleBBU]

Myk, congrats on the new DialogChooseSets class - a light-years improvement over the previous one!

However, there was a slight problem. The Alpha and Beta sets were deliberately disabled in the old version: including them in the Quest format would seriously unbalance the game, since you could sell practically any Alpha or Beta card you win in a booster would for a silly price and make obscene amounts of credits very quickly. Unlimited covers practically the same cardbase but at a slightly saner price.

I took the liberty of re-disabling Alpha and Beta in the dialog. I hope that's not too much of an inconvenience. Please feel free to modify the relevant code as you see fit.

[Max mtg]

Oh, that test:
- still crashes =(

that SwingUtils.getRoot method is trying to obtain the topmost parent in hierarchy up from the component you give it as a parameter. It requires a Window or Applet instance to return.

So I tracked the parents in debugger and found that the last parent is
javax.swing.PopupFactory$MediumWeightPopup$MediumWeightComponent[panel0,1942,211,235x17,invalid,layout=java.awt.BorderLayout]
and it's parent is null.

[myk]

Myk, congrats on the new DialogChooseSets class - a light-years improvement over the previous one!

However, there was a slight problem. The Alpha and Beta sets were deliberately disabled in the old version: including them in the Quest format would seriously unbalance the game, since you could sell practically any Alpha or Beta card you win in a booster would for a silly price and make obscene amounts of credits very quickly. Unlimited covers practically the same cardbase but at a slightly saner price.

I took the liberty of re-disabling Alpha and Beta in the dialog. I hope that's not too much of an inconvenience. Please feel free to modify the relevant code as you see fit.

Thanks for the positive feedback : ) I'm sorry I didn't see that problem sooner -- I had /intended/ to keep them disabled, but a bug in FCheckBoxList was unconditionally re-enabling everything. That bug is be fixed now, and the disabling of sets listed in unselectableSets now works again. I removed the hard-coded disabling of LEA and LEB since that dialog is also used for the set filter, where those sets should be choosable.

Oh, that test:
- still crashes =(

that SwingUtils.getRoot method is trying to obtain the topmost parent in hierarchy up from the component you give it as a parameter. It requires a Window or Applet instance to return.

So I tracked the parents in debugger and found that the last parent is
javax.swing.PopupFactory$MediumWeightPopup$MediumWeightComponent[panel0,1942,211,235x17,invalid,layout=java.awt.BorderLayout]
and it's parent is null.

Thanks for testing and debugging. I'll play with it a little more -- maybe a simple getParent() is all I need, and if I can't get that to work, I can hide the popup and reallocate a new one on every character. Not ideal, but superior to a crash.

[myk]

Based on what you described (popup root has null parent on Windows), I made another attempt. If this doesn't work, I'll have to go the reallocation route. Here is what you should be seeing:

and the popup label should expand and contract as you enter more characters or hit backspace.