myk's code contributions
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: myk's code contributions
by Max mtg » 17 Mar 2013, 08:31
How do I instruct Forge to use card pictures from D:\Projects\mtg\img-full\ ?
... except than by creating a symlink from C:\Users\Max\AppData\Local\Forge\Cache\pics\cards ?
... except than by creating a symlink from C:\Users\Max\AppData\Local\Forge\Cache\pics\cards ?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by Max mtg » 17 Mar 2013, 08:49
Why are you using 2-letter codes? (@ CardPrinted.getImageLocator(String, int, boolean, boolean) )
This made my CCGHQ donwloaded pictures unusable.
This made my CCGHQ donwloaded pictures unusable.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by myk » 17 Mar 2013, 08:53
To use non-default directories, see the forge.profile.preferences.example file in the program root dir.Max mtg wrote:How do I instruct Forge to use card pictures from D:\Projects\mtg\img-full\ ?
It was my understanding that the HQ pics (and Magic Workstation) use the 2-letter code directories! It was that way in all the torrent files I examined, and I was endeavoring to make those files usable without any manual renaming. Did I have incorrect info?Max mtg wrote:Why are you using 2-letter codes? (@ CardPrinted.getImageLocator(String, int, boolean, boolean) )
This made my CCGHQ donwloaded pictures unusable.
edit: by the way, the migration dialog/import data dialog will import pics no matter how the directories are named. just point the import data dialog to the directory of pics. You can also import all the data/pics from another forge directory by pointing the import data dialog to that directory.
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: myk's code contributions
by Max mtg » 17 Mar 2013, 09:26
Thanks for that properties file.
Though Forge uses a system class Properties to parse the file, the stupid parser made me escape backslashes in path!
Had I used single backslashes, it would just create a folder Projectsmtgimg-full in forge dir and catch no pictures
That's bad =(
MWS really uses 2-letter codes folder names. My collection has 3-letter codes... I even remember renaming them to work properly in Forge.
Will you allow me to add an option to properties file, specifying which set abbreviations to use?
Though Forge uses a system class Properties to parse the file, the stupid parser made me escape backslashes in path!
- Code: Select all
cardPicsDir=D:\\Projects\\mtg\\img-full
Had I used single backslashes, it would just create a folder Projectsmtgimg-full in forge dir and catch no pictures
That's bad =(
MWS really uses 2-letter codes folder names. My collection has 3-letter codes... I even remember renaming them to work properly in Forge.
Will you allow me to add an option to properties file, specifying which set abbreviations to use?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by myk » 17 Mar 2013, 09:40
I totally understand about the properties file parser. We don't really have any control over how Java properties files are read -- they're hard-coded to be in ISO-8859-1 encoding by the Java VM and backslashes are interpreted before Forge gets to the data. There is a reason that forward slashes are used in all the examples in that file -- forward slashes work on all platforms and don't require escaping. I'll add a note in the file to make others aware of that issue.
As for your pic collection -- while it would be technically possible to have forge search for 3-letter code directory names, is it really required? Wouldn't it be easier to just let the importer rename them? If you've set your cardPicsDir to that directory, you can actually have the importer rename the files for you in-place just by "importing" that directory in the Import Data dialog.
As for your pic collection -- while it would be technically possible to have forge search for 3-letter code directory names, is it really required? Wouldn't it be easier to just let the importer rename them? If you've set your cardPicsDir to that directory, you can actually have the importer rename the files for you in-place just by "importing" that directory in the Import Data dialog.
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: myk's code contributions
by Max mtg » 17 Mar 2013, 10:20
Windows uses backslashes nativelly, so players copying the path right from Explorer will have to add extra slashes or change all the slashes. That is to be explained to users. Hope, there are few users who have a separate collection.
There is a possible workaround - use forge.util.FileSection.parse(Iterable<String>, String) to parse the properties file. It will treat lines literally. The only improvement to be made about that method is support of comments.
Picture collection... I don't want the collection automatically renamed or anything like that. There was a request for custom paths to picture collection viewtopic.php?f=26&t=9467, and I was one of those who refused to intergate it. Now looks like we I got in a situation of the one who needs customizable paths to sets.
So, I'll tell you what this will look like. Another option in preferences file, which would hold a map serialized in a single line. That map will be keyed by set code and it's value is the subfolder of cardPicsDir for that certain set.
There is a possible workaround - use forge.util.FileSection.parse(Iterable<String>, String) to parse the properties file. It will treat lines literally. The only improvement to be made about that method is support of comments.
Picture collection... I don't want the collection automatically renamed or anything like that. There was a request for custom paths to picture collection viewtopic.php?f=26&t=9467, and I was one of those who refused to intergate it. Now looks like we I got in a situation of the one who needs customizable paths to sets.
So, I'll tell you what this will look like. Another option in preferences file, which would hold a map serialized in a single line. That map will be keyed by set code and it's value is the subfolder of cardPicsDir for that certain set.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by Max mtg » 17 Mar 2013, 10:53
wait, I'll add whatever is related to picture collection myself
I have already moved all that image-related code out of CardPrinted class - will test and commit
I have already moved all that image-related code out of CardPrinted class - will test and commit
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by Max mtg » 17 Mar 2013, 11:35
How can I test the commited changes?
Besides everything related to ingame card display works, there is migration routine - could not test it.
Besides everything related to ingame card display works, there is migration routine - could not test it.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by Max mtg » 17 Mar 2013, 12:40
I've commited r20418 that adds an option to use custom names for folders containing picture of each set.
the option name is cardPicsSubDirs, it stores a map of 3-letter wizards code to your folder name.
Example:
Please don't forget to point me at any faults in migration, if my latest changes broke the picture migration process.
the option name is cardPicsSubDirs, it stores a map of 3-letter wizards code to your folder name.
Example:
- Code: Select all
cardPicsSubDirs=LEA->LEA|LEB->LEB|2ED->2ED
Please don't forget to point me at any faults in migration, if my latest changes broke the picture migration process.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: myk's code contributions
by Chris H. » 17 Mar 2013, 12:54
I seem to not have had any problems that were unresolvable while updating. From my terminal I CD'ed to my project folder and then did a "svn up". From there I had to revert a conflict in Eclipse and refresh and that did the trick.
I will now attempt a snapshot build and deploy to cardforge.
Oh, I do try to keep my project clean and do not have any decks, pics quest data, etc so it was probably easier on my part.
I will now attempt a snapshot build and deploy to cardforge.
Oh, I do try to keep my project clean and do not have any decks, pics quest data, etc so it was probably easier on my part.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: myk's code contributions
by Chris H. » 17 Mar 2013, 14:41
Ran a few more tests using today's snapshot build. I imported the data from yesterday's snapshot into today's snapshot build. Today's snapshot build wants to download over 300 new card pictures so I let it and these are the file names for these new cards:
Ran a quick test on a few of these cards and it appears that the pic file minus the number at the end is in the older snapshot but it was not transferred.
The abbey_matron.jpg file is not imported and we end up with these cards being downloaded: Abbey Matron1.full.jpg and Abbey Matron2.full.jpg
- list | Open
Ran a quick test on a few of these cards and it appears that the pic file minus the number at the end is in the older snapshot but it was not transferred.
The abbey_matron.jpg file is not imported and we end up with these cards being downloaded: Abbey Matron1.full.jpg and Abbey Matron2.full.jpg
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: myk's code contributions
by goonjamin » 17 Mar 2013, 17:43
r20422
Data migration was easy and fast and proceeded without errors on my windows 7 machine.
Everything seems to be working fine but I am not seeing a card picture for my ape pet (currently a level 2 ape) when I play quest matches? I see the image in the token folder in the new location but it is not showing up in game, is there something I need to do?
Data migration was easy and fast and proceeded without errors on my windows 7 machine.
Everything seems to be working fine but I am not seeing a card picture for my ape pet (currently a level 2 ape) when I play quest matches? I see the image in the token folder in the new location but it is not showing up in game, is there something I need to do?
Who is online
Users browsing this forum: No registered users and 20 guests