myk's code contributions

[friarsol]

I think we can close issue 634 on Mantis.

Didn't realize you couldn't update things yourself. You've been granted developer role so you can close issues for yourself now.

[myk]

Thanks! I got the issue closed.

[goonjamin]

Hi myk, are skins and sounds going to be moved over to the non program location at some point as well?

[Max mtg]

Edit: it looks like the germ token added by Batterskull is still not appearing correctly.

I expect it to work again with r20432 applied.

[myk]

@goonjamin: Some discussion and planning is in order first, but yes, I believe it will.

@Max: Thanks!

[Max mtg]

@Diogenes I also keep compete sets downloaded, but I made Forge use pictures right from that folders.

This is the setup I am using:

Code: Select all

cardPicsDir=D:\\Projects\\mtg\\img-full
cardPicsSubDirs=LEA->LEA|LEB->LEB|2ED->2ED|ARN->ARN|ATQ->ATQ|3ED->3ED|LEG->LEG|DRK->DRK|FEM->FEM|4ED->4ED|ICE->ICE|CHR->CHR|HML->HML|ALL->ALL|MIR->MIR|VIS->VIS|5ED->5ED|POR->POR|WTH->WTH|TMP->TMP|STH->STH|EXO->EXO|PO2->P02|USG->USG|ULG->ULG|6ED->6ED|UDS->UDS|PTK->PTK|S99->S99|MMQ->MMQ|NMS->NEM|S00->S00|PCY->PCY|INV->INV|PLS->PLS|7ED->7ED|APC->APC|ODY->ODY|TOR->TOR|JUD->JUD|ONS->ONS|LGN->LGN|SCG->SCG|8ED->8ED|MRD->MRD|DST->DST|5DN->5DN|9ED->9ED|GPT->GPT|CSP->CSP|HOP->PCH|MBP->PR


[myk]

@Diogenes I also keep compete sets downloaded, but I made Forge use pictures right from that folders.

This is the setup I am using:

Code: Select all

cardPicsDir=D:\\Projects\\mtg\\img-full
cardPicsSubDirs=LEA->LEA|LEB->LEB|2ED->2ED|ARN->ARN|ATQ->ATQ|3ED->3ED|LEG->LEG|DRK->DRK|FEM->FEM|4ED->4ED|ICE->ICE|CHR->CHR|HML->HML|ALL->ALL|MIR->MIR|VIS->VIS|5ED->5ED|POR->POR|WTH->WTH|TMP->TMP|STH->STH|EXO->EXO|PO2->P02|USG->USG|ULG->ULG|6ED->6ED|UDS->UDS|PTK->PTK|S99->S99|MMQ->MMQ|NMS->NEM|S00->S00|PCY->PCY|INV->INV|PLS->PLS|7ED->7ED|APC->APC|ODY->ODY|TOR->TOR|JUD->JUD|ONS->ONS|LGN->LGN|SCG->SCG|8ED->8ED|MRD->MRD|DST->DST|5DN->5DN|9ED->9ED|GPT->GPT|CSP->CSP|HOP->PCH|MBP->PR


+1 This is certainly easier than maintaining a supplemental card list : )

[Max mtg]

Hi myk, are skins and sounds going to be moved over to the non program location at some point as well?

These don't look like user-created data to be kept in personal profile.
Why do you want them moved?

[myk]

Once they are moved out of our distributable and onto the server, they would go into cacheDir, along with the other downloaded data.

[myk]

Attached is my current set of booster pics.

There are some pics in here with a '2' suffix. Could you possibly choose one pic per set?

[Max mtg]

Oh, by the way, the modern sets feature up to 5 booster pictures.
So, out Boosters might also obtain the artIndex field

[goonjamin]

r20436 - The Download Card Prices isn't working on my system. It just sits and sits when I click start but doesn't download anything. Is this working for everyone else?

[myk]

@Max: good point. @Xitax, do you think you could get a hold of the complete set of pics?

@goonjamin, could you try reverting to r20422 and seeing if that fixes the problem? I just checked. This was it. Max: could you check your usage of java.nio classes in the downloader? My bad. will fix.

[Max mtg]

@goonjamin, could you try reverting to r20422 and seeing if that fixes the problem? I just checked. This was it. Max: could you check your usage of java.nio classes in the downloader?

It's your r20428 that broke downloader window update when download is over.
line 350

[myk]

GuiDownloader has been fixed in r20442.