Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by friarsol » 04 Apr 2013, 03:48
Yep, I expected it not to need anything else on a redraw, but when I was debugging the other day, it seemed like somehow whatever SpellAbility was being referenced still had the old Target, even though the Target is clearly replaced on spell resolution.Max mtg wrote:Stack descriptions should become correct with no extra efforts (if stack UI does fetch the text on redraw).
So if you haven't done anything yet, I'd write that code. But looks like you have - let's wait for your implementation then
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 04 Apr 2013, 05:22
20771 - introduces 'game age' to reflect lifecycle of GameState object { BEFORE_MULLIGAN, MULLIGAN, PLAY, GAMEOVER } (the name of state is already taken, so I called it age)
see if that helps to deal with the recent trace from previous page (exceptions after 1st game in a match)
see if that helps to deal with the recent trace from previous page (exceptions after 1st game in a match)
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Sloth » 04 Apr 2013, 06:24
The stackDescription of a SpellAbilityStackInstance is a locked in String when it is created.friarsol wrote:Yep, I expected it not to need anything else on a redraw, but when I was debugging the other day, it seemed like somehow whatever SpellAbility was being referenced still had the old Target, even though the Target is clearly replaced on spell resolution.Max mtg wrote:Stack descriptions should become correct with no extra efforts (if stack UI does fetch the text on redraw).
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by Max mtg » 04 Apr 2013, 06:53
1. happens when you click creatures to attack opponent, got focus returning to OK.friarsol wrote:r20767
Sometimes when I declare an attack the next phase Input Box loses focus, so I can't just press space to continue through combat quickly.
Buyback is currently broken it looks like it's prompting twice for the same value. I cast Capsize with Buyback on a creature. I pay 4 U U. And then I'm prompted to pay another 3 mana.
Knollspine Invocation does not work currently. I announce X as 5, planning on discarding a Flame Spirit in my hand. I pay my 5 mana (correct) but when I need to discard it won't let me discard the Spirit, and instead the only thing I can discard is a Land. Also, the prompt to discard the card has been removed, which may lead to User Experience issues of accidentally discarding the wrong card. Additionally, now that I have no cards in my hand that have a CMC of 0 I can't even activate it.
Also, I'm still not sure about this new Announce dialog. It seems weird that when I type '11' I'm brought to '10' even though in the old dialog I could just type 11 and press enter. Plus if I want to choose X to be > 20 I have to scroll all the way to the bottom of the dialog, select other amount, and then just type what I want. Why can't we just type what you want to begin with?
2. fixed 20776
3. It's not mine and never worked properly. Try to activate it when you have no cards with CMC=0 in hand - if will fail on canPlay check for discard part of cost.
4. Its previous edition was wierd. You were unable to proceed playing with mouse only and passing priority by pressing numpad ENTER with right thumb of the same hand and had to find digits on keyboard, press them and then enter - that's too many actions.
I have seen that. Reduced the list to 0/1 through 9, that gets 'other amount' option closer to you, and still allows to choose the most common values with mouse only.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Max mtg » 04 Apr 2013, 06:54
How difficult will it be to change that?Sloth wrote:The stackDescription of a SpellAbilityStackInstance is a locked in String when it is created.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Max mtg » 04 Apr 2013, 07:14
You'd better check that before writing.friarsol wrote:Also, the prompt to discard the card has been removed, which may lead to User Experience issues of accidentally discarding the wrong card.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Sloth » 04 Apr 2013, 11:07
It's easy to change just replace the following function in SpellAbilityStackInstance:Max mtg wrote:How difficult will it be to change that?Sloth wrote:The stackDescription of a SpellAbilityStackInstance is a locked in String when it is created.
- Code: Select all
public final String getStackDescription() {
return this.stackDescription;
}
- Code: Select all
public final String getStackDescription() {
return this.ability.getStackDescription();
}
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by friarsol » 04 Apr 2013, 12:23
Ahhh thanks Sloth. I had forgotten about that. I'm not sure if this.ability.getStackDesc() will actually work, because the Ability may not be quite right (if the same ability exists multiple times on the stack). But StackInstance string is definitely something that can be updated when a Target changes anyway. I'll take a look tonight.Sloth wrote:It's easy to change just replace the following function in SpellAbilityStackInstance:with:
- Code: Select all
public final String getStackDescription() {
return this.stackDescription;
}But this could slow down the game a little bit, when a spell is on the stack.
- Code: Select all
public final String getStackDescription() {
return this.ability.getStackDescription();
}
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by swordshine » 04 Apr 2013, 12:36
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by PowerClaws » 04 Apr 2013, 12:38
Description: I was playing a quest in the Ravnica world, i was using a GW selesnya deck, my opponent was also selesnya, id played several matches, and i noticed the game starting to slow down, then, the opponent played an enchantment (Fists Of Ironwood)when the game crashed with this error.
(Also, this was yesterday's version, ill update and see if it happens again)
(Also, this was yesterday's version, ill update and see if it happens again)
- ConcurrentModificationException | Open
- PowerClaws
- Posts: 131
- Joined: 30 Jan 2012, 11:33
- Has thanked: 28 times
- Been thanked: 8 times
Re: Bug Reports (snapshot builds)
by Max mtg » 04 Apr 2013, 12:52
@swordshine - fixed/
@Powerclaws - Card's keyword list was changed (by effect running in a parallel thread) while the playarea was being drawn. I have added that to my TODO list in signature
@Powerclaws - Card's keyword list was changed (by effect running in a parallel thread) while the playarea was being drawn. I have added that to my TODO list in signature
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Diogenes » 04 Apr 2013, 13:23
Also, the Momir Avatar has never worked for me (payment and discard work fine, but you get no creature on resolution of the ability.) I figured this was known/reported, but a search says it hasn't been. Sorry if it's old news.
A crash pops up sometimes (not always) after an attacking Goblin Guide causes the top card of the defender's library to be revealed, upon dismissing the window which reveals the card. I have not been able to repro this with the AI attacking me, but it's fairly frequent when I attack the AI. The crashes I'm getting today slightly differ from yesterday's, but I'll update if I see variation again.
Edit: I got the exact same crash (seen below) after playing an Inquisition of Kozilek on an opponent with no cards under 3 cmc in hand.
- Goblin Guide crash | Open
- You Win screen NPE | Open
Re: Bug Reports (snapshot builds)
by friarsol » 04 Apr 2013, 15:19
Hey Sloth,
Looks like the ActivationPhase for Dazzling Beauty is wrong. Was Trap Runner coming to? Or you leaving that up to swordshine or moomarc?
Looks like the ActivationPhase for Dazzling Beauty is wrong. Was Trap Runner coming to? Or you leaving that up to swordshine or moomarc?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Sloth » 04 Apr 2013, 18:47
Fixed! Thanks sol.
For swordshine or moomarc.friarsol wrote:Was Trap Runner coming to? Or you leaving that up to swordshine or moomarc?
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Who is online
Users browsing this forum: No registered users and 16 guests