Card Development Questions

[Hellfish]

Just ran a few tests and it looks really good. Havn't found any faults as of yet.

Mindslaver was an easy add, too.

NOTEDIT: Wrote the above before Marc posted. I'm not getting that problem at all. :/ As for the OK button, I had to enlarge the Prompt to find the OK and cancel buttons but they're there.

[Max mtg]

Thanks, Hellfish.
Mindslaver was not supposed to be hard when you have the effect to control other player. I just wanted someone to test the very effect.
It's good to learn that the issues described by Mark are only related to vmessage layout.

[moomarc]

Okay, all seems to be working this morning and so far no issues to report.. Thanks Max. Many people are going to love you for both these cards as well as the AIvsAI/hotseat.

[swordshine]

Aphetto Dredging can be implemented by "Announce$ CreatureType", but I'm not familar with the annouce code.
The script might be:

Aphetto Dredging | Open

Code: Select all

Name:Aphetto Dredging
ManaCost:3 B
Types:Sorcery
A:SP$ ChangeZone | Cost$ 3 B | Announce$ CreatureType | ValidTgts$ Creature.YouCtrl+ChosenType | TargetMin$ 0 | TargetMax$ 3 | AILogic$ MostProminentInComputerGraveyard | Origin$ Graveyard | Destination$ Hand | TgtPrompt$ Choose target creature card with the chosen type in your graveyard | SpellDescription$ Return up to three target creature cards of the creature type of your choice from your graveyard to your hand.
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/aphetto_dredging.jpg


I don't know how to make AI correctly use announce and target the creatures.

[Max mtg]

Announce wont' work this way.
You'll need to use AB$ ChooseType | Type$ Creature, and exec ChangeZone after that.

[friarsol]

Announce wont' work this way.
You'll need to use AB$ ChooseType , and append ChangeZone to it.

Except the timing isn't right for that either, since you need to Target before Spell Resolution.

[moomarc]

Announce wont' work this way.
You'll need to use AB$ ChooseType , and append ChangeZone to it.

The problem is that the targeting happens before choosing a type this way which is why the card was never implemented before. I think that's why Swordshine wanted to use announce, as the targeting could then be based on the announced type.

[Max mtg]

Announce is known to work only for human - in this way:

forge.card.spellability.HumanPlaySpellAbility.announceRequirements() | Open

Code: Select all

    private boolean announceRequirements() {
        // Announcing Requirements like Choosing X or Multikicker
        // SA Params as comma delimited list
        String announce = ability.getParam("Announce");
        if (announce != null) {
            for(String aVar : announce.split(",")) {
                String varName = aVar.trim();

                boolean isX = "X".equalsIgnoreCase(varName);
                CostPartMana manaCost = ability.getPayCosts().getCostMana();
                boolean allowZero = !isX || manaCost == null || manaCost.canXbe0();

                Integer value = ability.getActivatingPlayer().getController().announceRequirements(ability, varName, allowZero);
                if ( null == value )
                    return false;

                ability.setSVar(varName, value.toString());
                if( "Multikicker".equals(varName) ) {
                    ability.getSourceCard().setKickerMagnitude(value);
                } else {
                    ability.getSourceCard().setSVar(varName, value.toString());
                }
            }
        }
        return true;
    }


It's not supported by AI at all

[Sloth]

Announce is known to work only for human - in this way:

forge.card.spellability.HumanPlaySpellAbility.announceRequirements() | Open

Code: Select all

    private boolean announceRequirements() {
        // Announcing Requirements like Choosing X or Multikicker
        // SA Params as comma delimited list
        String announce = ability.getParam("Announce");
        if (announce != null) {
            for(String aVar : announce.split(",")) {
                String varName = aVar.trim();

                boolean isX = "X".equalsIgnoreCase(varName);
                CostPartMana manaCost = ability.getPayCosts().getCostMana();
                boolean allowZero = !isX || manaCost == null || manaCost.canXbe0();

                Integer value = ability.getActivatingPlayer().getController().announceRequirements(ability, varName, allowZero);
                if ( null == value )
                    return false;

                ability.setSVar(varName, value.toString());
                if( "Multikicker".equals(varName) ) {
                    ability.getSourceCard().setKickerMagnitude(value);
                } else {
                    ability.getSourceCard().setSVar(varName, value.toString());
                }
            }
        }
        return true;
    }


It's not supported by AI at all

The AI part is no problem. I can add it once it's commited.

[swordshine]

FORGE.CARD.SPELLABILITY.HUMANPLAYSPELLABILITY.ANNOUNCEREQUIREMENTS() | Open

Code: Select all

    private boolean announceRequirements() {
        // Announcing Requirements like Choosing X or Multikicker
        // SA Params as comma delimited list
        String announce = ability.getParam("Announce");
        if (announce != null) {
            for(String aVar : announce.split(",")) {
                String varName = aVar.trim();
                if ("CreatureType".equals(varName)) {
                    String choice = ability.getActivatingPlayer().getController().chooseSomeType("Creature",
                            ability.getParam("AILogic"), CardType.getCreatureTypes(), new ArrayList<String>());
                    ability.getSourceCard().setChosenType(choice);
                    return true;
                }
               
                boolean isX = "X".equalsIgnoreCase(varName);
                CostPartMana manaCost = ability.getPayCosts().getCostMana();
                boolean allowZero = !isX || manaCost == null || manaCost.canXbe0();

                Integer value = ability.getActivatingPlayer().getController().announceRequirements(ability, varName, allowZero);
                if ( null == value )
                    return false;

                ability.setSVar(varName, value.toString());
                if( "Multikicker".equals(varName) ) {
                    ability.getSourceCard().setKickerMagnitude(value);
                } else {
                    ability.getSourceCard().setSVar(varName, value.toString());
                }
            }
        }
        return true;
    }


The issue for AI is that AI can choose a creature type but the spell force me to choose the targets.

[Hanmac]

sorry if i am wrong, but did forge ship this infos as textfiles too or was that only in older versions?
i wanted to use them for some kind of statistics

[moomarc]

sorry if i am wrong, but did forge ship this infos as textfiles too or was that only in older versions?
i wanted to use them for some kind of statistics

The card scripts are in a zip file in the beta and snapshot releases and has been that way as far back as I can remember. I think its named cardsfolder.zip

[Hanmac]

AH thanks i miss the zip file

[Max mtg]

* Sphinx of Jwar Isle is hardcoded now. Can I implement its ability as : Dig 1 card ?
The only problem appears to be not to use stack for this action - could add a global parameter for all SAs to skip stack.

By the way, what if (sub)abilities marked with skipstack flag resolve right after costs are paid, and non-marked do as usual? That'll let us easily script that card that requires color before it is aded to stack

[friarsol]

* Sphinx of Jwar Isle is hardcoded now. Can I implement its ability as : Dig 1 card ?
The only problem appears to be 'skip stack' for this action.

I'm not sure that really helps, you should be able to do this when you don't have priority. Additionally that would not interact with things that prevented you from activating abilities, or raised cost on abilities.