Bug Reports (snapshot builds)

[swordshine]

Precursor Golem is broken now. CardFactory.copySpellontoStack does not add the defined target.

[Max mtg]

Precursor Golem is broken now. CardFactory.copySpellontoStack does not add the defined target.

Defined target was not a good idea for being an overriding field that has to be checked first. Moreover, it would create difficulties implementing redirecting spells (like 1st ability of Spellskite).

Computer assigns its spells targets in doTrigger/canPlayAi, HumanPlay class has a more obvious way to use preset targets
So the copied spells just don't call the code that might change targets while having players 'play' that spells using the targets written in regulat TargetChoices of a Spellability.

Anyway, I have refactored CopySpellAbilityEffect to make Precursor Golem work as supposed

[swordshine]

Deathrite Shaman's ability is not a mana ability, it should use stack.

[friarsol]

r22195
Gerrard Capashen triggers during my upkeep and the targeted opponent gains life instead of me.

[xbon]

r22195 Multiple activations of Keldon Battlewagon on the same stack multiply the effect, (e.g., tap 4 1/1 creatures, adds 16 power)

[Corwin72]

Today's build
Anavolver with double kicker costs 2 to much I think that the U kicker is being paid twice.

[swordshine]

I cannot declare blockers when ai is attacking my planeswalker.

[jsv]

r22232. Massacre, Infest, Decree of Pain (when cycling) and probably other PumpAll/Curse spells affect only caster's creatures.

[Chris H.]

Code: Select all

Unsupported file type of the sound file: res/sound/end_of_turn.wav - could not get audio input stream from input file

The file indeed looks more like a headerless mp3 than like a proper WAV. I'm attaching a converted version that works fine, even if after testing it I'm not so sure having this sound is such a good idea. It becomes somewhat annoying after a while.

 
Thank you, updated file was merged into the SVN.

We found a few other sound files for that sound but decided that they were even more annoying after a while.

[Chris H.]

Anywhere to get more recent snapshots? there hasn't been a new snapshot in 3 days, and I want to use some of the more recently fixed cards like the sliver.

 
Deployed a new snapshot a few minutes ago.

[Chris H.]

Chris, is it possible to release only windows/linux shapshots for the time being (until jendave fixes osx-related issues)?

 
Yes, no problem. A minor edit to my shell script does the job.

[Agetian]

r22241: A NPE after the "declare blockers" phase, nothing was actually blocked by anything as far as I know.

NullPointerException | Open

Code: Select all

Forge Version:    1.4.2-SNAPSHOT-r22241M
Operating System: Windows 7 6.1 x86
Java Version:     1.7.0_09 Oracle Corporation

java.lang.NullPointerException
   at forge.game.phase.Combat.getBlockers(Combat.java:449)
   at forge.game.phase.Combat.getBlockers(Combat.java:440)
   at forge.gui.match.TargetingOverlay.assembleArcs(TargetingOverlay.java:205)
   at forge.gui.match.TargetingOverlay.access$2(TargetingOverlay.java:80)
   at forge.gui.match.TargetingOverlay$OverlayPanel.paintComponent(TargetingOverlay.java:342)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JComponent.paintChildren(Unknown Source)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JLayeredPane.paint(Unknown Source)
   at javax.swing.JComponent.paintChildren(Unknown Source)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JLayeredPane.paint(Unknown Source)
   at javax.swing.JComponent.paintChildren(Unknown Source)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JComponent.paintToOffscreen(Unknown Source)
   at javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Unknown Source)
   at javax.swing.RepaintManager$PaintManager.paint(Unknown Source)
   at javax.swing.RepaintManager.paint(Unknown Source)
   at javax.swing.JComponent._paintImmediately(Unknown Source)
   at javax.swing.JComponent.paintImmediately(Unknown Source)
   at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
   at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
   at javax.swing.RepaintManager.prePaintDirtyRegions(Unknown Source)
   at javax.swing.RepaintManager.access$700(Unknown Source)
   at javax.swing.RepaintManager$ProcessingRunnable.run(Unknown Source)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$200(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


r22241: Another exception in my M2 phase, same game as above.

ConcurrentModificationException | Open

Code: Select all

Forge Version:    1.4.2-SNAPSHOT-r22241M
Operating System: Windows 7 6.1 x86
Java Version:     1.7.0_09 Oracle Corporation

java.util.ConcurrentModificationException
   at java.util.ArrayList$Itr.checkForComodification(Unknown Source)
   at java.util.ArrayList$Itr.next(Unknown Source)
   at forge.game.phase.Combat.getAttackingBandsOf(Combat.java:231)
   at forge.gui.match.controllers.CCombat.getCombatDescription(CCombat.java:74)
   at forge.gui.match.controllers.CCombat.update(CCombat.java:58)
   at forge.gui.match.CMatchUI.showCombat(CMatchUI.java:267)
   at forge.control.FControlGameEventHandler$3.run(FControlGameEventHandler.java:77)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$200(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


[friarsol]

r22244

Testing Shelkin Brownie and got this error:

UnsupportedOperationException | Open

Code: Select all

Forge Version:    SVN
Operating System: Windows 7 6.1 x86
Java Version:     1.7.0_21 Oracle Corporation

java.lang.UnsupportedOperationException
   at java.util.AbstractList.add(AbstractList.java:148)
   at java.util.AbstractList.add(AbstractList.java:108)
   at java.util.AbstractCollection.addAll(AbstractCollection.java:334)
   at forge.Card.addChangedCardKeywords(Card.java:4405)
   at forge.card.ability.effects.DebuffEffect.resolve(DebuffEffect.java:71)
   at forge.card.ability.AbilityApiBased.resolve(AbilityApiBased.java:62)
   at forge.card.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1058)
   at forge.card.ability.AbilityUtils.resolve(AbilityUtils.java:1041)
   at forge.game.zone.MagicStack.resolveStack(MagicStack.java:528)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:872)
   at forge.game.GameAction.startGame(GameAction.java:1456)
   at forge.game.Match$1.run(Match.java:105)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
   at java.lang.Thread.run(Thread.java:722)


[xbon]

Description: opponent tried to resolve Murder Investigation's effect

NullPointerException | Open

Code: Select all

Forge Version:    r22244
Operating System: Windows 8 6.2 x86
Java Version:     1.7.0_25 Oracle Corporation

java.lang.NullPointerException
   at forge.card.cardfactory.CardFactoryUtil$22.resolve(CardFactoryUtil.java:3241)
   at forge.game.zone.MagicStack.resolveStack(MagicStack.java:530)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:872)
   at forge.game.GameAction.startGame(GameAction.java:1456)
   at forge.game.Match$1.run(Match.java:105)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)


[swordshine]

The game freezes when I have more than 100 goblin tokens created by Empty the Warrens attacking. After I turn off the targeting arcs, it works well.

Unearth seems broken.

I got an IllegalStateException when I use Serum Power's ability.