UI now recieves updates from EventBus

[Sloth]

Imagine we have remote observers, or even fully-involved into game players. The current way it works requires server to send client updated state of all cards every time player gets priority... and even more often - as soon as any subability is resolved.

I don't think other viewers/players have to be send the game state after every subability. Only when input is required.

I'm not an expert on network communication, but sending lots of small pakages of data doesn't sound necessarily so much better than sending one big package.

[Max mtg]

Do you intend to delay propagation of open information, until the player gets priority?
And what about possible match spectators? Like human watching AI vs AI match... they will never receive updates then.

I don't want to update any cards that were not changed. But with these abilities cleared and re-applied every often, I have no means to filter out only the changed cards whose stats before clear and after re-apply are different.

[Agetian]

As of r22431, the situation with combat icons and sounds seems better but not quite completely resolved - not sure if it has to be resolved by now or not, but I thought I'd report my observations anyway: it seems like the blocker icon now appears when the AI blocks (at least most of the time?), but the appropriate sound doesn't fire, and when the human player declares the attack, the attacker icon still doesn't appear immediately. If it wasn't supposed to be fixed yet but the latest changes, feel free to ignore this message.

- Agetian

[Sloth]

Do you intend to delay propagation of open information, until the player gets priority?

Yes. That's pretty much how it has been. When the AI plays a land, suspends a card and then casts a spell you see the results all at once.

And what about possible match spectators? Like human watching AI vs AI match... they will never receive updates then.

Match spectators can receive an update whenever a player gets priority.

[Agetian]

As of r22480, when the AI declares blockers the icon is still not drawn immediately and the "blocker declared" sound does not fire either despite the changes in r22477/r22478...

P.S. Have looked at my IDE setup and it's definitely currently set to use spaces instead of tabs - the ones in SoundSystem must have been remnants of the old messed up config Now that reminded me I have to set NetBeans on my laptop properly though

- Agetian

[Agetian]

r22483: Blocker icons now appear correctly when the AI declares blockers but the related sound doesn't fire.

- Agetian

[Max mtg]

As of r22480, when the AI declares blockers the icon is still not drawn immediately and the "blocker declared" sound does not fire either despite the changes in r22477/r22478...

There was no sound when AI declares blockers in 1.4.2
Icon redraw granted

[jsv]

r22489. Double-faced cards are not redrawn when they transform (tested with Garruk Relentless and Villagers of Estwald)

[moomarc]

r22499: Morph creatures don't redraw when turned face up. Likewise, casting Backslide on a morph creature doesn't redraw the creature facedown.

[Max mtg]

These both problems have a similiar nature - I'll fix all transformations with a single commit (as I reach my computer at home)

Done - r22505

[jsv]

Another UI redraw issue when undoing/canceling a spell, lands do not untap.

Still an issue in r22519.

[Max mtg]

Another UI redraw issue when undoing/canceling a spell, lands do not untap.

Still an issue in r22519.

r22524 - no longer an issue.

It was somewhat dumb to redraw the whole player's battlefield because only a small number of cards should really have been updated. But I'll leave it for now - might return to this subject later when the project is closer to play over network.

[friarsol]

As of r22480, when the AI declares blockers the icon is still not drawn immediately and the "blocker declared" sound does not fire either despite the changes in r22477/r22478...

There was no sound when AI declares blockers in 1.4.2
Icon redraw granted

Still missing attacker icons being redrawn for AI. (Sometimes its immediate, sometimes it isnt?) And Human Attacker icons not being undrawn when right clicking.

Edit: Oh Attacker redraw issue is only for creatures with Vigilance I think.

[swordshine]

Assigned damage on card doesn't redraw at the end of turn.

[Max mtg]

Both fixed.
Is there anything else remaining?