Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by friarsol » 10 Jul 2013, 03:02
r22529
AI attacked with a 2/3 and a 3/3 Blind Creeper. I cast Righteous Blow targeting the Blind Creeper. It became a 2/2 because of it's ability, and then died. After combat, the AI cast Ghouldraiser returning the Blind Creeper to his hand, and then cast the Blind Creeper, which came into play tapped. So something is weird with LKI.
AI also had Vengeful Dead in play the whole time, which triggered when the Creeper died originally.
AI attacked with a 2/3 and a 3/3 Blind Creeper. I cast Righteous Blow targeting the Blind Creeper. It became a 2/2 because of it's ability, and then died. After combat, the AI cast Ghouldraiser returning the Blind Creeper to his hand, and then cast the Blind Creeper, which came into play tapped. So something is weird with LKI.
AI also had Vengeful Dead in play the whole time, which triggered when the Creeper died originally.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by swordshine » 10 Jul 2013, 13:40
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by Max mtg » 11 Jul 2013, 06:27
Now exiles are performed from non-edt thread.swordshine wrote:Description: Activated Serum Powder during Mulligan step
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by friarsol » 11 Jul 2013, 23:10
r22546
Tragic Slip (all Morbid?) is currently broken.
1. Cast two creatures with toughness of 2.
2. Cast Shock on the first one.
3. Cast Tragic Slip on the other.
Expected: 2nd Creature should die when it gets -13/-13.
Actual: 2nd Creature gets -1/-1 instead.
Edit: This repro does not work with tokens. Which means that the entered graveyard check for nontokens is broken. I'm guessing this is related to LKI changes, but I don't have anything to really back that up.
Edit2: This is the code I'm most suspicious of (in Zone.add()), but I don't know enough about what the changes were trying to achieve to know how to fix it.
Tragic Slip (all Morbid?) is currently broken.
1. Cast two creatures with toughness of 2.
2. Cast Shock on the first one.
3. Cast Tragic Slip on the other.
Expected: 2nd Creature should die when it gets -13/-13.
Actual: 2nd Creature gets -1/-1 instead.
Edit: This repro does not work with tokens. Which means that the entered graveyard check for nontokens is broken. I'm guessing this is related to LKI changes, but I don't have anything to really back that up.
Edit2: This is the code I'm most suspicious of (in Zone.add()), but I don't know enough about what the changes were trying to achieve to know how to fix it.
- Code: Select all
final Zone oldZone = game.getZoneOf(c);
// if any tokens come to battlefield, consider they are from stack. Plain "null" cannot be a key of EnumMap
final ZoneType zt = oldZone == null ? ZoneType.Stack : oldZone.getZoneType();
cardsAddedThisTurn.add(zt, c);
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 12 Jul 2013, 02:42
The quoted code adds cards entering this zone from other zones to multimap keyed by old zone type. This multimap is used to find out 'cards that entered the battlefiled this turn'
There were 2 arrays previously, one filled with cards other one with zones.
There were 2 arrays previously, one filled with cards other one with zones.
Last edited by Max mtg on 12 Jul 2013, 02:47, edited 1 time in total.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by friarsol » 12 Jul 2013, 02:46
Well, "final Zone oldZone = game.getZoneOf(c);" is returning null when a card goes from battlefield to graveyard. So something in that changelist is broken.Max mtg wrote:The quoted code adds cards entering this zone from other zones to multimap keyed by old zone type. This multimap is used to find out 'cards that entered the battlefiled this turn'
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 12 Jul 2013, 05:10
Then it's a question of "How a card could be added to zone without calling Zone.add(final Card c, final Integer index)?"
That method explicitly sets card's zone to 'this' - the one it is being added to
That method explicitly sets card's zone to 'this' - the one it is being added to
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Sloth » 12 Jul 2013, 08:56
This code doesn't work anymore because the cards get removed from the old zone before being added to the new one (since r22519).friarsol wrote:
- Code: Select all
final Zone oldZone = game.getZoneOf(c);
// if any tokens come to battlefield, consider they are from stack. Plain "null" cannot be a key of EnumMap
final ZoneType zt = oldZone == null ? ZoneType.Stack : oldZone.getZoneType();
cardsAddedThisTurn.add(zt, c);
EDIT: Fixed.
Last edited by Sloth on 12 Jul 2013, 09:38, edited 1 time in total.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by Max mtg » 12 Jul 2013, 09:01
game.getZoneOf(Card) redirects to Card.getZone() which reads a field from the Card class.
This field should not be updated except for when card is added to a zone.
So the code above should work.
This field should not be updated except for when card is added to a zone.
So the code above should work.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Agetian » 12 Jul 2013, 10:11
Stack description for Devour in Shadow is wrong - instead of showing the parameters of its target it shows up as if it's targeting itself (it says e.g. "Destroy Devour in Shadow. Human loses 0 life." instead of saying "Destroy <such-and-such creature>. Human loses <that creature's toughness> life."
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: Bug Reports (snapshot builds)
by Bundy » 12 Jul 2013, 11:05
Forge 1.4.3 - SNAPSHOT-r22534
I see some post of cards changing zone above, so maybe already fixed?
Description: Using the ultimate ability of Karn Liberated. Game can't continue, so i don't know what cards are returning to play.
I see some post of cards changing zone above, so maybe already fixed?
Description: Using the ultimate ability of Karn Liberated. Game can't continue, so i don't know what cards are returning to play.
- NullPointerException | Open
- Bundy
- Posts: 348
- Joined: 17 Dec 2010, 17:32
- Location: The netherlands
- Has thanked: 23 times
- Been thanked: 3 times
Re: Bug Reports (snapshot builds)
by Sloth » 12 Jul 2013, 11:30
Fixed! Thanks Bundy.Bundy wrote:Forge 1.4.3 - SNAPSHOT-r22534
I see some post of cards changing zone above, so maybe already fixed?
Description: Using the ultimate ability of Karn Liberated. Game can't continue, so i don't know what cards are returning to play.
- NullPointerException | Open
This didn't work because the card added was created like this: "copied = CardFactory.copyCard(c)" and copyCard didn't copy the currentZone variable.Max mtg wrote:game.getZoneOf(Card) redirects to Card.getZone() which reads a field from the Card class.
This field should not be updated except for when card is added to a zone.
So the code above should work.
So if you don't like my changes you can revert them and add copying of currentZone to copyCard.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by friarsol » 12 Jul 2013, 12:21
I tried that last night, and it didn't seem to work for me. YMMV.Sloth wrote:This didn't work because the card added was created like this: "copied = CardFactory.copyCard(c)" and copyCard didn't copy the currentZone variable.Max mtg wrote:game.getZoneOf(Card) redirects to Card.getZone() which reads a field from the Card class.
This field should not be updated except for when card is added to a zone.
So the code above should work.
So if you don't like my changes you can revert them and add copying of currentZone to copyCard.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 12 Jul 2013, 12:52
I cannot revert anything now. I have no keyboard 
Maybe you could just add the currentZone to fields copied by copyCard ?
Maybe you could just add the currentZone to fields copied by copyCard ?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Who is online
Users browsing this forum: No registered users and 21 guests