New Game Log Verbosity setting

by **spr** » 13 Jul 2013, 02:29

Hi,

I have added (r22564) a new Game Log Verbosity setting that will let you change how much info is displayed in the Game Log. It is next to the Dev Mode setting. Possible levels are -

Code: Select all: GAME_OUTCOME, MATCH_RESULTS, TURN, MULLIGAN, ANTE, PLAYER_CONROL, COMBAT, EFFECT_REPLACED, LAND, STACK_RESOLVE, STACK_ADD, DAMAGE, MANA, PHASE

The default is DAMAGE which is what it was hard-coded to previously.

Please note, this setting does not affect the underlying log only what is displayed - you will still get the same list of log events you get currently if you copy to clipboard at the end of a game.

This also uses a new FComboPanel class that can be used to display a theme-aware combobox with a caption.

Cheers,
Steve.

by **Max mtg** » 13 Jul 2013, 02:31

Oh, themed comboboxes are great!

Could you apply some to quest start dialog?

by **spr** » 13 Jul 2013, 02:56

Max mtg wrote:...Could you apply some to quest start dialog?

Sure thing. TBH I have not seen too many combos around - it seems to be mainly lists, in the settings anyway. I will keep an eye out and update as I find them.

Cheers,
Steve.

by **Max mtg** » 13 Jul 2013, 03:38

There aren't many around the game interface.

deckChooser might be another frame to use comboboxes (instead of 5 radio buttons). Still I am not sure if that would make the control really better. It will take less vertical space, but won't be as easy to discover possible options and select one.

The importance of log entries you were dealing with originally had only numbers (there was no logEntryType enum) - there was a comment explaining that numbers :- so the log messages were somehow groupped, but regretfully numbers were hardcoded right in classes that originated the events to be logged. I have replaced numbers and string ids for event types with a single enum, but this lead to too many log levels.

by **spr** » 13 Jul 2013, 10:59

Max mtg wrote:...
The importance of log entries you were dealing with originally had only numbers (there was no logEntryType enum) - there was a comment explaining that numbers...

Max, you mean this? -

Code: Select all: /** Logging level: * 0 - Turn [TURN] * 2 - Stack items [STACK_RESOLVE] * 3 - Poison Counters [DAMAGE] * 4 - Mana abilities [MANA] * 6 - All Phase information [PHASE] */

I have mapped each of these to what I think is the equivalent enumerated type. Would it be clearer to restrict the list to these 6 items instead?

Cheers,
Steve

by **Max mtg** » 13 Jul 2013, 12:14

Yes. That one.
I have no idea nor preference which is better.