[fixed mostly/closed]Manalink.csv/manastripe inconsistencies

[Korath]

A handful of land cards have different mana source colors specified in Manalink.csv than what eventually shows up in their mana stripes. Granted, the only thing I can find that actually currently looks at the manalink.csv value (which ends up in card_ptr_t::mana_color) is sub_43F800, which seems to be part of the sealed deck AI. It's the only thing I have to look at to determine land color for lands in the deckbuilder or a graveyard or library, though, so it'd be nice to get the ones that are clearly bugs fixed. Plus, in a couple cases, it's the in-play or in-hand version that's wrong.

Behavior as of OtIv2 and recommendations:

Land	In print	Deckbuilder/graveyard/library	In hand	In play	Notes
Shadowmoor/Eventide filter lands (Cascade Bluffs, Fetid Heath, Fire-Lit Thicket, Flooded Grove, Graven Cairns, Mystic Gate, Twilight Mire, Sunken Ruins, Wooded Bastion, Rugged Prairie)	U/R, etc.	correct	correct	nothing	Already fixed in next version due to interaction with Reflecting Pool, IIRC
Gemstone Caverns	colorless	gold	colorless	colorless or WUBGR, depending on counter	A case could be made for leaving this alone for sealed deck generation, but it's probably closer to a Glimmerpost than a City of Brass. Recommend change manalink.csv value to colorless.
Lorwyn vivid lands (Vivid Crag, Vivid Creek, Vivid Grove, Vivid Marsh, Vivid Meadow)	per primary color	gold	per primary color	WUBGR or primary color, depending on counter	Recommend leaving unchanged.
Tendo Ice Bridge	gold	gold	colorless	colorless or XWUBGR, depending on counter	In-print version contradicts vivid lands! Recommend leaving unchanged.
Simic Growth Chamber	G/U	B/G	G/U	G/U	clear bug in manalink.csv
Sungrass Prairie	G/W	nothing	card is green/white, but no manastripe	same as in hand	In-play already fixed in next version, IIRC
Torment tainted lands (Tainted Field, Tainted Isle, Tainted Peak, Tainted Wood)	W/B, etc.	nothing	nothing	nothing	separate bug report filed
Vesuva	colorless	gold	colorless	colorless	Colorless manastripe in-play even after copying; separate bug report filed. Recommend manalink.csv gold->colorless.
Urborg, Tomb of Yawgmoth	black	nothing	black	black	Recommend manalink.csv colorless->black
Shimmering Grotto	gold	gold	colorless	colorless	Tentatively recommend changing in-hand and in-play colorless->XWUBGR.
Mirrodin artifact lands (Ancient Den, Great Furnace, Seat of the Synod, Vault of Whispers)	per color	per color	colorless	per color	These four show up as colorless mana when in hand, only. The fifth, Tree of Tales, correctly shows as green everywhere.
Cavern of Souls	gold	gold	colorless	colorless	Half isn't even approximated; and the approximation on the other half is very inconsistent. Recommend disabling the card.
Invasion sac-lands (Ancient Spring, Geothermal Crevice, Irrigation Ditch, Sulfur Vent, Tinder Farm)	gold	gold	per primary color	per primary color	Similar argument to Gemstone Cavern, though more tentatively, and despite their in-print color; i.e., recommend changing manalink.csv values to primary color only. These currently don't show up with Reflecting Pool, but changing their manastripe to all three colors would cripple the AI.
Phyrexian Tower	predates nonbasic land coloring	black	colorless	colorless	This doesn't get its black manastripe even when there's a creature to sac to it. Recommend changing in-hand/in-play colorless->XB, preferably only when its controller has a creature also.

[Korath]

Autocard doesn't seem to work in the same post as a table (even outside it), so for reference:
Cascade Bluffs, Fetid Heath, Fire-Lit Thicket, Flooded Grove, Graven Cairns, Mystic Gate, Twilight Mire, Sunken Ruins, Wooded Bastion, Rugged Prairie
Gemstone Caverns
Vivid Crag, Vivid Creek, Vivid Grove, Vivid Marsh, Vivid Meadow
Tendo Ice Bridge
Simic Growth Chamber
Sungrass Prairie
Tainted Field, Tainted Isle, Tainted Peak, Tainted Wood
Vesuva
Urborg, Tomb of Yawgmoth
Shimmering Grotto
Ancient Den, Great Furnace, Seat of the Synod, Vault of Whispers, Tree of Tales
Cavern of Souls
Ancient Spring, Geothermal Crevice, Irrigation Ditch, Sulfur Vent, Tinder Farm
Phyrexian Tower

Oh, and some motivation:

[Aswan jaguar]

Professional work to say the least.
About AI that I want so badly to help him as much as possible,has a lot of problems caused by lands:
- AI not playing a single card if some lands are in AI hand,
- AI stalling playing a land for few turns if certain lands are in his hand or
- just miss the first land drop,
- and other weird behaviours (like AI doesn't miss land drops with many lands IF AI PLAYS SECOND/DRAWS FIRST).
- Strange but AI has land problems even with some lands made by the original Microprose developers.

I had made a lot of tests about lands-AI and wrote a survey(never finished though) maybe you want to take a look:

viewtopic.php?f=86&t=5726&start=15#p85404

[Aswan jaguar]

It is just me,but for all land cards except BASIC in the deck builder they have all this "gold" more of a "Light Brown" manastripes.Am I missing something?
Also you got me confused at first as I thought you were talking about the mana stripes on the top right corner of the card, of what mana a land can produce.(but they are not visible in deck builder or library,graveyard,exile).

[Korath]

You're not missing anything, no - right now, they're all drawn with CardBk_Land, and the only way the differences will manifest is in the sealed deck deckbuilder AI miscounting its mana, and by clicking the Stats button in the deckbuilder. It's frankly pretty amazing that there's only nine that are even arguably wrong there. (The in-hand and in-play columns do refer to the diagonal mana stripes that appear in these two zones, which will be identical to the mana in most cases.)

Here's one way to confirm with a standard drawcardlib, besides looking directly at the mana source color column of Manalink.csv:

[HarlequinCasts]

Not sure if related but on the subject of artifact lands, I've been noticing they don't work correctly with Felwar Stone. Specifically Tree of Tales seems to be acting weird. I'll make another post, but wanted to mention since Felwar Stone is maybe a good test for mana stripe related things.

Posted here

[Sonic]

I've checked back to the 2000_no_more_beta file and some of these errors have existed since the original construction of the manalink3.xls file. Although, I'm partially to blame for not checking the Mana Source Colors field when completing the data for a card activation.

Simic Growth Chamber = 10 - Should be 12

Sungrass Prairie = 0
Tainted Field = 0
Tainted Isle = 0
Tainted Peak = 0
Tainted Wood = 0
Krosan Verge = 0

I'll go through the file and do a thorough check.

[Korath]

If you're going to tweak Krosan Verge, then all ten of the Onslaught/Zendikar fetchlands are set as colorless, too; all eleven cards the fetches and modern reprints of Krosan Verge were printed like two-color lands (the Judgment printing of Krosan Verge was colorless, despite two-color lands being printed as hybrid by then). Setting their color in manalink.csv will color them in libraries/graveyards/deckbuilder, but they'll be drawn colorless in play and in hand, since they have no manastripe.

I thought about an option to special-case them, but didn't want to deal properly with Magical Hack, was afraid to check if the fetches themselves dealt properly with Magical Hack, looked at the consistently colorless printings of Terramorphic Expanse, and decided not to bother.