Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by drdev » 29 Jul 2013, 23:28
Yeah, that's what I thought. I guess the match screen is using that function to refresh itself. Probably be good to add a comment there to prevent someone else falling into the same trap I did. I plan to commit a fix in the next couple hours.Max mtg wrote:Must be that one: http://svn.slightlymagic.net/websvn/dif ... &peg=22682drdev wrote:I think I know what change I made that would have broken this. I'll fix it today.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by xbon » 29 Jul 2013, 23:34
Description: I hit 0 health from opponents Lava Runner, and Crimson Mage, I just destroyed their Vastwood Hydra. They targetted Lava Runner with Vastwood Hydra's ability
- IllegalStateException | Open
Re: Bug Reports (snapshot builds)
by friarsol » 30 Jul 2013, 01:11
r22698
AI attacks with Lightning Elemental, I cast unsummon. AI recasts after combat, but the Elemental ETB tapped. (Not resetting tap state changing zones)
Even weirder, it doesn't seem to actually untap after that? .. Wait, it just untapped when a Cloud Elemental was cast. I can't tell if this is a redraw issue or what the deal is. There is definitely no Intruder Alarm out or anything else like that.
AI attacks with Lightning Elemental, I cast unsummon. AI recasts after combat, but the Elemental ETB tapped. (Not resetting tap state changing zones)
Even weirder, it doesn't seem to actually untap after that? .. Wait, it just untapped when a Cloud Elemental was cast. I can't tell if this is a redraw issue or what the deal is. There is definitely no Intruder Alarm out or anything else like that.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by drdev » 30 Jul 2013, 01:16
Just committed the fix for this issue in r22699.drdev wrote:Yeah, that's what I thought. I guess the match screen is using that function to refresh itself. Probably be good to add a comment there to prevent someone else falling into the same trap I did. I plan to commit a fix in the next couple hours.Max mtg wrote:Must be that one: http://svn.slightlymagic.net/websvn/dif ... &peg=22682drdev wrote:I think I know what change I made that would have broken this. I'll fix it today.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by drdev » 30 Jul 2013, 02:30
Is right-click specifically meant to do that, or does left click work for it to? What is the expected behavior for right-clicking cards in general given there are no context menus? I had made changes to select cards on mouse up instead of mouse down, and specifically only did so on left-click, though I can easily support selecting them on right-click too. I just don't think we should be able to right-click a card to automatically activate an ability, tap a land, or play a card, which was what was happening before.xbon wrote:r22700, right click to cancel block/attack no longer works.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by friarsol » 30 Jul 2013, 03:09
Yes, it's specifically meant for that. Left click is to declare an attacker/blocker, right click to undeclare an attacker/blocker. This isn't for activating things, it's a specific ability for Combat.drdev wrote:Is right-click specifically meant to do that, or does left click work for it to? What is the expected behavior for right-clicking cards in general given there are no context menus? I had made changes to select cards on mouse up instead of mouse down, and specifically only did so on left-click, though I can easily support selecting them on right-click too. I just don't think we should be able to right-click a card to automatically activate an ability, tap a land, or play a card, which was what was happening before.xbon wrote:r22700, right click to cancel block/attack no longer works.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by drdev » 30 Jul 2013, 14:31
It sounds like you're suggesting that left-clicking an attacker/blocker will allow activation it's abilities, but abilities shouldn't be able to be activated in the Declare Attackers or Declare Blockers phases, so why not let left clicking undeclare the attacker/blocker? This sounds like a design oversight to me.friarsol wrote:Yes, it's specifically meant for that. Left click is to declare an attacker/blocker, right click to undeclare an attacker/blocker. This isn't for activating things, it's a specific ability for Combat.drdev wrote:Is right-click specifically meant to do that, or does left click work for it to? What is the expected behavior for right-clicking cards in general given there are no context menus? I had made changes to select cards on mouse up instead of mouse down, and specifically only did so on left-click, though I can easily support selecting them on right-click too. I just don't think we should be able to right-click a card to automatically activate an ability, tap a land, or play a card, which was what was happening before.xbon wrote:r22700, right click to cancel block/attack no longer works.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by friarsol » 30 Jul 2013, 14:50
No. You are misunderstanding. Left click is to attack/block, right click to unattack/unblock. There's additional functionality related to banding when you left click an attacker that's already attacking.drdev wrote:It sounds like you're suggesting that left-clicking an attacker/blocker will allow activation it's abilities, but abilities shouldn't be able to be activated in the Declare Attackers or Declare Blockers phases, so why not let left clicking undeclare the attacker/blocker? This sounds like a design oversight to me.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Corwin72 » 30 Jul 2013, 15:08
Build from 2 days ago.
Forgotten Ancient freezes the game if you choose to move 0 counters.
Forgotten Ancient freezes the game if you choose to move 0 counters.
-
Corwin72 - Posts: 793
- Joined: 15 Sep 2009, 13:26
- Location: Grayson, Ga
- Has thanked: 25 times
- Been thanked: 9 times
Re: Bug Reports (snapshot builds)
by drdev » 30 Jul 2013, 16:15
I guess that makes sense. I'm just wondering how discoverable the need to right-click is is for people used to MTGO. Perhaps a tooltip could help if there isn't one already?friarsol wrote:No. You are misunderstanding. Left click is to attack/block, right click to unattack/unblock. There's additional functionality related to banding when you left click an attacker that's already attacking.drdev wrote:It sounds like you're suggesting that left-clicking an attacker/blocker will allow activation it's abilities, but abilities shouldn't be able to be activated in the Declare Attackers or Declare Blockers phases, so why not let left clicking undeclare the attacker/blocker? This sounds like a design oversight to me.
EDIT: Right-click support fixed for cards in r22713. Also, since I noticed that the prompt suggests right-clicking to undeclare, there's no need for a tooltip, so never mind on that idea.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by friarsol » 31 Jul 2013, 04:06
r22713
AI illegally ignores the "can't be blocked by creature tokens" granted by Legion Loyalist
AI illegally ignores the "can't be blocked by creature tokens" granted by Legion Loyalist
- Game Log | Open
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by xbon » 31 Jul 2013, 05:02
Description: Just passed priority, Field is on my side Null Champion Level 1, on theirs, Blightsoil Druid.
- NullPointerException | Open
Re: Bug Reports (snapshot builds)
by Max mtg » 31 Jul 2013, 06:50
For NPE @ CombatUtil.canBeBlocked(CombatUtil.java:188)
code @PumpAiBase:236 first checks that phase is before declare attackers, then uses combat which is obviously null (for there is no combat at that moment) to perform canBlock checks
I have applied a npe check at CombatUtil:177, but that does not seem to fix all possible errors on this code path
code @PumpAiBase:236 first checks that phase is before declare attackers, then uses combat which is obviously null (for there is no combat at that moment) to perform canBlock checks
I have applied a npe check at CombatUtil:177, but that does not seem to fix all possible errors on this code path
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by andrewd13 » 31 Jul 2013, 07:55
- andrewd13
- Posts: 17
- Joined: 29 Jul 2013, 15:43
- Has thanked: 0 time
- Been thanked: 0 time
Who is online
Users browsing this forum: No registered users and 17 guests