Bug reports

[hong yie]

My Rancor did not return to my hand when my creature died. I am pretty sure it used to work properly. It even popped up to say putting Rancor back into owners hand but nothing happened.

can you send in the screenshot or the event log when it happened ?
this will be useful to track certain cards that might doesn't work well with rancor.

[melvin]

My Rancor did not return to my hand when my creature died. I am pretty sure it used to work properly. It even popped up to say putting Rancor back into owners hand but nothing happened.

Thanks, confirmed that all cards which use the card script "dies effect Return SN to its owner's hand" are broken as the effect assumes it is returning a permanent not a card. Working on a fix now.

Update: Fixed in https://code.google.com/p/magarena/sour ... 47775833f6

[muppet]

Also Tamiyo, The Moon Sage in case you missed that one I haven't applied the fix yet myself but it may not be covered.
I assume I have to download the whole compiled version rather than just changing the files affected if I want to fix it before the next release?

[melvin]

Also Tamiyo, The Moon Sage in case you missed that one I haven't applied the fix yet myself but it may not be covered.

Tamiyo should not be affected by this bug as it doesn't use the card script for that ability. Did you observe this bug with Tamiyo?

I assume I have to download the whole compiled version rather than just changing the files affected if I want to fix it before the next release?

That's correct. You could download one of the hourly builds of 1.44 that has this fix (plus nice UI upgrades) from https://buildhive.cloudbees.com/job/mel ... arena/554/

[muppet]

yes the card did not come back to my hand. So I just assumed it was the same thing. This is after I used the -8 ability. Can't actually remember what the card was possibly it was a burn spell Burst Lightning maybe.

[Huggybaby]

See attached.

[melvin]

Thanks, Huggybaby. I assume this happens when you click the "Undo" button? Looks like we were trying to update the UI on multiple threads and causing a race condition, fixed for next release in https://code.google.com/p/magarena/sour ... 4a49a0e75b

[melvin]

yes the card did not come back to my hand. So I just assumed it was the same thing. This is after I used the -8 ability. Can't actually remember what the card was possibly it was a burn spell Burst Lightning maybe.

I check and couldn't replicate the bug with Tamiyo and Burst Lightning both with and without kicker. Do post more details if you observe this bug next time, thanks!

[Huggybaby]

Thanks, Huggybaby. I assume this happens when you click the "Undo" button? Looks like we were trying to update the UI on multiple threads and causing a race condition, fixed for next release in https://code.google.com/p/magarena/sour ... 4a49a0e75b

Yes, I do believe multiple undos were involved.

ensure that update to LogBookViewer is performed on EDT

Eastern Daylight Time?

[melvin]

ensure that update to LogBookViewer is performed on EDT

Eastern Daylight Time?

Seems like you caught my use of jargon, well in this case EDT is Event Dispatch Thread. The reason for this special thread is because Swing (our UI framework) is single threaded so any change to UI should be handled by this special thread so that things are consistent. When other threads manipulate the UI, it is possible to reach an inconsistent state, as is the case with the update to the LogBookViewer in the performUndo method.

The proper way to perform UI changes in the controller thread is to wrap it in a Runnable object and submit this to the EDT using the invokeLater method. That is what the fix does.

[Huggybaby]

Nice! Thanks for the explanation.

But you're too kind, I was being funny. Well, maybe being a smartass.

[sponeta]

Druid's Deliverance prevents damage to caster and creatures, even though the card text only specifies "you".

[sponeta]

Angelic Edict allows you to target an artifact or enchantment, even though the card text says "creature or enchantment".

[melvin]

Angelic Edict allows you to target an artifact or enchantment, even though the card text says "creature or enchantment".

Thanks! Fixed in https://code.google.com/p/magarena/sour ... 5fc5efb918 for next release

Druid's Deliverance prevents damage to caster and creatures, even though the card text only specifies "you".

Confirmed. Working on a fix.

[melvin]

Prevent damage fixed in https://code.google.com/p/magarena/sour ... 25b4aca974

Took the chance to clean up that part as some code was using a special player state to record these effects, changed them to use a replacement effect.