Bug Reports (snapshot builds)
Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by Yamazaki » 06 Dec 2013, 19:10
Description: I played in quest mode againdt Selesnya 2012. Ai attacked me with his cards. then window with crash report appears.
- ConcurrentModificationException | Open
- Yamazaki
- Posts: 2
- Joined: 06 Dec 2013, 19:07
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by swordshine » 07 Dec 2013, 15:25
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by aacid » 07 Dec 2013, 16:38
Hi,
when I play Condescend to counter opponents spell, it resolves, I pay more mana than he can pay, then I Scry 2 but finally opponents spell is NOT countered.
when I play Condescend to counter opponents spell, it resolves, I pay more mana than he can pay, then I Scry 2 but finally opponents spell is NOT countered.
- aacid
- Posts: 1
- Joined: 07 Dec 2013, 16:35
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by drdev » 07 Dec 2013, 16:49
What version of Forge are you running? This sounds like an issue I recently fixed that would be available in the latest snapshot or if you update your source.aacid wrote:Hi,
when I play Condescend to counter opponents spell, it resolves, I pay more mana than he can pay, then I Scry 2 but finally opponents spell is NOT countered.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by Max mtg » 07 Dec 2013, 23:13
fixed with 23917swordshine wrote:r23904
Description: When I cast Pithing Needle, the game crashed.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Yamazaki » 09 Dec 2013, 09:03
Description: In Constructed mode I chose my deck, then Random 1 for AI, and that reveals
- RuntimeException | Open
- Yamazaki
- Posts: 2
- Joined: 06 Dec 2013, 19:07
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by oskarolw » 10 Dec 2013, 09:18
r23933
Description: Trying to cast undercity informer, I had payed the 2 colorless mana already but only had a green left in pool, I pressed space which I assume is the auto button and then got this crash.
Description: Trying to cast undercity informer, I had payed the 2 colorless mana already but only had a green left in pool, I pressed space which I assume is the auto button and then got this crash.
- IllegalStateException | Open
Re: Bug Reports (snapshot builds)
by Max mtg » 10 Dec 2013, 19:02
Quite expected, because any actions changing game state are not supposed to be executed from UI thread.oskarolw wrote:r23933
Description: Trying to cast undercity informer, I had payed the 2 colorless mana already but only had a green left in pool, I pressed space which I assume is the auto button and then got this crash.
I suggest that auto-payment feature removed.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by drdev » 11 Dec 2013, 00:23
Max that's a bit of an overreaction. The Auto button works fine in most cases. I just need to investigate why it isn't in this one case.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by swordshine » 12 Dec 2013, 05:05
Varolz, the Scar-Striped is broken. StaticAbilityContinuous.java line 419 should be updated.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by drdev » 12 Dec 2013, 11:55
I fixed this issue by having the Auto button run its logic in the Game thread using ThreadUtil.invokeInGameThreadAndWait, a new function I added. Is that solution acceptable?Max mtg wrote:Quite expected, because any actions changing game state are not supposed to be executed from UI thread.oskarolw wrote:r23933
Description: Trying to cast undercity informer, I had payed the 2 colorless mana already but only had a green left in pool, I pressed space which I assume is the auto button and then got this crash.
I suggest that auto-payment feature removed.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by Max mtg » 12 Dec 2013, 12:31
Nope, you are locking GUI thread while you wait for Game thread to perform actions. If during that calculations game needs any input from human player (which is unlikely but still possible while our hardcoded calls to GUi aren't eliminated), you'll end up in a deadlock.drdev wrote:I fixed this issue by having the Auto button run its logic in the Game thread using ThreadUtil.invokeInGameThreadAndWait, a new function I added. Is that solution acceptable?
use game.getAction().invoke(runnable) instead. (in the same fashion as activateManaAbility handles mana ability activation, where runnable )
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by drdev » 12 Dec 2013, 12:57
Alright, how's this:Max mtg wrote:Nope, you are locking GUI thread while you wait for Game thread to perform actions. If during that calculations game needs any input from human player (which is unlikely but still possible while our hardcoded calls to GUi aren't eliminated), you'll end up in a deadlock.drdev wrote:I fixed this issue by having the Auto button run its logic in the Game thread using ThreadUtil.invokeInGameThreadAndWait, a new function I added. Is that solution acceptable?
use game.getAction().invoke(runnable) instead. (in the same fashion as activateManaAbility handles mana ability activation, where runnable )
- Code: Select all
//must run in game thread as certain payment actions can only be automated there
game.getAction().invoke(new Runnable() {
@Override
public void run() {
runAsAi(proc);
//call showMessage in GUI thread after mana cost paid
FThreads.invokeInEdtLater(new Runnable() {
@Override
public void run() {
InputPayMana.this.showMessage();
}
});
}
});
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by Max mtg » 12 Dec 2013, 13:12
That's fine.drdev wrote:Alright, how's this:Max mtg wrote:Nope, you are locking GUI thread while you wait for Game thread to perform actions. If during that calculations game needs any input from human player (which is unlikely but still possible while our hardcoded calls to GUi aren't eliminated), you'll end up in a deadlock.drdev wrote:I fixed this issue by having the Auto button run its logic in the Game thread using ThreadUtil.invokeInGameThreadAndWait, a new function I added. Is that solution acceptable?
use game.getAction().invoke(runnable) instead. (in the same fashion as activateManaAbility handles mana ability activation, where runnable )
And if you want to dismiss the input right after mana was paid, try to call onStateChanged()
- Code: Select all
//must run in game thread as certain payment actions can only be automated there
game.getAction().invoke(new Runnable() {
@Override
public void run() {
runAsAi(proc);
onStateChanged()
}
});
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by drdev » 13 Dec 2013, 01:00
Calling onStateChanged is cleaner, so I changed it to do that. Thanks.Max mtg wrote:That's fine.
And if you want to dismiss the input right after mana was paid, try to call onStateChanged()Add: ah, showMessage calls this onStateChanged anyway, so no big difference.
- Code: Select all
//must run in game thread as certain payment actions can only be automated there
game.getAction().invoke(new Runnable() {
@Override
public void run() {
runAsAi(proc);
onStateChanged()
}
});
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Who is online
Users browsing this forum: No registered users and 56 guests