Bug reports

[melvin]

Hourly build #658 includes the rollback on the icons, https://buildhive.cloudbees.com/job/mel ... arena/658/

[muaddib]

Can't tap Cinder Pyromancer

[muaddib]

Absent text

[muaddib]

Can't cast Wildslayer Elves and then use Forbidden Lore enchanted first land.
While cast Wildslayer Elves Magarena automatically tap first land and can't do tap land manually.

[ShawnieBoy]

Fixed Cinder Pyromancer, The land tapping priority is an ongoing issue and will have a look at the ability choice when I get back from work

[melvin]

Absent text

Thanks for the report! Fixed in https://code.google.com/p/magarena/sour ... 633df5f8a3

[jerichopumpkin]

Absent text

Thanks for the report! Fixed in https://code.google.com/p/magarena/sour ... 633df5f8a3

I've noticed that this happens with other cards too, i.e. Vizkopa Guildmage does not display any text for lifelink ability

[melvin]

I've noticed that this happens with other cards too, i.e. Vizkopa Guildmage does not display any text for lifelink ability

Yup, all cards using the ability "pay <cost>: <chosen> gain <ability>" template are affected.

[jerichopumpkin]

Found a mistype in Alpha Kavu, it gives +1/+1 instead of -1/+1
Alpha_Kavu.txt

Code: Select all

name=Alpha Kavu
url=http://magiccards.info/ps/en/77.html
image=http://mtgimage.com/card/alpha%20kavu.jpg
value=2.338
rarity=U
type=Creature
subtype=Kavu
cost={2}{G}
pt=2/2
ability=pay {1}{G}:Target Kavu creature gets -1/+1 until end of turn.
timing=main


[melvin]

Thanks for the report! Fixed in https://code.google.com/p/magarena/sour ... 3609cc5712

[jerichopumpkin]

This one's mine: I've scripted Idyllic Tutor as Enlightened Tutor, so the enchantment is put on top of deck instead in hand.
Here is the right version:
Idyllic_Tutor.groovy

Code: Select all

def ENCHANTMENT_CARD_FROM_LIBRARY = new MagicCardFilterImpl() {
    public boolean accept(final MagicGame game,final MagicPlayer player,final MagicCard target) {
        return target.hasType(MagicType.Enchantment);
    }
    public boolean acceptType(final MagicTargetType targetType) {
        return targetType == MagicTargetType.Library;
    }
};

def AN_ENCHANTMENT_CARD_FROM_LIBRARY = new MagicTargetChoice(
    ENCHANTMENT_CARD_FROM_LIBRARY,
    "an enchantment card"
);

[
    new MagicSpellCardEvent() {
        @Override
        public MagicEvent getEvent(final MagicCardOnStack cardOnStack,final MagicPayedCost payedCost) {
            return new MagicEvent(
                cardOnStack,
                this,
                "PN may search his or her library for an enchantment card, reveals it, put it into his or her hand, and shuffle his or her library."
            );
        }
        @Override
        public void executeEvent(final MagicGame game, final MagicEvent event) {
            game.addEvent(new MagicSearchIntoHandEvent(
                event,
                AN_ENCHANTMENT_CARD_FROM_LIBRARY
            ));
        }
    }
]


[melvin]

This one's mine: I've scripted Idyllic Tutor as Enlightened Tutor, so the enchantment is put on top of deck instead in hand.

Thanks for the fix, applied in https://code.google.com/p/magarena/sour ... 9dee7ecc37

[jerichopumpkin]

Wingrattle Scarecrow is broken, persist does not trigger, although you control a black creature

[ShawnieBoy]

Thanks for that find - (A testament to always playtest everything )

I know the code should work, and it does (in a way) - The bug is due to the peculiar timing involved. Here's the strange bit:

The persist ability is only present while Wingrattle Scarecrow is in play.

Due to cards in the graveyard not being able to have abilities, as soon as Wingrattle Scarecrow leaves play, the MagicStatic(MagicLayer.Ability) stops checking to see what abilities it should have. In a similar way Undying Evil also doesn't work for a similar reason.

Creatures gaining Undying or Persist looks like a problem

Affected cards: Antler Skulkin, Rattleblaze Scarecrow, Undying Evil, Wingrattle Scarecrow,

[melvin]

The bug with Wingrattle Scarecrow is related to certain types of triggers which cannot be added to permanents, one such class of triggers are those that extend MagicWhenPutIntoGraveyardTrigger, of which MagicWhenDiesTrigger is a member. The fix is to move MagicWhenDiesTrigger to a different type, implemented in https://code.google.com/p/magarena/sour ... 055fb9fffe

The issue with Antler Skulkin and Undying Evil is another problem to do with the fact that MagicGainAbilityAction only handles abilities without implementation (flying, first strike, lifelink, etc). Fixed in https://code.google.com/p/magarena/sour ... 9170f9190e to handle abilities with implementation (persist, undying, exalted, etc)

PS: Originally Magarena only had abilities without implementation, abilities with implementation (has addAbilityImpl method in MagicAbility) were added later. Abilities without implementation were implemented directly in the engine elsewhere in the program, this is discouraged for new abilities. Abilities with implementation is the preferred method going forward for new abilities.