Generated Commander Decks
Post MTG Forge Related Programming Questions Here
	Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins
			6 posts
			 • Page 1 of 1
		
	
Generated Commander Decks
 by moomarc » 04 Mar 2014, 11:18
by moomarc » 04 Mar 2014, 11:18 
Hey guys, just a quick question. Has anyone had any problems with the generated Commander decks or noticed it violating any Commander deck rules, or did I manage to get it working first attempt? Should it be changed in any way?
			-Marc
		- 
				 
 moomarc
- Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Generated Commander Decks
 by Sloth » 04 Mar 2014, 13:06
by Sloth » 04 Mar 2014, 13:06 
I did a quick test and the only problem i found is that nonbasic lands were added in multiples (dual-, pain- and fetchlands) which violates the singleton rule.
Otherwise it was all correct.
			
		Otherwise it was all correct.
- 
				 
 Sloth
- Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Generated Commander Decks
 by moomarc » 04 Mar 2014, 15:06
by moomarc » 04 Mar 2014, 15:06 
The issue with non-basic land appearing in duplicates is also true for other generated decks when Singletons is set to true. Any idea how to fix that? The code there is a bit over the top of my head.
			-Marc
		- 
				 
 moomarc
- Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Generated Commander Decks
 by Sloth » 04 Mar 2014, 16:20
by Sloth » 04 Mar 2014, 16:20 
I will try to fix that later today. No problem.
			
		- 
				 
 Sloth
- Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Generated Commander Decks
 by Sloth » 04 Mar 2014, 20:02
by Sloth » 04 Mar 2014, 20:02 
Even though my comment for r25042 is messed up, this is fixed now.
			
		- 
				 
 Sloth
- Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Generated Commander Decks
 by moomarc » 05 Mar 2014, 13:52
by moomarc » 05 Mar 2014, 13:52 
Thanks a lot Sloth! Really appreciate it.
			-Marc
		- 
				 
 moomarc
- Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
			6 posts
			 • Page 1 of 1
		
	
Who is online
Users browsing this forum: No registered users and 21 guests
