Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by Agetian » 05 Sep 2014, 05:41
r27216: Here's an easy-to-reproduce and serious bug that can lock up the game completely: if, in your Main phase, you click a spell card [with at least some mana cost, i.e. non-land] in your hand (to start casting a spell) and then accidentally hit E ("end turn") when you're prompted to pay mana, the game will first show "Cannot pass priority at this time" and will then get permanently locked up in the "Waiting for opponent..." state. Nothing helps except quitting Forge (or at least restarting the match by agreeing to concede).
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: Bug Reports (snapshot builds)
by drdev » 05 Sep 2014, 13:47
Fixed in r27218.Agetian wrote:r27216: Here's an easy-to-reproduce and serious bug that can lock up the game completely: if, in your Main phase, you click a spell card [with at least some mana cost, i.e. non-land] in your hand (to start casting a spell) and then accidentally hit E ("end turn") when you're prompted to pay mana, the game will first show "Cannot pass priority at this time" and will then get permanently locked up in the "Waiting for opponent..." state. Nothing helps except quitting Forge (or at least restarting the match by agreeing to concede).
- Agetian
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by friarsol » 05 Sep 2014, 21:54
Did something change with optional Triggered Abilities that cost mana? Previously with these abilities we would just provide the mana cost with the "option" to hit cancel to cancel out. Since paying mana is always optional, this streamlines the need for me to say "Yes" to the option, before tapping my lands. This seems to slow me a fair amount, especially when I have a payment trigger every turn (from say a Pyre Zombie in my graveyard). What's the deal with this change? Anyone know?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by KrazyTheFox » 08 Sep 2014, 03:28
Drana, Kalastria Bloodchief correctly reduces its target's toughness, but does not gain any power.
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Bug Reports (snapshot builds)
by Agetian » 08 Sep 2014, 18:09
r27258: When there are two or more planeswalkers on the opponent's field and I cast a direct damage spell, I get a prompt if I want to redirect the said damage to each of the planeswalkers (in a sequence). However, if I say "yes", the interface allows me to directly click the exact planeswalker that I want to redirect the damage to, so prompting for each planeswalker beforehand seems superfluous (and somewhat irritating) in the context of being able to just visually target after clicking "yes". Perhaps there should be one prompt just saying "Would you like to redirect damage to a planeswalker"?..
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: Bug Reports (snapshot builds)
by friarsol » 09 Sep 2014, 02:02
It seems like copied tokens either aren't getting their ManaCost set properly, or the LKI isn't tracking it appropriately. I had this situation come up in a Momir Basic game this afternoon which prevented me from getting an Emrakul. 
In Play: Soldevi Adnate, Ebony Rhino (a copied token, I can repro this via Rite of Replication on an Ebony Rhino in play since using Momir to repro is unlikely).
Tapping the Adnate and sacrifice the Copied Rhino, expecting to get 7 Black mana. Instead I get 0.
In Play: Soldevi Adnate, Ebony Rhino (a copied token, I can repro this via Rite of Replication on an Ebony Rhino in play since using Momir to repro is unlikely).
Tapping the Adnate and sacrifice the Copied Rhino, expecting to get 7 Black mana. Instead I get 0.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by KrazyTheFox » 09 Sep 2014, 02:24
The good news is I think I found your bug. On line 632 of forge.game.card.CardFactory:friarsol wrote:It seems like copied tokens either aren't getting their ManaCost set properly, or the LKI isn't tracking it appropriately. I had this situation come up in a Momir Basic game this afternoon which prevented me from getting an Emrakul.
In Play: Soldevi Adnate, Ebony Rhino (a copied token, I can repro this via Rite of Replication on an Ebony Rhino in play since using Momir to repro is unlikely).
Tapping the Adnate and sacrifice the Copied Rhino, expecting to get 7 Black mana. Instead I get 0.
- Code: Select all
// TODO - most tokens mana cost is 0, this needs to be fixed
// c.setManaCost(manaCost);
c.addColor(manaCost);
c.setToken(true);
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Bug Reports (snapshot builds)
by friarsol » 09 Sep 2014, 02:35
AH that's silly. I figured it was an LKI thing. I'll uncomment and commit if it seems to fix it.KrazyTheFox wrote:
The good news is I think I found your bug. On line 632 of forge.game.card.CardFactory:I looked through the history briefly and found this TODO is well over a year old. It looks as though this should be a relatively simple fix, but I'm going to bed in just a minute and don't have the time to test anything if I were to fix it now.
- Code: Select all
// TODO - most tokens mana cost is 0, this needs to be fixed
// c.setManaCost(manaCost);
c.addColor(manaCost);
c.setToken(true);
Edit: Ah no.. This isn't going through the Token effect, it's going through the CopyPermanent effect. I think this is more likely a token/LKI issue.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by KrazyTheFox » 09 Sep 2014, 03:12
Did a little more debugging and you're right in that I was looking in the wrong place. However, it does appear that the copied token has the mana cost correctly set (though I can't be sure since I'm so unfamiliar with this code). Hopefully that narrows it down a bit.friarsol wrote:Edit: Ah no.. This isn't going through the Token effect, it's going through the CopyPermanent effect. I think this is more likely a token/LKI issue.
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Bug Reports (snapshot builds)
by Agetian » 11 Sep 2014, 09:14
r27279: This NPE appeared every time after an AI vs. AI duel was over in a quest draft tournament (did not stop me from proceeding further, was just irritating):
- Agetian
- NullPointerException | Open
- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: Bug Reports (snapshot builds)
by Fizanko » 13 Sep 2014, 22:53
Just noticed in latest snapshot, some boosters have strange text, by example a M15 and Dragon Maze :
Noticed Dragon Maze "fat pack" has it too
Noticed Dragon Maze "fat pack" has it too
probably outdated by now so you should avoid : Innistrad world for Forge (updated 17/11/2014)
Duel Decks for Forge - Forge custom decks (updated 25/10/2014)
Duel Decks for Forge - Forge custom decks (updated 25/10/2014)
Re: Bug Reports (snapshot builds)
by Fizanko » 13 Sep 2014, 23:21
I played Llanowar Elite and selected the kicker version, and as soon as i selected the kicker version, this error appeared :
- NullPointerException | Open
In previous duels the card played correctly when kicked, so i think it may be something else on the battlefield (see screenshot) that may have triggered this.
edit : now that i think about it, it may be possible i didn't had enough mana to pay the 8 for the kicking.
Elvish Mystic had Presence of Gond attached
Penumbra Bobcat had Bladed Pinions attached
probably outdated by now so you should avoid : Innistrad world for Forge (updated 17/11/2014)
Duel Decks for Forge - Forge custom decks (updated 25/10/2014)
Duel Decks for Forge - Forge custom decks (updated 25/10/2014)
Re: Bug Reports (snapshot builds)
by friarsol » 13 Sep 2014, 23:49
Yea I guess we don't really have a description field for Boosters. This field is just being filled by the booster definition. Certain boosters like (as you noticed) M15 and Dragon's Maze are oddly structured. For M15 for example, there's a whole bunch of cards that are technically in the set, but don't actually show up in boosters. Similarly, DGM has a specific land slot and all lands in the set show up in that slot instead of their normal rarity slot.Fizanko wrote:Just noticed in latest snapshot, some boosters have strange text, by example a M15 and Dragon Maze :
Noticed Dragon Maze "fat pack" has it too
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by KrazyTheFox » 14 Sep 2014, 01:47
This appears to be caused by auras being attached (and equipment?) to permanents with mana abilities. It would appear that's true for the Elvish Mystic in your post. The following setup will always cause the game to crash with the same error:Fizanko wrote:
I played Llanowar Elite and selected the kicker version, and as soon as i selected the kicker version, this error appeared :I clicked on the cancel button, tried to replay it with Kicker and same error.
- NullPointerException | Open
In previous duels the card played correctly when kicked, so i think it may be something else on the battlefield (see screenshot) that may have triggered this.
edit : now that i think about it, it may be possible i didn't had enough mana to pay the 8 for the kicking.
Elvish Mystic had Presence of Gond attached
Penumbra Bobcat had Bladed Pinions attached
- NPE | Open
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Who is online
Users browsing this forum: No registered users and 11 guests