Upcoming Release: Forge version 1.5.57

[Agetian]

Before I do the release, is there anything notable that needs to be in the changes file?

Overall it seems like a rather quiet "bugfix and incremental update" type of release. Some of the highlights that may be worth mentioning include an assortment of Kaladesh card fixes, various bug fixes elsewhere in the code, some AI improvements and also the display of energy counters under the player's avatar in desktop version of Forge.

Maybe someone else can remember something else of interest

- Agetian

[Hanmac]

There is some ugly bug with play something (without paying it's mana cost) somehow prevent it from playing or selecting additional cost.

But I don't know if I can fix that before the release.

There are two missing conspiracy cards I forgot to commit last time.

[friarsol]

There is some ugly bug with play something (without paying it's mana cost) somehow prevent it from playing or selecting additional cost.

Are these new bugs or old bugs? We can just mention that it's a known issue and try to get it fixed for the next release.

[friarsol]

There are two missing conspiracy cards I forgot to commit last time.

Is there any reason you still haven't committed them? It's been 3 weeks...

[Hanmac]

@friarsol:

about that bug: i don't know its a new one or old one.
it seems new but i don't know when it did come from.

i just simply forgot to commit them
i think they should be somewhere in the thread.

[friarsol]

Since Vehicles are a considerable portion of Standard right now, hopefully we can get this targeting issue fixed before the release...

[Hanmac]

Since Vehicles are a considerable portion of Standard right now, hopefully we can get this targeting issue fixed before the release...

found the bug with Vehicle and Animate was something with CopyCard.

now i need to find the one why Play Spell Effect does not select the Additional Costs :/

[KrazyTheFox]

Any updates on this? Am I good to go for a release or are we still waiting on fixes?

[Hanmac]

Any updates on this? Am I good to go for a release or are we still waiting on fixes?

i found why "Play Spell Effect does not select the Additional Costs"
it goes deep into checkZoneRestrictions, and there it does return false.
it is somehow related to my changes with mayPlay, but i wonder why it does now make problems.

I try to fix it without breaking more.
===
i have it return true for no zone restriction.
hopefully it does work and does not break anything.

[friarsol]

Hanmac, what do you think, did those last two things get resolved enough? It'd be nice to get a bugfix release out the door..

[Hanmac]

Yeah I fixed the last things and it seems as if it didn't Break anything.

There might be some visual problems you notice in the other Thread, but that's not that critical to block a release.

[friarsol]

Krazy, I think whenever you can get a release out would be great.

[KrazyTheFox]

Sorry, Civ VI came out and I've been completely neglecting everything. I'll do a release today.

[Hanmac]

XD yeah such a game can be very time consuming. XD
i recommend you try out simutrans.

about a release, i think you might do it,
or you can wait until C16 is finish.

[Agetian]

I think a patch-up Kaladesh release would be appropriate (without waiting for C16, which might take another month). At least that's my $0.02.

Warning: it looks like as things stand right now, 16 tests fail and the game fails to compile. If tests are suppressed, the game fails to compile with the following error log:

Code: Select all

[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/agetian/NetBeansProjects/trunk/forge-gui-mobile/src/forge/deck/FDeckEditor.java:[526,39] cannot find symbol
  symbol:   method getCommander()
  location: variable deck of type forge.deck.Deck
[ERROR] /home/agetian/NetBeansProjects/trunk/forge-gui-mobile/src/forge/deck/FDeckEditor.java:[918,67] cannot find symbol
  symbol:   method getCommander()
  location: class forge.deck.Deck
[ERROR] /home/agetian/NetBeansProjects/trunk/forge-gui-mobile/src/forge/deck/FDeckEditor.java:[954,85] cannot find symbol
  symbol:   method getCommander()
  location: class forge.deck.Deck


Maybe something is missing / not finished regarding the latest Commander-related changes?..

- Agetian