It is currently 16 Apr 2024, 11:01
   
Text Size

Hour of Devastation spoiler season

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Hour of Devastation spoiler season

Postby austinio7116 » 30 Jun 2017, 22:38

Thanks Marek - committed.
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

Re: Hour of Devastation spoiler season

Postby swordshine » 01 Jul 2017, 09:47

Marek14 wrote:I think that the "Whenever CARDNAME crews a Vehicle" triggers don't work right -- they trigger after the crew ability resolves, but they should trigger after it's activated. A Vehicle can still get a P/T bonus when not animated, it just won't do anything until it becomes a creature.
Fixed. Vizier of the Anointed is also fixed.
swordshine
 
Posts: 682
Joined: 11 Jul 2010, 02:37
Has thanked: 116 times
Been thanked: 87 times

Re: Hour of Devastation spoiler season

Postby Marek14 » 01 Jul 2017, 17:26

Final batch - too many cards and various minor corrections to list them all.

Notes:
Azorius Ploy - corrected "prevent damage to this" keyword since it's only supposed to work on combat damage. Please check that it works. Also, shouldn't these keywords be hidden? They are not supposed to be removed by Humility and such...
Dagger of the Worthy - test if this simple code works
Essence Flare - I corrected AB$ -> DB$, but there's one more problem with the card (might potentially affect other similar cards): Once the ability triggers, the creature that will be affected should be locked in and moving the Aura should not change that.
Lethal Sting - couldn't add. The most similar card is Hatchet Bully, and it's implemented wrong, with an extra target. Does AddCounter cost accept extra syntax a la SubCounter on Novijen Sages?
Saving Grace - pretty complex, will probably need some adjustments. I'm not completely clear on whether the creature Saving Grace redirects damage to is locked in when the trigger resolves or whether it changes when Saving Grace is moved later during the turn.
Attachments
hou6.zip
(34.41 KiB) Downloaded 242 times
Marek14
Tester
 
Posts: 2759
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 296 times

Re: Hour of Devastation spoiler season

Postby Agetian » 01 Jul 2017, 18:40

Thanks a lot for your contributions, Marek! :) Committed. Tested Dagger of the Worthy, seems to work well. Can't provide input on the other cards, unfortunately, hopefully someone else can provide more insight on those points.

Note: Did not yet apply the fix for Vizier of the Annointed from this batch, since this card was fixed today in a different way by Swordshine, effectively removing the EmbalmOrEternalize trigger with it. Not sure if maybe some other action is now necessary for this card, or maybe not.

With Marek's latest submission included, we are only missing two cards now:
Code: Select all
Abandoned Sarcophagus
Lethal Sting
- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Re: Hour of Devastation spoiler season

Postby Marek14 » 01 Jul 2017, 21:10

Agetian wrote:Thanks a lot for your contributions, Marek! :) Committed. Tested Dagger of the Worthy, seems to work well. Can't provide input on the other cards, unfortunately, hopefully someone else can provide more insight on those points.

Note: Did not yet apply the fix for Vizier of the Annointed from this batch, since this card was fixed today in a different way by Swordshine, effectively removing the EmbalmOrEternalize trigger with it. Not sure if maybe some other action is now necessary for this card, or maybe not.

With Marek's latest submission included, we are only missing two cards now:
Code: Select all
Abandoned Sarcophagus
Lethal Sting
- Agetian
My changes for Vizier of the Anointed were just replacing its text by the correct wording -- it was probably done from early translated version of the card.
Marek14
Tester
 
Posts: 2759
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 296 times

Re: Hour of Devastation spoiler season

Postby Agetian » 02 Jul 2017, 07:34

Ah, gotcha! Corrected now :)

- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Re: Hour of Devastation spoiler season

Postby austinio7116 » 02 Jul 2017, 20:46

The Scarab God does not seem to return to your hand at the end step when it dies. The ability triggers but it stays in the graveyard.
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

Re: Hour of Devastation spoiler season

Postby austinio7116 » 02 Jul 2017, 21:14

Same for locust and scorpion gods too.
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

Re: Hour of Devastation spoiler season

Postby austinio7116 » 02 Jul 2017, 21:40

Fixed - committed rev 34563
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

Re: Hour of Devastation spoiler season

Postby Rooger » 02 Jul 2017, 21:48

Unsummon isn't showing the card pic, even though i have the image for it with correct syntax. Is anyone having this issue?

Edit:just checked and this happens for all other sets tha card was in, it's probably a typo on the card script.
Rooger
 
Posts: 88
Joined: 06 Jan 2013, 06:59
Has thanked: 44 times
Been thanked: 35 times

Re: Hour of Devastation spoiler season

Postby stormcat » 02 Jul 2017, 21:58

:r34563
Endless Sand : Wrong Rarity [Common -> Rare]
Dust : Can't choose target creature
stormcat
 
Posts: 361
Joined: 17 Jun 2015, 05:32
Has thanked: 0 time
Been thanked: 6 times

Re: Hour of Devastation spoiler season

Postby stormcat » 03 Jul 2017, 03:16

:r34564
Wretched Camel is 2/1 not 2/4.
stormcat
 
Posts: 361
Joined: 17 Jun 2015, 05:32
Has thanked: 0 time
Been thanked: 6 times

Re: Hour of Devastation spoiler season

Postby stormcat » 03 Jul 2017, 05:10

:r34564
Unquenchable Thirst has wrong cost.
Displayed mana cost is true, but when I play it, demand 1UU.
stormcat
 
Posts: 361
Joined: 17 Jun 2015, 05:32
Has thanked: 0 time
Been thanked: 6 times

Re: Hour of Devastation spoiler season

Postby austinio7116 » 03 Jul 2017, 05:44

Rooger wrote:Unsummon isn't showing the card pic, even though i have the image for it with correct syntax. Is anyone having this issue?

Edit:just checked and this happens for all other sets tha card was in, it's probably a typo on the card script.
Unsummon is showing my card image named Unsummon.full.jpg fine with revision 34563
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

Re: Hour of Devastation spoiler season

Postby Rooger » 03 Jul 2017, 06:28

austinio7116 wrote:Unsummon is showing my card image named Unsummon.full.jpg fine with revision 34563
You are right, i already posted my issue on the Beta release thread. It turns out to be a different problem that affects Unsummon as well as other random cards. Sets also have more lands than the original release with extra lands having no card pics too (for instance, HOU have 3 Swamps but Forge is showing me 9). Haven't found a fix for it though.
Rooger
 
Posts: 88
Joined: 06 Jan 2013, 06:59
Has thanked: 44 times
Been thanked: 35 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 42 guests


Who is online

In total there are 42 users online :: 0 registered, 0 hidden and 42 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 42 guests

Login Form