Bug Reports (snapshot builds)
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by friarsol » 28 Mar 2019, 02:51
You shouldn't need AltImages anymore. The way tokens work now, is that they are defined in several places:AStrangerIsHere wrote:1.6.23-SNAPSHOT-r196-51e9e2b692
The new token system is not really working, or should I say not for all cards. Tokens created with History of Benalia doesn't display any pictures IF I name them w_2_2_knight_vigilance_dom. But without the _dom at the end, it works. But the script (?) for the card is:And there's a question I would liked to ask: is it still possible to display different pictures for the same token? In the past, I would modify a card by adding TokenAltImages$ w 2 2 knight dom2 for example. Does that still work?SVar:DBToken:DB$ Token | TokenAmount$ 1 | TokenScript$ w_2_2_knight_vigilance | TokenOwner$ You | LegacyImage$ w 2 2 knight vigilance dom | SpellDescription$ Create a 2/2 white Knight creature token with vigilance.
Edit: ok, it still works BUT only without the _dom at the end of the name, so now it's TokenAltImages$ w 2 2 knight vigilance2, at least for History of Benalia. I have to try for the other cards.
1) As a token script
2) In the editions file that produces that token
For tokens that have multiple images, multiple instances of the normalized name "w_2_2_knight_vigilance" should appear in the editions file. So in the Dominaria editions file, you see two instances of that and 3 instances of Saprolings. Based on the edition,
So I tried your exact test case with the auto-downloader on and it decided to try to load:
Forge\Cache\pics\tokens\w_2_2_knight_vigilance2_dom.jpg
Forge will randomly decide based on the token + edition which file to load. I'm guessing when you were trying it, you didn't have anything in place for both:
w_2_2_knight_vigilance_dom.jpg
w_2_2_knight_vigilance2_dom.jpg
The reason it works without the dom is that's Forge's general pattern for all images. First try for the edition specific image, then the non-edition specific image. In the future where specific cards generate specific image tokens, we'll have a mapping in place so it doesn't just randomly grab from everything.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by AStrangerIsHere » 29 Mar 2019, 01:17
1.6.23-SNAPSHOT-r196-51e9e2b692
Another token problem, but with Conclave Cavalier. No picture again. The cause is how the name is written. In the card, gw_2_2_elf_knight_vigilance is used, but in the edition file, it's wg_2_2_elf_knight_vigilance. The color are reversed: gw and wg.
The cost is GGWW, so I guess gw should be the correct way to write it...
Another token problem, but with Conclave Cavalier. No picture again. The cause is how the name is written. In the card, gw_2_2_elf_knight_vigilance is used, but in the edition file, it's wg_2_2_elf_knight_vigilance. The color are reversed: gw and wg.
The cost is GGWW, so I guess gw should be the correct way to write it...
- AStrangerIsHere
- Posts: 164
- Joined: 22 Jan 2019, 01:17
- Has thanked: 45 times
- Been thanked: 29 times
Re: Bug Reports (snapshot builds)
by AStrangerIsHere » 29 Mar 2019, 02:01
1.6.23-SNAPSHOT-r196-51e9e2b692
The AI doesn't play Cavalry Drillmaster. But by adding SVar:PlayMain1:TRUE, it does, at least if it has already a creature on the board.
The AI doesn't play Cavalry Drillmaster. But by adding SVar:PlayMain1:TRUE, it does, at least if it has already a creature on the board.
- AStrangerIsHere
- Posts: 164
- Joined: 22 Jan 2019, 01:17
- Has thanked: 45 times
- Been thanked: 29 times
Re: Bug Reports (snapshot builds)
by trombonesjones » 29 Mar 2019, 06:46
When Karma is changed by Magical Hack from swamps to a different kind of land, Karma still only affects swamps and not the newly chosen lands. Also when Great Druid ability is activated it changes the lands type to a include forest instead of changing the lands type to just forest. I.e swamp/forest not just forest.
- trombonesjones
- Posts: 21
- Joined: 03 Feb 2018, 02:32
- Has thanked: 1 time
- Been thanked: 1 time
Re: Bug Reports (snapshot builds)
by Fallencleric » 29 Mar 2019, 11:23
Floating Shield does not work properly with pro white when attached to white permanents. It should stick but goes to grave.
Reality Acid trigger does not work when flickered by Felidar Guardian (Acid Trip deck from Net Decks)
Mana cost of Fuse cards is calculated wrong (as I assume) as Expertise Fuse deck is not working. I.e. Sram's Expertise does not allow to cast Breaking/Entering (Expertise Fuse Reanimator deck from Net Decks abuses this mechanic).
Reality Acid trigger does not work when flickered by Felidar Guardian (Acid Trip deck from Net Decks)
Mana cost of Fuse cards is calculated wrong (as I assume) as Expertise Fuse deck is not working. I.e. Sram's Expertise does not allow to cast Breaking/Entering (Expertise Fuse Reanimator deck from Net Decks abuses this mechanic).
- Fallencleric
- Posts: 1
- Joined: 29 Mar 2019, 10:48
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by psly4mne » 29 Mar 2019, 14:55
The Expertise Fuse deck is supposed to not work - see https://magic.wizards.com/en/articles/archive/news/amonkhet-split-card-rules-changes-2017-04-04.
Re: Bug Reports (snapshot builds)
by friarsol » 30 Mar 2019, 01:15
Thanks for the reports. Updating so many tokens is bound to have a few mistakes.AStrangerIsHere wrote:1.6.23-SNAPSHOT-r196-51e9e2b692
Another token problem, but with Conclave Cavalier. No picture again. The cause is how the name is written. In the card, gw_2_2_elf_knight_vigilance is used, but in the edition file, it's wg_2_2_elf_knight_vigilance. The color are reversed: gw and wg.
The cost is GGWW, so I guess gw should be the correct way to write it...
https://git.cardforge.org/core-develope ... uests/1493
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by AStrangerIsHere » 31 Mar 2019, 01:06
1.6.23-SNAPSHOT-r202-42f6cdbb46
Not really a bug, but the date is wrong for Ravnica Allegiance Guild Kit. 2018-02-15 is used in the file, but it should be 2019.
Not really a bug, but the date is wrong for Ravnica Allegiance Guild Kit. 2018-02-15 is used in the file, but it should be 2019.
- AStrangerIsHere
- Posts: 164
- Joined: 22 Jan 2019, 01:17
- Has thanked: 45 times
- Been thanked: 29 times
Re: Bug Reports (snapshot builds)
by AStrangerIsHere » 03 Apr 2019, 12:15
1.6.23-SNAPSHOT-r202-42f6cdbb46
Something strange. Here's the thing, sometimes when I have double land on the board, I can't choose to auto pay the cost for my cards. For example I could play Fireblade Artist with a Blood Crypt and a Godless Shrine, but it's impossible, unless I choose to manually tap my lands. So it might be possible for the AI to have the same problem.
Something strange. Here's the thing, sometimes when I have double land on the board, I can't choose to auto pay the cost for my cards. For example I could play Fireblade Artist with a Blood Crypt and a Godless Shrine, but it's impossible, unless I choose to manually tap my lands. So it might be possible for the AI to have the same problem.
- AStrangerIsHere
- Posts: 164
- Joined: 22 Jan 2019, 01:17
- Has thanked: 45 times
- Been thanked: 29 times
Re: Bug Reports (snapshot builds)
by MaxMtg » 03 Apr 2019, 14:37
Is it just me or forge's gitlab isn't working?
git.cardforge.org/core-developers/forge/activity
git.cardforge.org/core-developers/forge/activity
Re: Bug Reports (snapshot builds)
by friarsol » 03 Apr 2019, 21:52
We're working on it. There was an issue with the host.MaxMtg wrote:Is it just me or forge's gitlab isn't working?
git.cardforge.org/core-developers/forge/activity
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Tayqual » 04 Apr 2019, 01:17
Infernal Reckoning image shows casting cost as 1 black mana. When casting cost is 1 white mana. This seems off. This is in 1.6.22.
Re: Bug Reports (snapshot builds)
by friarsol » 04 Apr 2019, 02:35
Should be fixed now: https://git.cardforge.org/core-develope ... uests/1498Tayqual wrote:Infernal Reckoning image shows casting cost as 1 black mana. When casting cost is 1 white mana. This seems off. This is in 1.6.22.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by MaxMtg » 05 Apr 2019, 12:53
How can I set the card image for garruk the slayer? he is not part of any "set"/edition file
Re: Bug Reports (snapshot builds)
by Cdr » 06 Apr 2019, 20:32
Anyone having trouble with abbot of keral keep. It exiles the card but won't let me play it at all
- Cdr
- Posts: 1
- Joined: 06 Apr 2019, 20:22
- Has thanked: 0 time
- Been thanked: 0 time
Who is online
Users browsing this forum: KeithOvart and 96 guests