[fixed]Emberwilde caliph doesn't trigger vs planeswalkers

[travolter]

Describe the Bug:
Wizard does not lose life each time Emberwilde Caliph does damage

Which card did behave improperly ?
Emberwilde Caliph

Which update are you using?
dev version 250c78bd updated to 11-5-19 /DUEL

[Aswan jaguar]

I solved the bug by putting the correct DDBM flag in commit 0d56ea9e but although I tried a lot can't make it trigger for damage made to planeswalkers. Only 1 function for cards that deal damage to anything seems to work correctly with planeswalkers the spirit_link_effect but uses a different approach.

current code | Open

int card_emberwilde_caliph(int player, int card, event_t event){
/* CARD_ID_EMBERWILDE_CALIPH 2463
Emberwilde Caliph |2|U|R
Creature - Djinn 4/4
Flying, trample
~ attacks each turn if able.
Whenever ~ deals damage, you lose that much life. */

attack_if_able(player, card, event);

check_damage_test(player, card, event, DDBM_REPORT_DAMAGE_DEALT, player, card, 0, NULL);

if( resolve_damage_trigger(player, card, event, DDBM_REPORT_DAMAGE_DEALT, player, card) ){
int amount = get_card_instance(player, card)->targets[16].player;
get_card_instance(player, card)->targets[16].player = 0;

lose_life(player, amount);
}

return 0;
}

[travolter]

Nice job Aswan!!!
At least you found a working solution. With current fix the card is perfectly playable in a block like "Mirage" one where no planeswalkers are present.

Im reading teh code and I think that sooner or later Ill have to help you with the code. At least with simple tasks and learning from currently working coded cards to reuse code.

[Korath]

Setting |DDBM_MUST_DAMAGE_PLANESWALKER (which, to be fair, would be better named DDBM_DONT_FORBID_DAMAGE_TO_PLANESWALKER) doesn't work?

[Aswan jaguar]

I had tried DDBM_MUST_DAMAGE_PLANESWALKER flag before but I must have made a silly mistake and didn't apply it also to resolve_damage_trigger. Anyway now it works, thanks for the help Korath.

edit: Fixed in commit 27695511 also fixed same bug for Tamanoa and fix Sunhome Enforcer that triggered on all damage.