[fix] Riptide Replicator tokens have no creature type

[gnomefry]

Describe the Bug:

Tokens produced by Riptide Replicator do not have the chosen creature type. Or any creature type. The Riptide Replicator itself does come into play with tags on it displaying the chosen creature type and color, but upon creating a token only the color is correct.

Which card behaved improperly?

Riptide Replicator

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
Manalink 5-2020 10bda4ca0 - gauntlet

What exactly should be the correct behavior/interaction?

Tokens have the chosen color and creature type.

Are any other cards possibly affected by this bug?

No.

[drool66]

Fixed in 38403a64d ("Fix Riptide Replicator tokens have no creature type", 2020-06-05)

The two functions it uses together are 267 lines long, but the only thing missing was the line where it actually set the subtype

[Aswan jaguar]

Did you look at this or test any with test scenarios with cards like the ones mentioned there?

[drool66]

So that is a separate issue.

Gargaroz:Modified the code of both Riptide Replicator / Volrath's Laboratory: if you choose a creature type that matches an actual token, you'll get it (and further work is needed to standardize the entry of that tokens, as you could generate a 4/4 green Angel with flying with the Laboratory, which is obviously incorrect), in the other case you'll get the old token and I've modified the functions which check the "name" of the permanents to comply with that.

Looks like when he did that he missed the line that actually assigns the creature type to a token without an ID ( ie token.action = TOKEN_ACTION_ADD_SUBTYPE). Without that line, those type of tokens (those without a csv entry) do not have any creature type and can't be buffed by, say, adaptive automaton. He also never did the parenthesized part of changing P/T & abilities. I can actually do this pretty easily since I had to do it for Eternalize.
What they still don't have is a name, which leads to the complications Korath outlines. This does work properly for clones (eg. casting Doubling Chant on a cloned Memnite tutors you a Memnite), so it's probably possible with tokens. The answer is probably somewhere between lines 3685 and 3781 in functions.c, or in get_abilities in events.c, or maybe in copy_token_characteristics_for_clone in token_generation.c

[Aswan jaguar]

He also never did the parenthesized part of changing P/T & abilities. I can actually do this pretty easily since I had to do it for Eternalize.

Ok, I will leave this open and still bugged for the above part and archive this once this last thing gets fixed and have the other post for the other bugs.

[drool66]

Ok, should be fully fixed in 5cdd68b5a ("Fix token bugs", 2020-06-19)

[Edit: to be clear, fully fixed minus the name issue - as in both p/t and abilities have been addressed]