[fixed]Mirrorwing Dragon - doesnt copy for all targets

by **Wally** » 04 Jul 2020, 04:46

Describe the Bug:
Mirrorwing Dragon does not create a copy for all eligible targets (all legal target creatures controlled by caster of the copied spell). In attached save the fireball cast at the dragon should copy for (and kill) all the AI's creatures (you may need to load it a couple of times as sometimes the AI targets both player as well as the dragon (negating the dragon's ability))

Mirrorwing Dragon also sends copies of the copied spell to the graveyard (so a copied fireball for instance results in multiple cards in graveyard)

Which card behaved improperly?
Mirrorwing Dragon

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
version 6-2020 v3 a8bbff706, duel

by **drool66** » 04 Jul 2020, 05:22

It may have something to do with fireball still being coded in exe. The reason for this is the beautiful UI has not been decoded, so it's been kept inside the "black box" of Magic.exe. Have you seen this behavior with any other card targeting Mirrorwing Dragon or any of the other spell radiating creatures?

by **Wally** » 04 Jul 2020, 05:26

Not yet, I will test against some other cards and see what happens

by **Wally** » 04 Jul 2020, 05:57

Test 1: Mirrorwing Dragon vs Blaze

Result: Copy of spell was correctly created for each eligible target but *I* took the damage for each copy not the creature. 17 copies of Blaze sent to graveyard (orig card + the 16 copies

by **drool66** » 04 Jul 2020, 17:45

Oh dear, I just looked at the code for Mirrorwing Dragon and it looks like I dropped the ball somewhere with changing to a token & assigning targets. I'll have this fixed ASAP. Not sure if it also affects the other spell radiating creatures but I'll check them as well.

by **drool66** » 05 Jul 2020, 21:45

Fixed in 0419920f4 ("Revert "Spell Radiating Creatures"", 2020-07-05) & 26639d117 ("Retire generic_x_spell(), +Swallowing Plague", 2020-07-05)

So I made a big error by switching spell radiating creatures to use play_card_in_hand_for_free(), namely that these spells were copied. But, two cards were still using the outdated generic_x_spell, and one of them happened to be Blaze. Actually, the other was unimplemented (Swallowing Plague) so Blaze was the only card in Manalink using that function. It didn't have features like redirecting targets, or allowing targets to be set, as is required by Mirrorwing Dragon et al.

The issue I was trying to fix by switching to play_card_in_hand_for_free() is that the copied spells cannot be countered or otherwise interacted with as they should be.