[fixed]Angrath, Minotaur Pirate - bad parameters and crash

by **Wally** » 30 Sep 2020, 10:29

Describe the Bug:
Angrath, Minotaur Pirate - threw up a bad parameters dialogue then game crashed to desktop on using 3rd ability

bad parameters
get_card_instance(1, 251662879)
0: 0x0253E188
1: 0x024F2B3E
2: 0x024F99D5
3: 0x024FB407
4: 0x024FC0A1
5: 0x0212E7B8
6: 0x004018E0
7: 0x004A2806
8: 0x0254E415
9: 0x0252B97D
10: 0x0252C0A6
11: 0x004368C6
12: 0x02500998
13: 0x0043C200
14: 0x004399BD
15: 0x0047902C
16: 0x004946E9
17: 0x76D06359
18: 0x76EF7C24
19: 0x76EF7BF4

Which card behaved improperly?
Angrath, Minotaur Pirate

Which update are you using? (date, name)Which type? (duel, gauntlet, sealed deck)
version 8-2020 a62926f, duel

by **FastEddie** » 30 Sep 2020, 12:22

The bad parameters dump translates into this:

Code: Select all: bad parameters get_card_instance(1, 251662879) pthread_rwlock_init(...) functions/functions.c:16477:spell_puts_up_to_x_target_cards_from_graveyard_on_top_of_deck(...) functions/has_creature_type.c:531:get_subtypes(...) functions/has_creature_type.c:1370:init_subtype_text(...) functions/has_creature_type.c:1462:get_subtype_text(...) cards/eventide.c:2307:card_jawbone_skulkin(...) call_cards_function<eax>(card_data_t *cd<eax>, int player, int card, event_t event) fx_activation_906(int player, int card, event_t event) __DTOR_LIST__(...) add_fdes(...) search_object(...) resolve_top_card_on_stack() functions/produce_mana.c:282:choose_combination_of_colors_of_mana_to_produce_into_arr(...) main_phase(int player, int a4, int a5) switch_phase(int a3) start_duel() start_duel_thread(int a1) 0x76d06359 0x76ef7c24 0x76ef7bf4

by **Aswan jaguar** » 30 Sep 2020, 13:07

The savegame crashes when it loads so I can't check that set up. In my tests the game it doesn't crash.

by **drool66** » 30 Sep 2020, 22:56

The targeting on that ability definitely needed to be cleaned up, not to mention the obvious typo; I've done that an will commit (soon, I promise!)[edit: done in 9e85727]. Can't figure out how it got to that stack though. The save game gives me a wrong version notification on load from the MEGA folder; maybe double check your install? Could be something with patch folder or something.

by **Korath** » 01 Oct 2020, 01:00

FastEddie wrote:The bad parameters dump translates into this:

I assure you it does not. dmp.pl is only a thin wrapper around gdb; it needs to be run against the same executable and debug data that generated the stack.

by **Wally** » 01 Oct 2020, 05:14

drool66 wrote:The targeting on that ability definitely needed to be cleaned up, not to mention the obvious typo; I've done that an will commit (soon, I promise!). Can't figure out how it got to that stack though. The save game gives me a wrong version notification on load from the MEGA folder; maybe double check your install? Could be something with patch folder or something.

Curiouser and curiouser! I wouldn't be able to even test this card if I wasn't on the current version so I'm not sure whats going on there. I will reinstall though to be safe.