enPump keyword

[Chris H.]

I spent some time today working on this keyword and I discovered that the Flash keyword is incompatible with auras. I found this small bit of code with one of the Flash auras and it appears to take care of this situation:

Code: Select all

public boolean canPlay() {
    return AllZone.GameAction.isCardInZone(card, AllZone.Human_Hand)
        || AllZone.GameAction.isCardInZone(card, AllZone.Computer_Hand); // for flash, which is not working through the keyword for some reason
}

`
So, we need a variant of this in the enPump_Enchant SpellAbility located in CardFactoryUtil.java. I had to modify the code above to get it to work correctly with both Flash and non-Flash auras.

Code: Select all

public boolean canPlay() {
    return (sourceCard.getKeyword().contains("Flash") && (AllZone.GameAction.isCardInZone(sourceCard, AllZone.Human_Hand) ||
            AllZone.GameAction.isCardInZone(sourceCard, AllZone.Computer_Hand))    // for flash, which is not working through the keyword for some reason
                 ||
           (! sourceCard.getKeyword().contains("Flash") &&    // if not flash then limit to main 1 and 2 on controller's turn
           (sourceCard.getController().equals(AllZone.Phase.getActivePlayer()) &&
           (AllZone.Phase.getPhase().equals(Constant.Phase.Main1) || AllZone.Phase.getPhase().equals(Constant.Phase.Main2)))));
}

`
I admit that my code looks terrible but it appears to work OK. While working on this I also discovered that the setDescription test message that I created is now appearing in the Choose dialog when casting an aura with Cycling. As such, I guess that I will be able to add in the Cycling auras after all.

Unfortunately, the description still does not appear in the card detail panel but I can include that info in cards.txt.

Oh, and some of the auras are more of a curse than a buff-up. I remember Rob suggesting at one time that it may be best to have two different keywords to cover the differences in AI. I think the second aura should be named:

enCurse or enPumpCurse

Which version looks good to you Rob?



`

[Chris H.]

I uploaded another version. The format at this time is:

enPump:[p/t][/][k1 & k2 ... kn][:spellDescription][:stackDescription]

power/toughness and keywords are optional, although you must have at least one of these two.

multiple keywords are separated by the "&" character.

spellDescription and stackDescription are optional.

The card description must be included in the 4th line of the cards.txt entry. The code will build these descriptions and these descriptions will be replaced by any descriptions that are included with the keyword.

Keyword'ed auras at this time are compatible with Flash and Cycling.


EDIT:


Please see the latest update at:


Re: enPump keyword (latest update)

[Chris H.]

The CardFactory_Auras.java file has a number of occurrences of:

Code: Select all

if(list.isEmpty()) return false;

`
and I just remembered a recent message from our friend silly freak

Re: Forge 03/13 (Unofficial Beta version)

so I guess that I should change the line above to this

Code: Select all

if(list.length()==0) return false;

`
another SVN merge is on the way.

[silly freak]

actually no, Collection.isEmpty() is around for years, it's just String.isEmpty() which we should avoid.

[Chris H.]

actually no, Collection.isEmpty() is around for years, it's just String.isEmpty() which we should avoid.

`
Thank you for the input. I was not aware of the difference.

[Chris H.]

I am in the process of converting these auras to keyword:

Aspect of Mongoose
Diplomatic Immunity
Robe of Mirrors

The computer cast an Aspect of Mongoose and I disenchanted this enchantment. The Aspect of Mongoose went back to the computer's hand and it was cast again … but the returned Aspect of Mongoose remains in the computer's hand and is recast time after time ...

The Aspect of Mongoose includes the keyword "When this card is put into a graveyard from the battlefield, return this card to its owner's hand" but I am not sure if the problem is with this keyword or with my enPump keyword.

[Chris H.]

The computer cast an Aspect of Mongoose and I disenchanted this enchantment. The Aspect of Mongoose went back to the computer's hand and it was cast again … but the returned Aspect of Mongoose remains in the computer's hand and is recast time after time ...

`
After a number of tests it appears that the problem is related to my modified canPlay() method which in turn allows Flash to be used with my enPump keyword. I am not sure why this is happening.

[Chris H.]

After a number of tests it appears that the problem is related to my modified canPlay() method which in turn allows Flash to be used with my enPump keyword.

`
I think that I have fixed this in r595.

[Chris H.]

I updated the canPlayAI() method in the enPump SpellAbility. The computer will now target any Rabid Wombat or Uril, the Miststalker that it has in play. At some point in the future this will allow a Rabid Wombat AI type deck for quest mode.

Unfortunately the AI still needs a lot of work. The computer will target a flying creature with a Flight spell at this time. So we need to prune the list of computer creatures in play and remove those creatures that would not gain any new keyword'ed abilities.

I assume that if the aura has a p/t boost above zero that it does not matter if the aura keywords given are new or not.

I am kind of lost at this time. The variable number of keywords to test for is making this section of the code even more complicated.

Code: Select all

public boolean canPlayAI() {
    CardList list = new CardList(AllZone.Computer_Play.getCards());
    list = list.getType("Creature");
   
    if (list.isEmpty()) return false;
   
    //else (is there a Rabid Wombat or a Uril, the Miststalker to target?)
   
    CardList auraMagnetList = new CardList(AllZone.Computer_Play.getCards());
    auraMagnetList = auraMagnetList.filter(new CardListFilter() {
        public boolean addCard(Card c) {
            return c.isCreature() && (c.getName().equals("Rabid Wombat") || c.getName().equals("Uril, the Miststalker"));
        }
    });
    if (! auraMagnetList.isEmpty()) {    // AI has a special target creature(s) to enchant
        auraMagnetList.shuffle();
        for (int i = 0; i < auraMagnetList.size(); i++) {
            if (CardFactoryUtil.canTarget(sourceCard, auraMagnetList.get(i))) {
                setTargetCard(auraMagnetList.get(i));    // Target only Rabid Wombat or Uril, the Miststalker
                return true;
            }
        }
    }
   
    //else (prune list if needed?) and set target creature
   
    if (Power <= 0 && Tough <= 0) {    // This aura is keyword only
        // Need code to remove creatures from the list if
        // the aura does not provide new keyword abilities.
    }
   
    CardListUtil.sortAttack(list);
    CardListUtil.sortFlying(list);
   
    for (int i = 0; i < list.size(); i++) {
        if (CardFactoryUtil.canTarget(sourceCard, list.get(i))) {
            setTargetCard(list.get(i));
            return true;
        }
    }
    return false;
}//canPlayAI()

[DennisBergkamp]

How about something like this?

Code: Select all

if (Power <= 0 && Tough <= 0) {    // This aura is keyword only
                   list = list.filter(new CardListFilter(){
                        public boolean addCard(Card c){
                           ArrayList<String> extKeywords = new ArrayList<String>(Arrays.asList(extrinsicKeywords));
                           for (String s:extKeywords)
                           {
                              if (!c.getKeyword().contains(s))
                                 return true;
                           }
                           //no new keywords:
                           return false;
                        }
                   });
                }

It will return true when there is at least one new keyword.

[Chris H.]

Thank you Dennis. This looks like it should do the job.

[Chris H.]

I converted the aura "Vigilance" over to keyword and I have discovered a weird "cardname" bug with this card. This is what the card now looks like:

Code: Select all

Vigilance
W
Enchantment Aura
Enchanted creature has vigilance.
Enchant creature
enPump:Vigilance

`
and somehow the keyword is being changed from "Vigilance" to "cardname" which is then turned into the enchanted creatures name in the card detail panel.

[DennisBergkamp]

Ahh, this is because we replace all instances.... What happens when you change it to "enPump:CARDNAME" ?

[Chris H.]

I tried it and I get the same result. When I revert this card back to a non-keyword'ed card that is implemented by it's own coded card object it works correctly.

[DennisBergkamp]

For now let's just use the hardcoded version then I suppose