Images by Set

[Chris H.]

I ran a quick test with r3973 right before I started to upload the archive for the 11-30 beta. There were no pics in the pics folder and I placed a copy of the "none.pic" in the folder. It was not displayed in the deck editor or the battlefield when I tried a quick game.

This is a work in progress and we will have something to look forward to in a future beta.

[Rob Cashwalker]

Crap.. I didn't realize you'd do the beta today. The whole picture system may be broken.

[Hellfish]

Looks alright to me, I just played a few matches before I setup my pics. No log-spamming or slowdown as far as I can see. Certain cards are a bit iffy about showing up once I add my images, as I posted earlier, but nothing major.

[Chris H.]

Crap.. I didn't realize you'd do the beta today. The whole picture system may be broken.

`
That is OK. I do not mind releasing another beta in the near future if your and Sloth's projects come together in the near term.

The people participating in the deck building contest decided that today would be the last day for a new beta to be included in their contest. We did our best to meet their time schedule.

[Rob Cashwalker]

I just uploaded the last batch (I hope) of changes for the Set Images to work correctly.

My slowdowns were due to the HQ images. A couple hours with Paint Shop Pro doing batch resizing to 300 pixels tall, and I had no trouble playing a few rounds.

I found that the planeswalkers didn't use the copystats method in CardFactory, they pretty much built their card data in explicit code, with an SVar copy near the end of each walker's code block. So right there, I added a SetInfo copy, and then the walker's set info displayed correctly.

Someone needs to try Gravedigger-ing and other effects that may copy the card to make sure the set info copies over.

I do have a small bug with determining the most recent set... if no SetInfo is present in the card data, then the set defaults to Alpha.

[Huggybaby]

A couple hours with Paint Shop Pro doing batch resizing to 300 pixels tall, and I had no trouble playing a few rounds.

Just curious why it took so long? That job would ordinarily take a couple of minutes.

[Rob Cashwalker]

I couldn't select the folders all at once, I had to run the script in each folder. Also, I have a laptop which could theoretically be 1.6 GHz... but not usually. Part of why I was getting delays when the ImageCache was loading the files and doing the transformations.

[Sloth]

A creature with persist just came back from the graveyard without a picture. Does persist use some non-standard card zone moving code?

[friarsol]

Code: Select all

        if(persist) {
           PlayerZone ownerPlay = AllZone.getZone(Constant.Zone.Play, c.getOwner());
            PlayerZone grave = AllZone.getZone(c);
            grave.remove(c);
           
           Card crd = AllZone.CardFactory.getCard(c.getName(), c.getOwner());
           ownerPlay.add(crd);
           
           crd.addCounter(Counters.M1M1, 1);
        }


I'll fix persist to just use moveTo() instead of that garbage.

[Rob Cashwalker]

Yeah, this is the sort of thing that's going to drive us nuts. Any time a new card is generated by CardFactory, this sort of problem is going to crop up. I hesitate to put the image assignment into CardFactory.getCard, because then you may bounce an M11 Llanowar Elves, that shows up in your hand as XED.

[friarsol]

At least the visual cue will help us fix the old code that's unnecessarily creating new cards instead of using the appropriate copy function.

[Rob Cashwalker]

Well, it's not unnecessary to create the new cards. That's what ensures that when you bounce the card, it forgets about any effects from being in play.

The real solution, is that the Card object needs its own copy method, which copies low-level data and abilities plus p/t type stuff, but not the pump bonuses, color-changing and other higher-level information. Then instead of creating new cards from CardFactory, the current card is just copied before going to the new zone.

[timmermac]

As of r4098, when I put a downloaded picture into /res/pics, in the regular deck editor, clicking on the card still brings up a blank picture. Before, after putting a downloaded picture into that folder, I could click on the card and the picture would come up. I haven't had a chance to test this with quest mode yet, as the card I did this with is Fungus Sliver, which was just recently added to the SVN, and I haven't had a chance to do anything quest-related with r4098 yet.

Edit: I just downloaded a pic for All Hallow's Eve and put it into /res/pics. Upon clicking on the card in the Quest Mode deck editor, no picture comes up. This is not how it has been working for me in the past, even with the 11/30 beta.

Edit2: It has also happened with Hana Kami and Necrosavant.

[timmermac]

Does it now make a difference what naming conventions we use to name picture files and where we put them in the pics folder? I'm in the process of copying the MWS HQ pics with the .full.jpg extensions inside their individual set folders into the pics folder.

Edit: Now I see what Rob means about slowdowns with the HQ pics... Wow. It's almost unplayable with HQ .full.jpg pics in the Pics folder.

[Rob Cashwalker]

I just made an update that should ensure that a card without any SetInfo data in the card file will still be assigned a picture of some sort. As long as the normal picture URL works, and the card picture is downloaded....

Yeah, I don't know why the HQ pics are a problem, when they weren't before. Converting them to LQ (maintaining folders) did the trick for me. On a laptop without a large screen, HQ/LQ, it doesn't make a difference visually.