Making a prettier GUI
by mtgrares
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Making a prettier GUI
by choppic » 29 Dec 2010, 02:43
Let's admit it, Forge is a wonderful MTG game, with all the cards, planeswalkers, and of course the great cast of programmers working pro bono.
I love this game, and I honestly think that this game deserves a prettier GUI.
I don't know if any other members of this forum has tried this before. I played around with the source code, and this is the New Game dialog I currently have.
Feel free to share your comments, and (fingers crossed) maybe some line of codes to make the GUI better.
I love this game, and I honestly think that this game deserves a prettier GUI.
I don't know if any other members of this forum has tried this before. I played around with the source code, and this is the New Game dialog I currently have.
Feel free to share your comments, and (fingers crossed) maybe some line of codes to make the GUI better.
-
choppic - Posts: 48
- Joined: 17 Dec 2010, 07:56
- Location: East Java, Indonesia
- Has thanked: 0 time
- Been thanked: 0 time
Re: Making a prettier GUI
by DemoneNero » 29 Dec 2010, 13:13
Nicely done mate
Since I'm not a programmer it would be nice if anyone could change the background picture just renaming the image file
thanks

Since I'm not a programmer it would be nice if anyone could change the background picture just renaming the image file
thanks

Hold The Heathen Hammer High
-
DemoneNero - Posts: 91
- Joined: 26 Jul 2010, 19:41
- Location: Italy
- Has thanked: 4 times
- Been thanked: 1 time
Re: Making a prettier GUI
by Chris H. » 30 Dec 2010, 02:49
Will we be using the forest pic for the game? Or do you have some other sort of picture in mind?
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Making a prettier GUI
by choppic » 30 Dec 2010, 03:29
I want to use a painting specially made for Forge, the forest pic serves only as a placeholder for now.
I create an additional folder to store the images. So everyone can use whatever image they want.
I'm working on the Deck Editor right now. I find it very slow, so I remove the datagrid refreshing on every check/uncheck.
Instead, I create a filter button to execute the filtering process.
And I also add a filter by card name.
But in the end, of course it's you guys who decide if these changes should be included in the 'official' release
I create an additional folder to store the images. So everyone can use whatever image they want.
I'm working on the Deck Editor right now. I find it very slow, so I remove the datagrid refreshing on every check/uncheck.
Instead, I create a filter button to execute the filtering process.
And I also add a filter by card name.
But in the end, of course it's you guys who decide if these changes should be included in the 'official' release

-
choppic - Posts: 48
- Joined: 17 Dec 2010, 07:56
- Location: East Java, Indonesia
- Has thanked: 0 time
- Been thanked: 0 time
Re: Making a prettier GUI
by Rob Cashwalker » 30 Dec 2010, 05:11
I'm getting very frustrated with the Deck Editor - in trying to enable set selection for a card, due to the constant refreshing. There is a TableModel that stores the data in the table, but each time the refresh occurs, the model is cleared, wiping out the set selection. Clicking between cards seems to cause the clearing as well.
I'd almost want to write a new Deck Editor... but doing this stuff in Java sucks.. oh how, I love VB....
I'd almost want to write a new Deck Editor... but doing this stuff in Java sucks.. oh how, I love VB....
The Force will be with you, Always.
-
Rob Cashwalker - Programmer
- Posts: 2167
- Joined: 09 Sep 2008, 15:09
- Location: New York
- Has thanked: 5 times
- Been thanked: 40 times
Re: Making a prettier GUI
by choppic » 30 Dec 2010, 08:49
I managed to remove the refreshing, and added a 'Filter' button so users need to press that to execute the filtering. I attach the java file so you can try it on. Let me know what you guys think.
I'm adding the icons for each of the filtering component right now. I'll upload a screenshot after it's done.
I'm adding the icons for each of the filtering component right now. I'll upload a screenshot after it's done.
- Attachments
-
Gui_DeckEditor.zip
- Deck Editor without the constant refreshing
- (6.79 KiB) Downloaded 487 times
-
choppic - Posts: 48
- Joined: 17 Dec 2010, 07:56
- Location: East Java, Indonesia
- Has thanked: 0 time
- Been thanked: 0 time
Re: Making a prettier GUI
by slapshot5 » 30 Dec 2010, 10:35
I like it. A lot. Also interested to hear others' thoughts.
-slapshot5
-slapshot5
- slapshot5
- Programmer
- Posts: 1391
- Joined: 03 Jan 2010, 17:47
- Location: Mac OS X
- Has thanked: 25 times
- Been thanked: 68 times
Re: Making a prettier GUI
by Chris H. » 30 Dec 2010, 16:02
I built a project using the new deck editor code. Interesting work. I turned off a few of the filter check boxes and then tapped the Filter button. It seemed to work fairly quickly on my iMac.
I started forge and I had the monitor set to the smallest resolution supported by forge, 1024 x 768. The deck editor appeared to be about 100 + pixels wider than this resolution will show at one time.

I started forge and I had the monitor set to the smallest resolution supported by forge, 1024 x 768. The deck editor appeared to be about 100 + pixels wider than this resolution will show at one time.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Making a prettier GUI
by silly freak » 30 Dec 2010, 16:51
this could be optimized... right now, I think that filtering and sorting is sort of implemented manually by changing the table model. However, java has its own means of table filters and sorters, which are likely to perform better and work smoother. E.g. these won't wipe out the grid and thus the selection on every refresh.Rob Cashwalker wrote:I'm getting very frustrated with the Deck Editor - in trying to enable set selection for a card, due to the constant refreshing. There is a TableModel that stores the data in the table, but each time the refresh occurs, the model is cleared, wiping out the set selection. Clicking between cards seems to cause the clearing as well.
I'd almost want to write a new Deck Editor... but doing this stuff in Java sucks.. oh how, I love VB....
http://download.oracle.com/javase/tutor ... ml#sorting
___
where's the "trust me, that will work!" switch for the compiler?
Laterna Magica - blog, forum, project, 2010/09/06 release!
where's the "trust me, that will work!" switch for the compiler?
Laterna Magica - blog, forum, project, 2010/09/06 release!
- silly freak
- DEVELOPER
- Posts: 598
- Joined: 26 Mar 2009, 07:18
- Location: Vienna, Austria
- Has thanked: 93 times
- Been thanked: 25 times
Re: Making a prettier GUI
by SoulStorm » 31 Dec 2010, 00:49
This is awesome Choppic! Can you do the same thing for the Card Shop?choppic wrote:I managed to remove the refreshing, and added a 'Filter' button so users need to press that to execute the filtering. I attach the java file so you can try it on. Let me know what you guys think.
I'm adding the icons for each of the filtering component right now. I'll upload a screenshot after it's done.

Re: Making a prettier GUI
by choppic » 31 Dec 2010, 05:27
This is what I have after I played with Deck Editor.
I upload the files necessary to test the changes.
Unzip the file, and copy the content into src/forge.
Let me know what you guys think..
I upload the files necessary to test the changes.
Unzip the file, and copy the content into src/forge.
Let me know what you guys think..
- Attachments
-
choppic.zip
- GUI Changes
- (745.58 KiB) Downloaded 421 times
-
choppic - Posts: 48
- Joined: 17 Dec 2010, 07:56
- Location: East Java, Indonesia
- Has thanked: 0 time
- Been thanked: 0 time
Re: Making a prettier GUI
by choppic » 31 Dec 2010, 05:28
And this is the screenshot for the Deck Editor 

-
choppic - Posts: 48
- Joined: 17 Dec 2010, 07:56
- Location: East Java, Indonesia
- Has thanked: 0 time
- Been thanked: 0 time
Re: Making a prettier GUI
by choppic » 31 Dec 2010, 05:54
Thanks, dude. I'll try to do the same for the Card Shop.SoulStorm wrote:This is awesome Choppic! Can you do the same thing for the Card Shop?
But honestly, I'm more interested in playing around with the main game screen

-
choppic - Posts: 48
- Joined: 17 Dec 2010, 07:56
- Location: East Java, Indonesia
- Has thanked: 0 time
- Been thanked: 0 time
Re: Making a prettier GUI
by friarsol » 31 Dec 2010, 05:57
Well, aside from the images needing to be organized in the /res folder I like where this is headed. The Artifact and Enchantment icons may be too similar, especially being right next to each other. Maybe this would be solved by organizing the Types Alphabetically?
Artifact, Creature, Enchantment, Instant, Land, Planeswalker, Sorcery.
Does anyone know the reason why we have a separate DeckEditor for Quest Mode? It would be nice if all of these improvements went across the board without additional tampering.
Artifact, Creature, Enchantment, Instant, Land, Planeswalker, Sorcery.
Does anyone know the reason why we have a separate DeckEditor for Quest Mode? It would be nice if all of these improvements went across the board without additional tampering.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Making a prettier GUI
by Sloth » 31 Dec 2010, 10:28
This a great improvement. Thanks a lot choppic!
I just want to point out, that there are official icons for card types (introduced in Future Sight). I don't think we should copy them exactly, but maybe we can use similar ones. They can be found here http://wiki.mtgsalvation.com/article/Type.
I just want to point out, that there are official icons for card types (introduced in Future Sight). I don't think we should copy them exactly, but maybe we can use similar ones. They can be found here http://wiki.mtgsalvation.com/article/Type.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Who is online
Users browsing this forum: No registered users and 18 guests