SVN Bug Reports
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: SVN Bug Reports
by friarsol » 12 Jun 2011, 20:33
I just tested this and did not have this problem. Are you sure your card file is up to date?lazylockie wrote:r9622
Allies are still triggering twice when themselves enter the battlefield (since revision 9000 I think). So a lone Hada Freeblade starts at 2/3, instead of 1/2.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: SVN Bug Reports
by Sloth » 12 Jun 2011, 20:34
I was sure this wasn't possible anymore.

I put in some safety measures. Shouldn't happen anymore. Thanks Jaedayr.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: SVN Bug Reports
by lazylockie » 12 Jun 2011, 21:01
I just checked the codes and they are the same. It doesn't make sense that mine triggers twice and yours don't, because from the code I think it would indeed trigger twice:friarsol wrote:I just tested this and did not have this problem. Are you sure your card file is up to date?lazylockie wrote:r9622
Allies are still triggering twice when themselves enter the battlefield (since revision 9000 I think). So a lone Hada Freeblade starts at 2/3, instead of 1/2.
Isn't it supposed to be Ally.Other+YouCtrl?Name:Hada Freeblade
ManaCost:W
Types:Creature Human Soldier Ally
Text:no text
PT:0/1
T:Mode$ ChangesZone | Origin$ Any | Destination$ Battlefield | ValidCard$ Card.Self | OptionalDecider$ You | Execute$ TrigPutCounter | TriggerDescription$ Whenever CARDNAME or another Ally enters the battlefield under your control, you may put a +1/+1 counter on CARDNAME.
T:Mode$ ChangesZone | Origin$ Any | Destination$ Battlefield | ValidCard$ Ally.YouCtrl | TriggerZones$ Battlefield | OptionalDecider$ You | Execute$ TrigPutCounter | Secondary$ True | TriggerDescription$ Whenever CARDNAME or another Ally enters the battlefield under your control, you may put a +1/+1 counter on CARDNAME.
SVar:TrigPutCounter:DB$PutCounter | Defined$ Self | CounterType$ P1P1 | CounterNum$ 1
SVar:PlayMain1:TRUE
SVar:BuffedBy:Ally
SVar:RemRandomDeck:True
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/hada_freeblade.jpg
SetInfo:WWK|Uncommon|http://magiccards.info/scans/en/wwk/7.jpg
End
- lazylockie
- Posts: 508
- Joined: 13 Jul 2010, 22:44
- Has thanked: 74 times
- Been thanked: 15 times
Re: SVN Bug Reports
by friarsol » 12 Jun 2011, 21:11
How are your Allies coming into play? Are you casting them from your hand? Is more than one entering play at the same time? Does your issue go away if you add that line?lazylockie wrote:Isn't it supposed to be Ally.Other+YouCtrl?
If your cardfile is the same, maybe you changed something in the code to cause the double trigger?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: SVN Bug Reports
by lazylockie » 12 Jun 2011, 22:51
I've tested a bit more, the issue is with AI's allies.friarsol wrote:How are your Allies coming into play? Are you casting them from your hand? Is more than one entering play at the same time? Does your issue go away if you add that line?lazylockie wrote:Isn't it supposed to be Ally.Other+YouCtrl?
If your cardfile is the same, maybe you changed something in the code to cause the double trigger?
- Code: Select all
AICardsInHand=Hada Freeblade;Kazandu Blademaster;Mox Pearl;Mox Pearl;Mox Pearl
- lazylockie
- Posts: 508
- Joined: 13 Jul 2010, 22:44
- Has thanked: 74 times
- Been thanked: 15 times
Re: SVN Bug Reports
by Sloth » 13 Jun 2011, 08:50
I fixed this for all allies. But I find it rather alarming that we have triggers that work differently for the AI.lazylockie wrote:I've tested a bit more, the issue is with AI's allies.friarsol wrote:How are your Allies coming into play? Are you casting them from your hand? Is more than one entering play at the same time? Does your issue go away if you add that line?lazylockie wrote:Isn't it supposed to be Ally.Other+YouCtrl?
If your cardfile is the same, maybe you changed something in the code to cause the double trigger?Changing to Ally.Other+YouCtrl does solve the problem for AI.
- Code: Select all
AICardsInHand=Hada Freeblade;Kazandu Blademaster;Mox Pearl;Mox Pearl;Mox Pearl
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: SVN Bug Reports
by slapshot5 » 13 Jun 2011, 13:28
r9613
Is there a known issue with AI playing abilities with snow mana in the Cost?
I was testing Adarkar Windform which has an activation cost of "1 S", and the computer just would not play this ability. It wasn't even checking canPlayAI in my AF!
I changed the cost to "1 U" for testing and the computer played it right away. canPlayAI was now getting checked.
Are cards like this just supposed to have RemAIDeck set, or do we have a bug here?
Thanks,
slapshot5
Is there a known issue with AI playing abilities with snow mana in the Cost?
I was testing Adarkar Windform which has an activation cost of "1 S", and the computer just would not play this ability. It wasn't even checking canPlayAI in my AF!
I changed the cost to "1 U" for testing and the computer played it right away. canPlayAI was now getting checked.
Are cards like this just supposed to have RemAIDeck set, or do we have a bug here?
Thanks,
slapshot5
- slapshot5
- Programmer
- Posts: 1391
- Joined: 03 Jan 2010, 17:47
- Location: Mac OS X
- Has thanked: 25 times
- Been thanked: 68 times
Re: SVN Bug Reports
by Chris H. » 13 Jun 2011, 13:33
`slapshot5 wrote:r9613
Is there a known issue with AI playing abilities with snow mana in the Cost?
I was testing Adarkar Windform which has an activation cost of "1 S", and the computer just would not play this ability. It wasn't even checking canPlayAI in my AF!
I changed the cost to "1 U" for testing and the computer played it right away. canPlayAI was now getting checked.
Are cards like this just supposed to have RemAIDeck set, or do we have a bug here?
I do not think that the AI can handle "S" costs at this time.
Sloth created a snow AI deck last your for quest mode and upon testing we discovered this issue.
And yes, give the card a RemAIDeck SVar.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: SVN Bug Reports
by Agetian » 13 Jun 2011, 14:23
I noticed that Runeboggle does not work as expected (r9652): I was casting Viashino Fangtail for all my mana, the AI cast Runeboggle. I was given a dialog to pay 1, which I couldn't do, so I clicked Cancel, but Visahino Fangtail still came into play instead of going into my graveyard. A test scenario:
runeboggle_test.txt:
runeboggle_test.txt:
- Code: Select all
HumanCardsInPlay=Mountain; Mountain; Mountain; Forest
AICardsInPlay=Plains; Island; Swamp; Swamp
HumanCardsInHand=Viashino Fangtail
AICardsInHand=Runeboggle
ActivePlayer=Human
ActivePhase=Main1
- Agetian
- Programmer
- Posts: 3487
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: SVN Bug Reports
by UnderFlow » 13 Jun 2011, 15:32
R9657:
The first triggered ability of Vorinclex, Voice of Hunger uses the stack, even when it is triggered by a mana ability.
The first triggered ability of Vorinclex, Voice of Hunger uses the stack, even when it is triggered by a mana ability.
Gauntlet of Might has the same issue.605.1b. A triggered ability without a target that triggers from activating a mana ability and could put mana into a player's mana pool when it resolves is a mana ability.
Re: SVN Bug Reports
by Sloth » 13 Jun 2011, 19:42
Good point. We should fix this. Might be a lot of work though.UnderFlow wrote:R9657:
The first triggered ability of Vorinclex, Voice of Hunger uses the stack, even when it is triggered by a mana ability.Gauntlet of Might has the same issue.605.1b. A triggered ability without a target that triggers from activating a mana ability and could put mana into a player's mana pool when it resolves is a mana ability.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: SVN Bug Reports
by pwangsta » 13 Jun 2011, 21:17
r9670:
Chromatic Sphere - got mana, did not draw card
Eternal Flame - opponent only took 1/2 damage, not full
Arc Trail - allowed me to do 3 damage to a single creature or a single player
Creatures with islandwalk were unblockable in one game even when i didn't control an island (and wasn't playing blue at all)
Kazandu Blademaster - ETB ability (+1/+1 counter) triggers twice
Suffer the Past - requires 2UB to cast, where it should be xB
When AI played Amnesia, the following exception was thrown:
Chromatic Sphere - got mana, did not draw card
Eternal Flame - opponent only took 1/2 damage, not full
Arc Trail - allowed me to do 3 damage to a single creature or a single player
Creatures with islandwalk were unblockable in one game even when i didn't control an island (and wasn't playing blue at all)
Kazandu Blademaster - ETB ability (+1/+1 counter) triggers twice
Suffer the Past - requires 2UB to cast, where it should be xB
When AI played Amnesia, the following exception was thrown:
- | Open
- An error has occurred. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
mtgerror@yahoo.com
There is an error in the card code for Amnesia:
Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $
OS: Windows 7 Version: 6.1 Architecture: x86
Java Version: 1.6.0_21 Vendor: Sun Microsystems Inc.
Detailed error trace:
java.lang.NullPointerException
at forge.card.abilityFactory.AbilityFactory_ZoneAffecting.discardCanPlayAI(Unknown Source)
at forge.card.abilityFactory.AbilityFactory_ZoneAffecting.access$1(Unknown Source)
at forge.card.abilityFactory.AbilityFactory_ZoneAffecting$8.canPlayAI(Unknown Source)
at forge.ComputerAI_General.getPlayable(Unknown Source)
at forge.ComputerAI_General.getMain1(Unknown Source)
at forge.ComputerAI_General.playCards(Unknown Source)
at forge.ComputerAI_General.main1(Unknown Source)
at forge.ComputerAI_Input.think(Unknown Source)
at forge.ComputerAI_Input.showMessage(Unknown Source)
at forge.GuiInput.setInput(Unknown Source)
at forge.GuiInput.update(Unknown Source)
at java.util.Observable.notifyObservers(Unknown Source)
at java.util.Observable.notifyObservers(Unknown Source)
at forge.MyObservable.updateObservers(Unknown Source)
at forge.Phase.nextPhase(Unknown Source)
at forge.GuiDisplay4$27.actionPerformed(Unknown Source)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
- pwangsta
- Posts: 20
- Joined: 10 Jun 2011, 12:09
- Has thanked: 0 time
- Been thanked: 0 time
Re: SVN Bug Reports
by slapshot5 » 13 Jun 2011, 22:00
These two issues are now fixed in SVN.pwangsta wrote:r9670:
Suffer the Past - requires 2UB to cast, where it should be xB
When AI played Amnesia, the following exception was thrown:
-slapshot5
- slapshot5
- Programmer
- Posts: 1391
- Joined: 03 Jan 2010, 17:47
- Location: Mac OS X
- Has thanked: 25 times
- Been thanked: 68 times
Re: SVN Bug Reports
by Chris H. » 13 Jun 2011, 23:13
`pwangsta wrote:Eternal Flame - opponent only took 1/2 damage, not full
Fixed, thank you pwangsta.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: SVN Bug Reports
by Chris H. » 14 Jun 2011, 00:32
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Who is online
Users browsing this forum: No registered users and 42 guests