It is currently 12 Sep 2025, 16:20
   
Text Size

Drafting and Block/Set txt files

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Drafting and Block/Set txt files

Postby friarsol » 09 Jul 2011, 16:54

I was just updating blocks and setdata when I noticed that there is an inconsistency. I don't know anything about this part of the code, so I figured I'd ask. It looks like in blocks.txt M10 and M11 are correctly referred to by their names "Magic 20XX" but in setInfo they are incorrectly referred to by "Magic The Gathering 20XX".

I remember some people were reporting weird issues where the AI wasn't selecting any land, so I thought this might correlated.
So A) does this name mean anything and B) could this be why the AI isn't grabbing land properly?

Either way we should probably fix it to be conisistent. I just didn't want to change anything, since I didn't want to break something based on the names.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Drafting and Block/Set txt files

Postby Rob Cashwalker » 09 Jul 2011, 20:29

There shouldn't be any reason that type of inconsistency would be related to the land problem. Only the block names are used so far. But sure, go ahead and correct it.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Drafting and Block/Set txt files

Postby friarsol » 10 Jul 2011, 20:26

Hey Rob, any idea what this Issue might be about? http://code.google.com/p/cardforge/issues/detail?id=156
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Drafting and Block/Set txt files

Postby slowe » 11 Jul 2011, 03:42

friarsol wrote:Hey Rob, any idea what this Issue might be about? http://code.google.com/p/cardforge/issues/detail?id=156
M12 booster packs don't have a file yet. I tried this too, then created M12.pack in res/boosterdata with the same contents as the M11 one.
slowe
 
Posts: 127
Joined: 05 Jan 2010, 14:04
Has thanked: 6 times
Been thanked: 10 times

Re: Drafting and Block/Set txt files

Postby Chris H. » 11 Jul 2011, 17:27

slowe wrote:
friarsol wrote:Hey Rob, any idea what this Issue might be about? http://code.google.com/p/cardforge/issues/detail?id=156
M12 booster packs don't have a file yet. I tried this too, then created M12.pack in res/boosterdata with the same contents as the M11 one.
`
M10.pack and the M11.pack files are identical.

Commons:10
Uncommons:3
Rares:1
Mythics:1
`
I would assume that M12 will use the same numbers?
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Drafting and Block/Set txt files

Postby friarsol » 11 Jul 2011, 17:32

Yep all new sets are that. It might be worth it to have a "default" if the specific set doesn't exist to just use this.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Drafting and Block/Set txt files

Postby Chris H. » 11 Jul 2011, 18:06

slowe wrote:
friarsol wrote:Hey Rob, any idea what this Issue might be about? http://code.google.com/p/cardforge/issues/detail?id=156
M12 booster packs don't have a file yet. I tried this too, then created M12.pack in res/boosterdata with the same contents as the M11 one.
`
Thank you slowe, your fix is now on the SVN.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Drafting and Block/Set txt files

Postby Rob Cashwalker » 11 Jul 2011, 19:58

friarsol wrote:Yep all new sets are that. It might be worth it to have a "default" if the specific set doesn't exist to just use this.
It's the default for the default constructor... aka "Full". But yes, I see where it would be helpful to have a default if the pack file isn't found.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 42 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 42 users online :: 0 registered, 0 hidden and 42 guests (based on users active over the past 10 minutes)
Most users ever online was 7967 on 09 Sep 2025, 23:08

Users browsing this forum: No registered users and 42 guests

Login Form