10-18 version

by **DennisBergkamp** » 18 Oct 2008, 19:58

Awesome job JPB!!!
I added a boatload of new cards I never submitted here on the forums. I'll try adding them into your source as well, and I'll put that version up for download somewhere.

About the Necropotence bug, I've been running into the same problem with cards with activated abilities requiring a manacost of 0. It always asks me to pay a manacost of "blank". If I have no lands / moxes / llanowar elves untapped, I can't use the ability.

by **GandoTheBard** » 18 Oct 2008, 20:07

An interesting thing about MTG Forge ...if you delete the common/uncommon/rare .txt files it completely breaks the client. However the rarity is not of consequence to the deck editor at all. And even though there is a rarity field it is always empty. I still think we should consider adding rarity to cards.txt which will uncomplicate it abit, and a separate text file (limited.txt) should be available for drafts/sealed so that the client knows what cards to include, I think this would greatly simplify the daunting task of selecting which cards to draft with. Obviously drafting with ALL the cards is an aweful idea because the computer can't tell good from bad.

==edit== I wrote this because I was just trying (unsuccessfully) to edit the rarities text files to work with the new compiled version and it is just so frustrating not knowing what exactly breaks the client and what doesn't.

by **GandoTheBard** » 18 Oct 2008, 20:45

Btw Chartooth Cougar needs the Cycling keyword ...not sure if we can just add it via Cards.txt.

by **DennisBergkamp** » 18 Oct 2008, 20:49

Ugh, not sure what's wrong, but I did notice I draw an extra card after mulligan (never seen that before in previous versions) and whenever I play a card with upkeep effects (Bitterblossom, Juzam Djinn, Reya Dawnbringer, etc. ) I always end up drawing extra cards (which was also the case in 8-27's version, but should have been fixed in the previous Beta from September). #-o

by **Rob Cashwalker** » 19 Oct 2008, 02:55

Yes, Cycling should just work as a keyword now.

Here's the list of missing Rarity definitions:

Code: Select all: Storm Herd Festival of Trokin Savannah Tundra Badlands Tropical Island Taiga Volcanic Island Scrubland Plateau Underground Sea Archon of Justice Alaborn Grenadier Alert Shu Infantry Castle Convalescence Black Vise Naturalize Disenchant Demystify AEtherflame Wall Loch Korrigan Dungeon Shade Shade of Trokair Parapet Watchers Stone Kavu Viscerid Deepwalker Vengeful Firebrand Pardic Dragon Chartooth Cougar Blistering Dieflyn Soul Feast Morsel Theft Joiner Adept Battering Sliver Blade Sliver Gemhide Sliver Heart Sliver Horned Sliver Sinew Sliver Winged Sliver Watcher Sliver Might Sliver Bonesplitter Sliver Sliver Queen Muscle Sliver Willow Faerie Hillcomber Giant Righteous Avengers Alaborn Musketeer Dandan Gerrard's Irregulars Klaas, Elf Friend Treetop Village Forbidding Watchtower Faerie Conclave Kamahl, Pit Fighter Empty the Warrens Serra Avatar Battle of Wits Shriekmaw Ajani Goldmane Liliana Vess Darksteel Colossus Magus of the Library Tarox Bladewing Bonded Fetch Blind Phantasm Goldmeadow Lookout Blade of the Sixth Pride Sliver Legion Delirium Skeins Haunted Angel Spotted Griffin Sky Swallower Ornithopter Dancing Scimitar Forest Mountain Plains Island Swamp Test Destroy Zur the Enchanter Aven Riftwatcher Boomerang Culling Sun Hundroog Keeneye Aven Pendrell Drake Primoc Escapee Sandbar Merfolk Sandbar Serpent Barren Moor Blasted Landscape Drifting Meadow Forgotten Cave Lonely Sandbar Polluted Mire Remote Isle Secluded Steppe Slippery Karst Smoldering Crater Tranquil Thicket Defense of the Heart Charcoal Diamond Moss Diamond Sky Diamond Fire Diamond Marble Diamond Eladamri's Call Exclude Gerrard's Verdict Global Ruin Megrim Guiltfeeder Hypnotic Specter Thieving Magpie Shadowmage Infiltrator Mystic Snake Necropotence Yawgmoth's Bargain Carrion Wall Charging Troll Clay Statue Darkling Stalker Diabolic Machine Drowned Drudge Reavers Eron the Relentless Fog of Gnats Gorilla Chieftain Horned Troll Jungle Troll Living Airship Living Wall Metathran Zombie Mire Boa Pewter Golem Phyrexian Monitor Restless Dead River Boa Screeching Harpy Skyshroud Troll Tattered Drake Tel-Jilad Exile Unworthy Dead Uthden Troll Votary of the Conclave Walking Dead Wall of Bone Wall of Brambles Wall of Pine Needles Yavimaya Gnats Sensei's Divining Top Shatter Vindicate

Now if I could just get my VB program to do some lookups....

by **Rob Cashwalker** » 19 Oct 2008, 04:24

What'ya know, I was able to programmatically pull rarity from Gatherer.....

Here's the results:

Commons

Code: Select all: Festival of Trokin Alaborn Grenadier Naturalize Disenchant Demystify AEtherflame Wall Loch Korrigan Dungeon Shade Shade of Trokair Parapet Watchers Stone Kavu Viscerid Deepwalker Chartooth Cougar Blistering Dieflyn Morsel Theft Battering Sliver Gemhide Sliver Sinew Sliver Winged Sliver Watcher Sliver Bonesplitter Sliver Muscle Sliver Willow Faerie Hillcomber Giant Righteous Avengers Alaborn Musketeer Dandan Gerrard's Irregulars Empty the Warrens Blind Phantasm Blade of the Sixth Pride Delirium Skeins Spotted Griffin Aven Riftwatcher Boomerang Hundroog Keeneye Aven Pendrell Drake Sandbar Merfolk Barren Moor Drifting Meadow Forgotten Cave Lonely Sandbar Polluted Mire Remote Isle Secluded Steppe Slippery Karst Smoldering Crater Tranquil Thicket Exclude Clay Statue Darkling Stalker Drowned Drudge Reavers Fog of Gnats Gorilla Chieftain Horned Troll Living Airship Metathran Zombie Mire Boa Pewter Golem Phyrexian Monitor Restless Dead Skyshroud Troll Tattered Drake Tel-Jilad Exile Unworthy Dead Votary of the Conclave Walking Dead

Uncommons
Rares

by **GandoTheBard** » 19 Oct 2008, 04:52

Well Done Rob. Sadly for me I ended up doing that task by hand. Took a few hours as I am a slow typist.

by **jpb** » 19 Oct 2008, 05:17

Whenever Necropotence asks that I pay a mana cost I just click on the Necropotence again and it lets me continue. I will again look into avoiding this prompt for mana, but at first glance I did not find a way.

by **GandoTheBard** » 19 Oct 2008, 06:04

the Black Vice code is uber broken. I played a game where the ai laid down a vice and the next turn I had to draw 8 cards! not counting the 7 in my hand already. It does this every round. not that I mind getting my WHOLE deck in my hand but this really needs fixing asap.

by **jpb** » 19 Oct 2008, 08:46

Fix for Black Vise problem. It is actually not a Black Vise problem, but instead a problem with how MTG Forge does phases. This is a big hack. The entire phase system is broke and really needs to be reworked for V2 without recursion from the start.

Replace the DrawCard method in GameAction.java with the following

Code: Select all: private boolean shouldDraw = true; private String lastPlayerToDraw = Constant.Player.Human; public void drawCard(String player) { //TODO: show that milled player looses boolean isDrawPhase = AllZone.Phase.getPhase().equals(Constant.Phase.Draw); if(isDrawPhase){ String currentPlayer = AllZone.Phase.getActivePlayer(); if(!currentPlayer.equals(lastPlayerToDraw)){ shouldDraw = true; } lastPlayerToDraw = currentPlayer; if(!shouldDraw){ return; } //so they can't draw twice in a row during the draw phase shouldDraw = false; } PlayerZone library = AllZone.getZone(Constant.Zone.Library, player); PlayerZone hand = AllZone.getZone(Constant.Zone.Hand, player); if(library.size() != 0) { Card c = library.get(0); library.remove(0); hand.add(c); } }

Whenever a card causes a player to draw a card during the draw phase, like Howling Mine, this code will need to change to take that into account. For now Howling Mine doesn't make you draw at the beginning of your draw phase, but instead at the end of your upkeep. If this ever is corrected, then the above code will need to change to take that into account.

I tested the above fix quickly in two scenarios. One where the computer controlled a Black Vise and another where the human controlled a Black Vise. Both seemed to have the the extra drawing problem resolved. Someone needs to speak to Forge and get him to add some people to the googlecode project so that we can use their subversion server and update the MTG Forge code instantly, instead of waiting for someone to compile it. I would be willing to come up with a quick build file so people can build the project themselves. Only question is what to use to build the source. Will enough people have ant or be willing to get it? Could we include ant or another build tool? Or will shell/batch scripts be the best? Browsing googlecode's site I don't see anyway for googlecode to automatically build the project for us, which is a shame.

by **GandoTheBard** » 19 Oct 2008, 16:40

Nice work jpb

It is my distinct impression that the last thing MTG Rares wants to do is aid and abet in the fixing of version 1. I could be wrong but that is the passive undertone I have noticed. I really appreciate what you guys have done to make it happen regardless of this but be advised, waiting for Rares will likely be fruitless.

by **GandoTheBard** » 19 Oct 2008, 16:50

You guys should know...the Cycling keyword does NOT work as implemented. Nor does "comes into play tap", which means the new lands are useless.

by **GandoTheBard** » 19 Oct 2008, 18:09

By the way whomever coded Zur the Enchanter...his triggered ability says "You may" not "Do this no matter what and at random."

by **DennisBergkamp** » 19 Oct 2008, 20:14

Hmm, I coded Zur the Enchanter. It should pop up a list of enchantments below a manacost of 3 from your library. If you press cancel it shouldn't put anything into play.

EDIT: weird, I just tested it again and it works exactly as it should. I don't know Gando, I can't reproduce your bug.

by **Incantus** » 19 Oct 2008, 20:38

DennisBergkamp wrote:Hmm, I coded Zur the Enchanter. It should pop up a list of enchantments below a manacost of 3 from your library. If you press cancel it shouldn't put anything into play.

By the way, this is incorrect. Part of the benefit of searching your library for a specific card is being able to look through your entire library at that point in time (even though it will be shuffled after you are done searching).

10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Re: 10-18 version

Who is online

Main Menu

User Menu

Our Partners

Who is online

Who is online

Main Menu

User Menu

Our Partners

Who is online

Login Form