It is currently 25 May 2025, 23:03
   
Text Size

Incorrect Scripts

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Incorrect Scripts

Postby friarsol » 12 Nov 2011, 23:19

Sometimes I put these on the Wiki, but I don't know how much those get seen, so I'm going to start a thread for cards that I notice whose scripts are wrong and fixable. Feel free to add your own, or fix the scripts as appropriate.

Lightning Surge - This shouldn't be two spells, it should be a spell with a non-Threshold conditional, and subability with a Threshold conditional.

Knowledge Vault - Sacrificing the Vault is not a cost, it happens as part of resolution of the ability.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Incorrect Scripts

Postby jeffwadsworth » 13 Nov 2011, 03:33

friarsol wrote:Sometimes I put these on the Wiki, but I don't know how much those get seen, so I'm going to start a thread for cards that I notice whose scripts are wrong and fixable. Feel free to add your own, or fix the scripts as appropriate.

Lightning Surge - This shouldn't be two spells, it should be a spell with a non-Threshold conditional, and subability with a Threshold conditional.

Knowledge Vault - Sacrificing the Vault is not a cost, it happens as part of resolution of the ability.
:) I would love to see the script (with current code) of Knowledge Vault.
jeffwadsworth
Super Tester Elite
 
Posts: 1172
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 287 times
Been thanked: 70 times

Re: Incorrect Scripts

Postby jeffwadsworth » 20 Nov 2011, 15:03

Goblin Charbelcher is similar to Knowledge Vault in that both need to "Remember" two different objects.
jeffwadsworth
Super Tester Elite
 
Posts: 1172
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 287 times
Been thanked: 70 times

Re: Incorrect Scripts

Postby slapshot5 » 25 Nov 2011, 22:06

I think Rending Vines is incorrect. It should use conditions instead of targeting restrictions.
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Incorrect Scripts

Postby Sloth » 09 Jan 2012, 15:57

The script of Sudden Spoiling does not work. "RemoveAllAbilities" is not fully supported in AnimateAll (it only removes keywords, no activated, triggered or other static abilities).
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Incorrect Scripts

Postby ArsenalNut » 13 Jan 2012, 13:51

The second ability for Brutal Deceiver, Callous Deceiver, and Feral Deceiver pumps no matter what cards is revealed. The scripts should be using conditionals.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Incorrect Scripts

Postby Sloth » 22 Jan 2012, 07:08

The recently added script for Angelic Arbiter is not correct. There should be no triggers in the script. The static abilities should work even when Angelic Arbiter enters the battlefield after the attack (or after a spell was cast).
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Incorrect Scripts

Postby jeffwadsworth » 22 Jan 2012, 08:16

Sloth wrote:The recently added script for Angelic Arbiter is not correct. There should be no triggers in the script. The static abilities should work even when Angelic Arbiter enters the battlefield after the attack (or after a spell was cast).
I will remove it soon. Late here.

I suppose it would have to use something like:

Opponent.attackedThisTurn
Opponent.castSpellThisTurn

with a Continuous static with Checks.
jeffwadsworth
Super Tester Elite
 
Posts: 1172
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 287 times
Been thanked: 70 times

Re: Incorrect Scripts

Postby Sloth » 22 Jan 2012, 08:27

jeffwadsworth wrote:I will remove it soon. Late here.

I suppose it would have to use something like:

Opponent.attackedThisTurn
Opponent.castSpellThisTurn

with a Continuous static with Checks.
Yes. I think the second condition is already possible: "SVar:X:Count$ThisTurnCast_Card.YouDontCtrl".

I will try to make the first one scriptable.

EDIT: Done!
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Incorrect Scripts

Postby jeffwadsworth » 07 Feb 2012, 03:40

.Rathi Dragon. What if you do not wish to sacrifice the mountains?
.Puresteel Paladin. The original attach ability is still on the card.
jeffwadsworth
Super Tester Elite
 
Posts: 1172
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 287 times
Been thanked: 70 times

Re: Incorrect Scripts

Postby friarsol » 07 Feb 2012, 04:07

jeffwadsworth wrote:.Rathi Dragon. What if you do not wish to sacrifice the mountains?
.Puresteel Paladin. The original attach ability is still on the card.
I don't think Puresteel Paladin should remove the original attach ability, the card is literally granting Equip 0. It doesn't say "You may spend 0 instead of paying for any Equip costs"
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Incorrect Scripts

Postby friarsol » 07 Feb 2012, 04:07

It looks like Catastrophe is wrong, you have to make the decision on casting, not on resolution.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Incorrect Scripts

Postby jeffwadsworth » 07 Feb 2012, 04:14

Well, if you are forced to sacrifice the mountains, then there are tons of cards like Rathi Dragon that can be added. I always thought you had a choice.
jeffwadsworth
Super Tester Elite
 
Posts: 1172
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 287 times
Been thanked: 70 times

Re: Incorrect Scripts

Postby timmermac » 07 Feb 2012, 04:29

No, there's no choice there. If you don't sacrifice the mountains, Rathi Dragon is immediately sacrificed.
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
User avatar
timmermac
Tester
 
Posts: 1512
Joined: 17 May 2010, 20:36
Has thanked: 18 times
Been thanked: 95 times

Re: Incorrect Scripts

Postby friarsol » 07 Feb 2012, 04:34

timmermac wrote:No, there's no choice there. If you don't sacrifice the mountains, Rathi Dragon is immediately sacrificed.
What? The choice is whether or not you want to sacrifice the Mountains.

117.12a Some spells, activated abilities, and triggered abilities read, "[Do something] unless you [do something else]." This means the same thing as "You may [do something else]. If you don't, [do something]."
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Next

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 56 guests


Who is online

In total there are 56 users online :: 0 registered, 0 hidden and 56 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 56 guests

Login Form