upgrade mana producing for kev's Custom DLC MOD

[nabeshin]

This files upgrade mana producing for kev's Custom DLC MOD and implement all my function.
extract to DATA_DLC_7777, and remake wad-file
New func - ProduceMana(color,value)
color type - "C","B","G","R","U","W"
value - mana value added to manapool.

[nabeshin]

improved and corrected cards:

(all mana source cards), and
PROGENITUS
PATH TO EXILE
BLOODLORD OF VAASGOTH
BOSH IRON GOLEM
MARTYR OF SANDS
TEFERIS PUZZLE_BOX
ISOCHRON SCEPTER
MANA LEAK
WHIRLPOOL DRAKE(renamed)
DJINN OF WISHES(renamed)
PHANTASMAL IMAGE(stable)

[nabeshin]

At last I managed to switch off auto mana choice!

Code: Select all

var_auto_mana_choice
var_auto_mana_prompt


Now during the moment when it is required to choose from the different lands - game crush with an error message

[Persee]

Well done nabeshin !

Keep working, I'm sure you will find the solution.

[nabeshin]

Well done nabeshin !

Keep working, I'm sure you will find the solution.

I not be such serious...
It is necessary to have an initial code what to complete another's work.
TO COMPLETE.
It is not made entirely.

[nabeshin]

Solved stability of work of a Phantasmal Image, on evening update come...

[Persee]

I tested the ProduceMana function and I noticed that the AI taps lands for do nothing.

[thefiremind]

I tested the ProduceMana funtion and I noticed that the AI taps lands for do nothing.

Even if it's really clever, I have never been a fan of this way of producing mana, in fact I avoided coding cards that needed to be done like this. I know it's a huge limitation, but I'm happy anyway.

I discovered something useful that can mimic any card that produces 2 mana (Ravnica bounce lands or Sol Ring for example) without using this trick. It has a problem (read on and see), but I share it in case someone needs it.

Let's take Sol Ring for example. If you code its mana ability with:

Code: Select all

<PRODUCES amount="{2}" />

you make something really broken. Whenever you need only 1 mana and your lands are already tapped, the game will provide the mana with Sol Ring without tapping it! So you could have infinite mana as long as you can pay at a time.
A better way to do it is to give Sol Ring 2 mana abilities, each one producing 1 mana. I discovered that the mana abilities are used all together when tapping the permanent, and this way, if you need only 1 mana, Sol Ring becomes tapped. The only downside is that mana pool doesn't exist in the game, so if you use Sol Ring for only 1 mana, the other point is lost. Anyway it's better than allowing infinite mana.

[nabeshin]

I tested the ProduceMana function and I noticed that the AI taps lands for do nothing.

Sense of my changes in mana-system
1 simplification of a kind of called function
2 support of minimum quantity mana-tokens in game (without a cycle destruction - creation - put in play)
On it actions of the AI are connected with errors of scripts not considering our changes

[Eglin]

Even if it's really clever, I have never been a fan of this way of producing mana, in fact I avoided coding cards that needed to be done like this. I know it's a huge limitation, but I'm happy anyway.

Would you please explain why you're opposed to this method? Aside from the requirement that six new token cards must be distributed, I can't really discern any downside.

[thefiremind]

Would you please explain why you're opposed to this method? Aside from the requirement that six new token cards must be distributed, I can't really discern any downside.

I'm not opposed, I just don't like to use it. The game won't recognize the token production as a mana ability, in case some effects care about it (think about split second). And I wouldn't like to have some cards that act as there was a mana pool, and other cards that don't. I feel happy with the game as it is, and I only add cards that don't mess with its basics. I'm not saying that using this method is wrong, everyone is free to add the mods that he likes.