It is currently 08 Jun 2025, 18:38
   
Text Size

Dark Ascension spoiler season

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Dark Ascension spoiler season

Postby Sloth » 27 Jan 2012, 11:46

slapshot5 wrote:Dark Ascension is up on Gatherer.
It's also up on magiccards.info.

I think we should release the next snapshot release with DKA cards. A little more testing before the beta can't hurt.

Some updates:
I've added the keyword "CARDNAME must be blocked if able.", so Deadly Allure and Hinterland Hermit // Hinterland Scourge can be added.

The new "AttachedTo" parameter in AF ChangeZone makes Curse of Misfortunes scriptable...NOT (EDIT: Checking again i found that it still won't work.)

I have some future plans that involve making Fiend of the Shadows scriptable.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Dark Ascension spoiler season

Postby moomarc » 27 Jan 2012, 12:00

Just thought I'd post a quick reminder of what ArsenalNut pointed out about my implementation of Undying. Currently the undying creature will return with a +1/+1 counter even if it already had one when it died to gaining enough -1/-1 counters in one shot (eg. returned Strangleroot Geist targeted by Skinrender ETB effect). I may have added the ability but have no idea how to fix this bug. I guess the section of code that makes the two counter types cancel each other out has to have an exception for:
Code: Select all
if cardCounters("P1P1")GE1
  and if ("M1M1")GE("P1P1" + cardToughness)
I just have no idea how to actually code it.

EDIT: Fixed condition logic.
Last edited by moomarc on 27 Jan 2012, 12:56, edited 1 time in total.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Dark Ascension spoiler season

Postby Chris H. » 27 Jan 2012, 12:37

Sloth wrote:
slapshot5 wrote:Dark Ascension is up on Gatherer.
It's also up on magiccards.info.

I think we should release the next snapshot release with DKA cards. A little more testing before the beta can't hurt.
`
Oops, I found this message while running the script for the snapshot build. :)

I think that we may want to wait until we have an updated mtg-data.txt file and updated python scripts so we can merge the DKA cards and run setinfo and oracle (at the same time) with a snapshot build afterwards.

I agree that a few days of testing the new DKA scripts as we find the areas in the code base that needs set info updating would be a good idea.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Dark Ascension spoiler season

Postby Sloth » 27 Jan 2012, 12:51

moomarc wrote:Just thought I'd post a quick reminder of what ArsenalNut pointed out about my implementation of Undying. Currently the undying creature will return with a +1/+1 counter even if it already had one when it died to gaining enough -1/-1 counters in one shot (eg. returned Strangleroot Geist targeted by Skinrender ETB effect). I may have added the ability but have no idea how to fix this bug. I guess the section of code that makes the two counter types cancel each other out has to have an exception for:
Code: Select all
if cardCounters("M1M1")GE0
  and if ("M1M1")GE("P1P1" + cardToughness)
I just have no idea how to actually code it.
I think the whole +1/+1 vs -1/-1 counters elimination should be moved to checkStateEffects.

Chris H. wrote:Oops, I found this message while running the script for the snapshot build. :)

I think that we may want to wait until we have an updated mtg-data.txt file and updated python scripts so we can merge the DKA cards and run setinfo and oracle (at the same time) with a snapshot build afterwards.
I think the snapshot build users can test the DKA cards without pictures (or with non set LQ pictures).
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Dark Ascension spoiler season

Postby Chris H. » 27 Jan 2012, 13:25

Sloth wrote:
Chris H. wrote:Oops, I found this message while running the script for the snapshot build. :)

I think that we may want to wait until we have an updated mtg-data.txt file and updated python scripts so we can merge the DKA cards and run setinfo and oracle (at the same time) with a snapshot build afterwards.
I think the snapshot build users can test the DKA cards without pictures (or with non set LQ pictures).
`
The pictures can take a few weeks to become available and I do not think that any of us want to delay the merge and release until they become available.

I guess that the question then becomes should we merge the DKA card branch into the trunk and then release a snapshot before we have access to an updated mtg-data.txt file and updated python scripts.

I can go either way.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Dark Ascension spoiler season

Postby friarsol » 27 Jan 2012, 13:33

I'm not sure if having the Oracle text is as important as having the SetInfo. It would just limit how users could search up cards, correct? SetInfo and a whole bunch of DKA cards in the next Snapshot would be more than enough until Arch updates his mtg-data file.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Dark Ascension spoiler season

Postby ArsenalNut » 27 Jan 2012, 13:53

I just updated the SetInfoScipt script and it ran fine. I can do the merge now if we're agreed.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Dark Ascension spoiler season

Postby Sloth » 27 Jan 2012, 14:11

ArsenalNut wrote:I just updated the SetInfoScipt script and it ran fine. I can do the merge now if we're agreed.
I vote for merging.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Dark Ascension spoiler season

Postby slapshot5 » 27 Jan 2012, 14:13

Sloth wrote:
ArsenalNut wrote:I just updated the SetInfoScipt script and it ran fine. I can do the merge now if we're agreed.
I vote for merging.
same.
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Dark Ascension spoiler season

Postby friarsol » 27 Jan 2012, 14:30

Do it. We also need to update all of the Set specific data files. Even though DKA isn't technically part of Standard until next week, I think it should be fine to add it there a bit early.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Dark Ascension spoiler season

Postby moomarc » 27 Jan 2012, 14:54

I'm guessing I should commit Deadly Allure to the main branch then?
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Dark Ascension spoiler season

Postby jmartus » 27 Jan 2012, 15:06

sloth wrote "I think the snapshot build users can test the DKA cards without pictures (or with non set LQ pictures)." I downloaded the latest snapshot of the latest build forge-1.2.3-20120127.123856-7 but find and dka cards
jmartus
 
Posts: 207
Joined: 11 Oct 2010, 09:25
Has thanked: 0 time
Been thanked: 7 times

Re: Dark Ascension spoiler season

Postby ArsenalNut » 27 Jan 2012, 15:16

friarsol wrote:Do it. We also need to update all of the Set specific data files. Even though DKA isn't technically part of Standard until next week, I think it should be fine to add it there a bit early.
Merge is complete. I ran SetInfo before the merge. The DFCs only have one SetInfo so it looks like the they need to be hand corrected.

The following cards that were not part of DKA also changed from the merged branch
non-DKA cards that changed | Open
res/cardsfolder/a/akki_lavarunner_tok_tok_volcano_born.txt
res/cardsfolder/d/divine_presence.txt
res/cardsfolder/f/furnace_of_rath.txt
res/cardsfolder/g/gratuitous_violence.txt
res/cardsfolder/l/laquatuss_disdain.txt
res/cardsfolder/l/lashknife_barrier.txt
res/cardsfolder/p/phage_the_untouchable.txt
res/cardsfolder/u/undead_alchemist.txt

I checked them in separately.

moomarc wrote:I'm guessing I should commit Deadly Allure to the main branch then?
Correct
The Dark Ascension branch has been reintegrated into the trunk. This branch should not be used anymore otherwise the merge info can get messed up.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Dark Ascension spoiler season

Postby friarsol » 27 Jan 2012, 15:17

jmartus wrote:sloth wrote "I think the snapshot build users can test the DKA cards without pictures (or with non set LQ pictures)." I downloaded the latest snapshot of the latest build forge-1.2.3-20120127.123856-7 but find and dka cards
Please be patient, they hadn't been added yet.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Dark Ascension spoiler season

Postby Chris H. » 27 Jan 2012, 15:38

friarsol wrote:
jmartus wrote:sloth wrote "I think the snapshot build users can test the DKA cards without pictures (or with non set LQ pictures)." I downloaded the latest snapshot of the latest build forge-1.2.3-20120127.123856-7 but find and dka cards
Please be patient, they hadn't been added yet.
`
I am now updating my local copy and need to add some text to the changes.txt file and will then release another snapshot build. It should not take more than another hour or so. :wink:
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: Google [Bot] and 37 guests


Who is online

In total there are 38 users online :: 1 registered, 0 hidden and 37 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: Google [Bot] and 37 guests

Login Form