Incorrect Scripts
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Incorrect Scripts
by squee1968 » 17 Apr 2012, 23:51
While scripting Bend or Break, I looked at Death or Glory, and noticed a couple of things. Firstly, the ChosenPile$ DBReturn and the other should be reversed, since DoG states "Exile the pile of an opponent's choice..." and also, shouldn't the Origin$ Library be Origin$ Graveyard on both the ChangeZone SVars?
Re: Incorrect Scripts
by squee1968 » 20 Apr 2012, 15:30
Vodalian Illusionist has flanking. It should not.
Re: Incorrect Scripts
by friarsol » 20 Apr 2012, 15:41
Very true.squee1968 wrote:Vodalian Illusionist has flanking. It should not.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Incorrect Scripts
by mark » 25 Apr 2012, 09:19
Sludge Strider has an error: It only triggers if an artifact is put into the graveyard but should also trigger if the artifact is exiled or put to the hand.
I guess it should be "Origin$ Battlefield | Destination$ Any" instead of "Origin$ Battlefield | Destination$ Graveyard"
I guess it should be "Origin$ Battlefield | Destination$ Any" instead of "Origin$ Battlefield | Destination$ Graveyard"
Re: Incorrect Scripts
by mark » 17 May 2012, 12:01
If no other creature except Fettergeist is on the battlefield, the player is prompted to pay 0 mana in his upkeep, but the OK-button cannot be clicked, only the cancel button is clickable, which sacrifices Fettergeist.
(also: please apply the fix to Sludge Strider from my posting above)
(also: please apply the fix to Sludge Strider from my posting above)
Re: Incorrect Scripts
by moomarc » 17 May 2012, 12:47
The Fettergeist issue probably belongs more in the bugs thread, but I did apply the fix for Sludge Strider. Thanks.mark wrote:If no other creature except Fettergeist is on the battlefield, the player is prompted to pay 0 mana in his upkeep, but the OK-button cannot be clicked, only the cancel button is clickable, which sacrifices Fettergeist.
(also: please apply the fix to Sludge Strider from my posting above)
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Incorrect Scripts
by moomarc » 17 May 2012, 15:47
@Sloth: In the Play ability for Howltooth Hollow you just added, what's up with the ForgetRemembered param? There's nothing in the code for it and I'm not sure if it makes sense as a ForgetOtherRemembered where it's placed in the script at the moment. Am I missing something?
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Incorrect Scripts
by friarsol » 17 May 2012, 19:08
Maybe he meant to have a Cleanup => ClearRemembered SubAbility?moomarc wrote:@Sloth: In the Play ability for Howltooth Hollow you just added, what's up with the ForgetRemembered param? There's nothing in the code for it and I'm not sure if it makes sense as a ForgetOtherRemembered where it's placed in the script at the moment. Am I missing something?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Incorrect Scripts
by Sloth » 18 May 2012, 11:42
Thanks for reminding me. Because cards don't become new game objects when changing zones, there needed to be some scripting to make Howltooth Hollow forget about it.moomarc wrote:@Sloth: In the Play ability for Howltooth Hollow you just added, what's up with the ForgetRemembered param? There's nothing in the code for it and I'm not sure if it makes sense as a ForgetOtherRemembered where it's placed in the script at the moment. Am I missing something?
It doesn't work with a subability because if the player chooses not to play the card, the forgetting should not happen. I think this problem is still there for cards that target (if the player chooses to play the card but cancels the targeting).
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Incorrect Scripts
by moomarc » 18 May 2012, 12:38
I think ideally the whole remembered system needs some tweaking. Perhaps we need a 'TrackRemembered' parameter that flags the host and affected cards. Then if the host card changes zones the flags and remembered list is cleared, and if one of the affected cards changes zones (except to the stack) it is removed from the remembered list and has its trackedBy flag removed. Not sure if that makes sense.Sloth wrote:Thanks for reminding me. Because cards don't become new game objects when changing zones, there needed to be some scripting to make Howltooth Hollow forget about it.moomarc wrote:@Sloth: In the Play ability for Howltooth Hollow you just added, what's up with the ForgetRemembered param? There's nothing in the code for it and I'm not sure if it makes sense as a ForgetOtherRemembered where it's placed in the script at the moment. Am I missing something?
It doesn't work with a subability because if the player chooses not to play the card, the forgetting should not happen. I think this problem is still there for cards that target (if the player chooses to play the card but cancels the targeting).
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Who is online
Users browsing this forum: No registered users and 23 guests