[fixed/closed] Immerwolf + werewolves

[jl415]

Describe the Bug:
Bane of Hanweir doesn't lose defender (after extensive testing sometimes it does lose the defender status but I can't pin it down).

Which card did behave improperly ?
Bane of Hanweir

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Jan 01, 2014 : Commanding the revision of Ice Age v2 - Gauntlet

What exactly should be the correct behavior/interaction ?
Bane of Hanweir loses defender when transforming.

Are any other cards possibly affected by this bug ?
Immerwolf

[BAgate]

Works for me in a clean game. Could you include a savegame so we can check interactions?

Also, when referencing double-faced cards, try to include the front side name. It makes it a lot easier for us.

[jl415]

Ah, sorry about that, I've edited the name.

Saved game attached, my suspicion is some sort of interaction with Immerwolf - when I cast it my Bane of Hanweir gets defender out of the blue.

[BAgate]

It must have something to do with the Immerwolf, when you kill it the Bane of Hanweir loses defender.

Also, for some reason in your savegame my werewolves are transforming from human to non-human when I cast two spells in a turn (should only happen when no spells are cast).

Also, in a clean game these weird errors arise when Immerwolf is cast.

[jl415]

Yeap, I really think it's to do with Immerwolf, just tried with another warewolf transformed creature, Terror of Kruin Pass (Kruin Outlaw), and it doesn't get double strike. If I bury Immerwolf it gets double strike.

Should I update the title to Immerwolf or the mods do that?

[BAgate]

Leave that sort of thing to us unless you are asked to do it.

[jl415]

Thanks =)

[Gargaroz]

Well, the code seems fine, I readjusted it a bit, consider it fixed.

[BAgate]

Bane of Hanweir just got defender when I cast an Immerwolf, so this is still bugged.

[jl415]

Bane of Hanweir just got defender when I cast an Immerwolf, so this is still bugged.

I don't -.-

[BAgate]

This is what I just got.

[Korath]

Does the defender icon persist if you tap a land (which will force a recomputation)?

And can I get a step-by-step repro?

[BAgate]

Defender icon persists for at east 2 turns of normal gameplay.

To reproduce: I played a werewolf deck which naturally included Immerwolf (also tried in a pure test deck with same results). Death Wish to add Hanweir Watchkeep (since I don't normally play with it). Cast the Hanweir Watchkeep, let it transform, then cast Immerwolf. As soon as Immerwolf enters play the defender icon appears.

Savegame attached if that is any help.

[jl415]

Yeap, I confirm too, just tried that.

[Korath]

Fixed this symptom in 6f998b5. Not related to Immerwolf's influence on transformation at all, nor to this problem with transforming werewolves in both versions of BNG (which was also mentioned above).

This will affect any double-faced or flipping creature card that has different abilities in its transformed/flipped state than in its untransformed/unflipped state, and is currently in its transformed/flipped state; it'll show the untransformed/unflipped abilities as soon as an Immerwolf comes into play.

This is caused by a combination of two bugs:

• Immerwolf's +1/+1 ability checked has_subtype() before checking event. This is poor practice in any case, since the overwhelming majority of function calls won't be of any given event, and checking event is many orders of magnitude faster than checking subtype.
• has_subtype() calls is_changeling(), which in turn calls get_abilities(..., EVENT_ABILITIES). During recalculate_all_cards_in_play(), events are sent in order EVENT_SET_COLOR, EVENT_CHANGE_TYPE, EVENT_ABILITIES, EVENT_TOUGHNESS, EVENT_POWER, EVENT_STATIC_EFFECTS; if has_subtype() gets called before EVENT_CHANGE_TYPE or (if it's called before the card that changes its type is) during it, it computes abilities for the card's base type and clears KEYWORD_RECALC_ABILITIES so that, when EVENT_ABILITIES is sent from recalculate_all_cards_in_play(), it uses the cached value.

I've fixed both of these, each of which fixes the symptom in isolation: Immerwolf checks for EVENT_POWER or EVENT_TOUGHNESS before inspecting the affected card's subtypes, and is_changeling() stashes and restores the current keywords (including KEYWORD_RECALC_ABILITIES) around get_abilities(). The latter will make has_subtype() even more inefficient if called in the wrong order, the way Immerwolf used to, but will at least produce correct results.