[fixed/closed]Buyback

by **Mojodishu** » 16 Feb 2014, 22:57

Describe the Bug:
Looks like "buyback" is fatally bugged in the newest release - casting any spell with buyback crashes the game.

Which card did behave improperly ?
Whispers of the Muse in an attached savegame, but I had experienced the same crash with Shattering Pulse and some other cards I can't remember.

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Update 2014/02/15: Born of the Gods, Duel

What exactly should be the correct behavior/interaction ?
Game shouldn't crash.

Are any other cards possibly affected by this bug ?
All cards with buyback.

by **Korath** » 17 Feb 2014, 00:22

Only asm buyback cards - Allay, Disturbed Burial, Elvish Fury, Evincar's Justice, Searing Touch, Seething Anger, Shattering Pulse, and Whispers of the Muse. They make the same unsafe assumption that Tawnos's Coffin does. Rather than keep on stumbling across them, I've made the calling function bug-for-bug compatible in 767c791.

by **HarlequinCasts** » 17 Feb 2014, 00:26

Whispers of the Muse and Shattering Pulse definitely crash the game. Also found Searing Touch will.

Tested other common buyback spells and the following all work fine:
Demonic Collusion
Forbid
Capsize
Mystic Speculation

I thought it might be only instants since Forbid is an interrupt, but Capsize works fine... Well, it's a start.

EDIT: Nevermind Korath beat me.

by **BAgate** » 20 Feb 2014, 01:28

Doesn't crash the game. But two issues: 1) it doesn't always work. Sometimes it works as it should and sometimes you select buyback, pay the mana and the card goes to the gy without doing anything. It is very inconsistent and I can't figure out what the pattern is (you might need to try the savegame multiple times to see this). 2) You have to target the spell twice.

Note: tested with both Allay and Elvish Fury.

by **Korath** » 20 Feb 2014, 14:12

These only ever worked by accident; rather than looking at any of their own parameters, they looked at local variables in the calling function; those wouldn't've been right even for all calls from the exe, and won't be from dispatch_event_raw() now that it's been rewritten in C. Unsalvageable; will rewrite them all.

by **Korath** » 23 Feb 2014, 04:10

All eight already had C implementations. Allay, Disturbed Burial, and Searing Touch needed slight touchups; the other five were fine. Marked all for csv update in 6e89f59.