It is currently 05 Jun 2024, 11:16
   
Text Size

Draft Development in ML 3.0

Discuss Upcoming Releases, Coding New Cards, Etc.
PLEASE DO NOT REPORT BUGS HERE!

Moderators: BAgate, drool66, Aswan jaguar, gmzombie, stassy, CCGHQ Admins

Re: Draft Development in ML 3.0

Postby xdmo4 » 29 Jun 2012, 11:24

Hi, I am new to manalink 3.0 but I used to play with the old shandalar. I have some problems when I try to draft using the manalink 3.0 version that CirothUngol uploaded on mediafile. After picking the cards that I want I can´t edit my deck because there is no option to it, and so the game proceeds with all the cards that I have picked and without lands... Any idea to solve this problem?

I also would like to understand better how can I draft with the recent sets... I downloaded all the files foolosopher uploaded and .dck files but I can´t make it work... If i copy them to the game folder when i try to play all the text disappear and I am unable to select the cards our start a match.

I would really appreciate some help since I love draft.
xdmo4
 
Posts: 2
Joined: 29 Jun 2012, 10:54
Has thanked: 0 time
Been thanked: 0 time

Re: Draft Development in ML 3.0

Postby CirothUngol » 29 Jun 2012, 12:43

I just checked and Draft seems to (kinda) work in Manalink 3.0. Check this link to make sure you're doing it right.

Gargaroz wrote:As now, Rotisserie is being disabled.
This is from a few posts back (about 2 months ago). It seems to indicate that Draft is unfinished and not expected to work properly.
"I thought the day had brought enough horrors for our ragged band, but the night was far worse."
-Lucilde Fiksdotter


Shandalar 2012 Revisited
Magic: The Gathering Abandonware
User avatar
CirothUngol
Programmer
 
Posts: 431
Joined: 13 May 2009, 21:34
Location: Gulf Coast, Texas, USA
Has thanked: 106 times
Been thanked: 107 times

Re: Draft Development in ML 3.0

Postby xdmo4 » 29 Jun 2012, 22:55

Thanks CirothUngol...

I tried again and draft works, the only problem I have now is when I try with custom sets.

I followed the instruction written in the link you posted. changed the sets.txt file and now is possible to select the "new" set from the menu, but when I start the draft the cards do not correspond with the ones that are in the custom set that I created... If I try to run Singleton this message appears "Not enough coded cards to enforce rarity" Is any way to run singleton ignoring rarities? Or any other alternative?
It would be awesome to draft with recent cards.
xdmo4
 
Posts: 2
Joined: 29 Jun 2012, 10:54
Has thanked: 0 time
Been thanked: 0 time

Re: Draft Development in ML 3.0

Postby CirothUngol » 30 Jun 2012, 03:58

I'm not a developer or anything, but I'm quite certain the official answer is:
"Draft does not yet work in Manalink 3.0"

...hence the "Development" in the title of this thread. See, Manalink just went through a HUGE change. Breaking the 2,000 card limit has opened some big doors for development... and there's a few that have been slammed shut as well.

Draft was developed by Jatill in 2009, and there's a chance it was only intended to work with no more than 2,000 individual cards. Foolosopher started this thread after Manalink 3.0 was released to keep us apprised of his attempts to fix the issues with Draft... but there has been no announcement that he has, so we must assume that he has not.
xdmo4 wrote:...but when I start the draft the cards do not correspond with the ones that are in the custom set that I created.
Did you create the Custom Sets with the same version of Manalink that you're attempting to draft them on? The CardID numbers change from version to version. I've used the PlayDeck Analyser to rebuild the standard DraftSets and Expansions. You can try them, but like I said... I think Draft is kinda broken.
Attachments
DraftSets_20120527_v2.zip
Draft Sets and Expansions for Manalink 3.0 update 20120527_v2
(167.44 KiB) Downloaded 386 times
"I thought the day had brought enough horrors for our ragged band, but the night was far worse."
-Lucilde Fiksdotter


Shandalar 2012 Revisited
Magic: The Gathering Abandonware
User avatar
CirothUngol
Programmer
 
Posts: 431
Joined: 13 May 2009, 21:34
Location: Gulf Coast, Texas, USA
Has thanked: 106 times
Been thanked: 107 times

Re: Draft Development in ML 3.0

Postby Aswan jaguar » 27 Sep 2012, 13:48

Foolosopher I hope you will find sometime to fix what has changed when those card_ids shifted position (causing problems to draft) and make draft work again.Unfortunately I didn't have time to test when you released singleton and 6-8 players version or custom sets.I tried to en-corporate the changes new ids and new sets to your work it seemed not to be so difficult (for a coder probably it isn't)but I am not able to do it. :oops:
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester Elite
 
Posts: 8092
Joined: 13 May 2010, 12:17
Has thanked: 732 times
Been thanked: 465 times

Re: Draft Development in ML 3.0

Postby foolosopher » 14 Oct 2012, 23:38

Hi guys, long time no see and sorry for disappearing. I hope you 'll have me back.
I took a quick look and the draft.c has been clobbered a bit, but checked and until the update of 2012-03-10_v2-Dark Ascension,
the draft is working (except rotisserie). In the next versions the number of expansions is extracted incorrectly
"
read_rarities expansions = 137
read_rarities expansion_size = 52
read_rarities count=12685
"
and this sets off the rarity check and breaks the draft, although the number of cards is correct. So there are probably two cases
1. The rarity.dat is not formed correctly
2. The magic_updater passes the wrong value to number of expansions

So could you check these, and I 'll come back to see if something more is wrong.
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby Aswan jaguar » 15 Oct 2012, 13:43

@foolosopher the expansion.h has changed by 2 numbers from the beginning so all sets moved 2 numbers as Promo Expansion has gone first and the numbering begins from 1 instead of 0 that it was before.

...and of course welcome back really nice to see you again.
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester Elite
 
Posts: 8092
Joined: 13 May 2010, 12:17
Has thanked: 732 times
Been thanked: 465 times

Re: Draft Development in ML 3.0

Postby foolosopher » 15 Oct 2012, 14:10

Thanks for the info AJ.
Did some more testing and found out, that the number of expansions is extracted correctly until the 2012-05-27_Avacyn_Machinery_V2 update.
From the 2012-07-15_v3-Kamigawa stories
read_rarities expansions jumps to 137.
vagtest.txt
(5.16 KiB) Downloaded 282 times


Also from what little I saw, the use of a single Draftsets file, instead of it being a folder including the sets file, where additional sets are declared, is causing issues, maybe the transition is not ready yet.
Anyway, if someone else has taken over draft and is planning for some changes, please let me know, else give me a few days.
And for those who want to play draft you can use the 2012-03-10_v2-Dark Ascension update (2012-04-10-sensei_vanilla_masques_v2 seems to work too), but don't forget to also convert your decks using Playdeck analyser.
Last edited by foolosopher on 20 Oct 2012, 23:45, edited 1 time in total.
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby Aswan jaguar » 15 Oct 2012, 15:02

None has taken over draft's development it's were you left it so whenever you are ready please do step forward.
Also please put more info about what is needed for some elements of draft you made,to work like draft-v17-singleton-numplayers-clean.C does it have to be renamed to draft.C and overwrite it to work?
Another question is did you make the change Jatill mentioned to make custom sets work?I tried to replaced that sentence but....I better stick to testing :lol:
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester Elite
 
Posts: 8092
Joined: 13 May 2010, 12:17
Has thanked: 732 times
Been thanked: 465 times

Re: Draft Development in ML 3.0

Postby foolosopher » 15 Oct 2012, 15:27

So now I see, who has been tampering with the code! [-X and didn't do his homework. Did you send the changed file to Gargaroz to include in the next updates?
I wonder how did you manage to compile it?
Anyway, like I told you, give me a few days to test it against the September update...
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby Aswan jaguar » 15 Oct 2012, 15:29

No I meant I was fooling around with my file nothing was changed or send to Gargaroz don't worry at least by me.
I thought it was just a simple text change oops! :oops:
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester Elite
 
Posts: 8092
Joined: 13 May 2010, 12:17
Has thanked: 732 times
Been thanked: 465 times

Re: Draft Development in ML 3.0

Postby foolosopher » 21 Oct 2012, 00:26

OK, read some info on the updates and it seems that the problems are caused by the changes in the .csv files.
2012-04-10-sensei_vanilla_masques_v2: there was a shift in the new rarities columns because of the PROMO set. This is breaking the game when you select to play with the LIMITED_EDITION_ALPHA set, because in essence it can't find any cards. If fou choose to play with the other sets it should play, but cards will be wrong because of the shifted column. Fixable.
2012-07-15-Kamigawa stories_v3: This is where the big problem is. In this update there were 8 new columns inserted (the legality per game type) between DB8 and new rarities columns.
The problem is the magic updater puts into the rarity.dat some of those columns so the draft breaks (unless you also updated the magic updater). I see two options here
1)Someone updates the magic updater to put the correct columns into the rarity.dat
2)I 'll try to read the rarity after the newly inserted columns.

Anyone also nows if there is a limit on how many columns are passed into the rarity.dat?
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby Aswan jaguar » 21 Oct 2012, 06:53

I don't know if this is helpful is an answer of Mok to a question you did to him.

Mok said:
Just keep in mind that csv file is no longer directly accessed by the game so it might not be available for any scanning. Columns with expansions are available in rarity.dat. The file is simple (4 bytes with number of cards, 4 bytes with number of expansions and then rarity data). Each expansion takes 3 bits so each card occupies (number of expansions*3+7)/8 bytes of data. Possible values for 3 bits: 0 = nothing, 1 = common, 2 = uncommon, 3 = rare, 4 = mythic, 5 = land, 6 = special, 7 = (unused).
Edit I realised you asked about columns not expansions but it is not likely Mok made it support future expansions but not enough columns for them right?
---
Trying to squash some bugs and playtesting.
User avatar
Aswan jaguar
Super Tester Elite
 
Posts: 8092
Joined: 13 May 2010, 12:17
Has thanked: 732 times
Been thanked: 465 times

Re: Draft Development in ML 3.0

Postby foolosopher » 21 Oct 2012, 08:24

In essence columns represent expansions, but with the insertion of new columns the alignment between the .csv - rarity.dat and the reading of rarity is broken. The way this is structured, should be expandable, but we need the code of the manalink updater, I hope Gargaroz has it. Otherwise the available expansions for draft will be limited to the number of columns/expansions the updater can support. At least, until we find a workaround for it.

So Gargaroz, could you shed any light to those questions?
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

Re: Draft Development in ML 3.0

Postby foolosopher » 22 Oct 2012, 13:54

Hello again,
Attached you can find a fix for the draft, for 2012-09-16_M13_v3 update. In the zip are included the updated:
- ManalinkEh.dll, which you can directly install (replace the previous one)
- draft.c, with a few fixes to read the proper bits from the rarity.dat , only needed for developer(s)

I see that the draft code was reverted to a few stages back. Gargaroz, tell me if you have some plan on draft, I can help for some time, promise I won't disappear without notice. :oops:
Attachments
2012-09-16_M13_v3-draft-fix.rar
(633.41 KiB) Downloaded 293 times
I long for the time where one man could make a difference...
foolosopher
 
Posts: 189
Joined: 19 May 2010, 20:53
Location: Greece
Has thanked: 13 times
Been thanked: 17 times

PreviousNext

Return to Development

Who is online

Users browsing this forum: No registered users and 2 guests


Who is online

In total there are 2 users online :: 0 registered, 0 hidden and 2 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 2 guests

Login Form