Bug Reports (snapshot builds)

[Sloth]

When Omniscicence is on the battlefield, cards with kicker/multikicker can't cast without paying its mana cost.

I've tested Apex Hawks and Ana Battlemage and they both worked with Omniscicence. What did you test?

[Bundy]

forge-1.3.1-20121105.114012-8

Computer blocks my Darksteel Colossus with Spiritual Guardian and drops down to -1 life. Then this error pops up. When i close it a shorter error replaces it. When i close this one another error pops up. Looks like these 2 errors keep replacing each other

Code: Select all

This is a Crash Report. An error has occurred. Please save this message to a file.
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
   http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.

null


Version:
Forge version 1.3.1-SNAPSHOT

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.7.0_09 Vendor: Oracle Corporation

Detailed error trace:
java.lang.NullPointerException
   at forge.gui.match.TargetingOverlay$OverlayPanel.paintComponent(TargetingOverlay.java:175)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JComponent.paintChildren(Unknown Source)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JLayeredPane.paint(Unknown Source)
   at javax.swing.JComponent.paintChildren(Unknown Source)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JLayeredPane.paint(Unknown Source)
   at javax.swing.JComponent.paintChildren(Unknown Source)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JComponent.paintToOffscreen(Unknown Source)
   at javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Unknown Source)
   at javax.swing.RepaintManager$PaintManager.paint(Unknown Source)
   at javax.swing.RepaintManager.paint(Unknown Source)
   at javax.swing.JComponent._paintImmediately(Unknown Source)
   at javax.swing.JComponent.paintImmediately(Unknown Source)
   at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
   at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
   at javax.swing.RepaintManager.prePaintDirtyRegions(Unknown Source)
   at javax.swing.RepaintManager.access$700(Unknown Source)
   at javax.swing.RepaintManager$ProcessingRunnable.run(Unknown Source)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$200(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.WaitDispatchSupport$2.run(Unknown Source)
   at java.awt.WaitDispatchSupport$4.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.awt.WaitDispatchSupport.enter(Unknown Source)
   at java.awt.Dialog.show(Unknown Source)
   at java.awt.Component.show(Unknown Source)
   at java.awt.Component.setVisible(Unknown Source)
   at java.awt.Window.setVisible(Unknown Source)
   at java.awt.Dialog.setVisible(Unknown Source)
   at forge.error.ErrorViewer.showDialog(ErrorViewer.java:192)
   at forge.error.ErrorViewer.showError(ErrorViewer.java:117)
   at forge.error.ErrorViewer.showError(ErrorViewer.java:79)
   at forge.error.ExceptionHandler.uncaughtException(ExceptionHandler.java:51)
   at java.lang.ThreadGroup.uncaughtException(Unknown Source)
   at java.lang.ThreadGroup.uncaughtException(Unknown Source)
   at java.awt.EventDispatchThread.processException(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


Code: Select all

This is a Crash Report. An error has occurred. Please save this message to a file.
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
   http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.

null


Version:
Forge version 1.3.1-SNAPSHOT

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.7.0_09 Vendor: Oracle Corporation

Detailed error trace:
java.lang.NullPointerException
   at forge.gui.match.TargetingOverlay$OverlayPanel.paintComponent(TargetingOverlay.java:175)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JComponent.paintChildren(Unknown Source)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JLayeredPane.paint(Unknown Source)
   at javax.swing.JComponent.paintChildren(Unknown Source)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JLayeredPane.paint(Unknown Source)
   at javax.swing.JComponent.paintChildren(Unknown Source)
   at javax.swing.JComponent.paint(Unknown Source)
   at javax.swing.JComponent.paintToOffscreen(Unknown Source)
   at javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Unknown Source)
   at javax.swing.RepaintManager$PaintManager.paint(Unknown Source)
   at javax.swing.RepaintManager.paint(Unknown Source)
   at javax.swing.JComponent._paintImmediately(Unknown Source)
   at javax.swing.JComponent.paintImmediately(Unknown Source)
   at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
   at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)
   at javax.swing.RepaintManager.prePaintDirtyRegions(Unknown Source)
   at javax.swing.RepaintManager.access$700(Unknown Source)
   at javax.swing.RepaintManager$ProcessingRunnable.run(Unknown Source)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$200(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


[Diogenes]

Edit: Nevermind, I think I'm jumping the gun. I'll recheck the issue once Max is done with the ability refactoring.

[Bundy]

forge-1.3.1-20121105.114012-8

I tap all my lands for mana and notice i am 1 land short of casting a spell. Pressing cancel empties the manapool and my lands stay tapped

[swordshine]

11/05 snapshot:
Academy Researchers need "OptionalDecider$ You"

[Diogenes]

Over in the beta release thread an issue brought up the issue that Planechase 2012 is inconsistently supported as a set. All the uniques to that set are in correctly, but some reprints have the PC2 set info and most don't, so if you filter by PC2 in the deck editor you'll get Cancel (a reprint) but not Arc Trail. I can go through and either add the PC2 set info to all the remaining cards, or remove the set info from the few PC2 reprints that have it if Planechase support is meant to be limited to unique cards at the moment.

Which should I do?

[Max mtg]

forge-1.3.1-20121105.114012-8

I tap all my lands for mana and notice i am 1 land short of casting a spell. Pressing cancel empties the manapool and my lands stay tapped

That's known. A fix planned for this week.

[friarsol]

Over in the beta release thread an issue brought up the issue that Planechase 2012 is inconsistently supported as a set. All the uniques to that set are in correctly, but some reprints have the PC2 set info and most don't, so if you filter by PC2 in the deck editor you'll get Cancel (a reprint) but not Arc Trail. I can go through and either add the PC2 set info to all the remaining cards, or remove the set info from the few PC2 reprints that have it if Planechase support is meant to be limited to unique cards at the moment.

Which should I do?

Don't do anything, we have an automated script that does that.

[ArsenalNut]

Refactoring Draw AF has broken Tamiyo, the Moon Sage second ability.

Fateful Hour part of Clinging Mists is not working. Attacking creatures untap on the next turn.

[Diogenes]

Refactoring Draw AF has broken Tamiyo, the Moon Sage second ability.

Fateful Hour part of Clinging Mists is not working. Attacking creatures untap on the next turn.

This also affects Thundermaw Hellkite (just the tapping part, the damage comes out fine.)

[Max mtg]

This also affects Thundermaw Hellkite (just the tapping part, the damage comes out fine.)

Thundermaw got its fix in 17880.
Tamiyo is fixed too.
Clinging mists work properly as well.

What else have I broken with AF changes?

[Sloth]

This also affects Thundermaw Hellkite (just the tapping part, the damage comes out fine.)

Thundermaw got its fix in 17880.
Tamiyo is fixed too.
Clinging mists work properly as well.

What else have I broken with AF changes?

I'm very much sure that targetIsPreferred should always be false. If there is a Defined parameter it should always be used instead of a target.

[Max mtg]

I'm very much sure that targetIsPreferred should always be false. If there is a Defined parameter it should always be used instead of a target.

I don't know. A lot of effects check target first. Sacrifice for instance, TwoPiles, ChoosePlayer and a lot more.

To see it update to r17828 and search for code like this:

Code: Select all

        ArrayList<Player> tgts;
        if (tgt != null) {
            tgts = tgt.getTargetPlayers();
        } else {
            tgts = AbilityFactory.getDefinedPlayers(card, params.get("Defined"), sa);
        }

Yet, I guess that target acquiring code has been heavily copy-pasted and does not match what the effect is supposed to do.

[Sloth]

I don't know. A lot of effects check target first. Sacrifice for instance, TwoPiles, ChoosePlayer and a lot more.

To see it update to r17828 and search for code like this:

Code: Select all

        ArrayList<Player> tgts;
        if (tgt != null) {
            tgts = tgt.getTargetPlayers();
        } else {
            tgts = AbilityFactory.getDefinedPlayers(card, params.get("Defined"), sa);
        }

Yet, I guess that target acquiring code has been heavily copy-pasted and does not match what the effect is supposed to do.

A code block like this could have been switched without breaking anything. The Defined parameter has a single purpose in these AF's, so it will not be present on cards that target and want their target to be used here.

There are some AF's that never want to use Defined for players, because they use it for defined cards (for example AF ChangeZone uses DefinedPlayer instead). Now that i think about it, these AF's might cause problems.

[Max mtg]

Well... proceed with changes if you feel confident about them.