Bug Reports (snapshot builds)
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by moomarc » 31 Dec 2012, 16:58
@RumbleBBU: Did you get manage to find out why DamageHistory was being called? Or should I make the Array sizes standard?moomarc wrote:I'm assuming it was caused by my commit to get The Fallen working. I had to make a change to CardDamageHistory but don't rememeber adding anything except making the card actually record which players it damaged in the game. I'm unfortunately only back on Monday, so will only be able to try fix it then. Otherwise if you're desperate, the commit was in the last two days so you can look at what I changed in that commit. Its possible I just left something in by mistake. Sorry for the inconvenience.RumbleBBU wrote:I just tried to checkout the SVN and try to get up to speed with the current code.
Testing Sealed Deck, just plain 5th Edition with 8 boosters, I get this in the deck editor when I click on any card at all:...
(Just why should the deck editor care about CardDamageHistory anyway?)
EDIT: Just checked and it was rev18867. Not sure why DamageHistory is being called from the deck editor, not something to do with my commit, but I know why its crashing once there. I tried to optimize the arraylist sizes by calling Singletons.getModel().getGame().getPlayers().size(). Obviously this won't work before a game starts so you might just want to change to a standard new ArrayList.
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Bug Reports (snapshot builds)
by RumbleBBU » 31 Dec 2012, 18:57
I just reverted the array sizes back to a fixed 2, as a quick fix to make my local copy work. I didn't look into it any further than that, sorry.
Re: Bug Reports (snapshot builds)
by swordshine » 02 Jan 2013, 10:32
Two bugs:
1)When cards with etb effects exiled by Karn Liberated are put onto the battlefield by the ultimate, their etb effects don't trigger.
2)Karn Liberated's first ability should be mandatory.
1)When cards with etb effects exiled by Karn Liberated are put onto the battlefield by the ultimate, their etb effects don't trigger.
2)Karn Liberated's first ability should be mandatory.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by ArsenalNut » 02 Jan 2013, 15:48
I added Mandatory to the first ability to fix it.swordshine wrote:Two bugs:
1)When cards with etb effects exiled by Karn Liberated are put onto the battlefield by the ultimate, their etb effects don't trigger.
2)Karn Liberated's first ability should be mandatory.
I tried to test ETB effects with Karn Liberated. I exiled a Geist-Honored Monk and Thragtusk with Karn Liberated then activated his ultimate. The ETB triggers for the exiled cards went on the stack. Then I got the prompt for mulligan. The game froze when I responded to the mulligan prompt.
So many cards, so little time
-
ArsenalNut - Posts: 512
- Joined: 08 Jul 2011, 03:49
- Has thanked: 27 times
- Been thanked: 121 times
Re: Bug Reports (snapshot builds)
by Bundy » 02 Jan 2013, 16:06
forge-1.3.4-20121226.135209-13
I have Phytohydra in play. Computer enchants it with Ice Cage. Next i equip Phytohydra with Pariah's Shield. Ice Cage is not destroyed.
I have Phytohydra in play. Computer enchants it with Ice Cage. Next i equip Phytohydra with Pariah's Shield. Ice Cage is not destroyed.
- Bundy
- Posts: 348
- Joined: 17 Dec 2010, 17:32
- Location: The netherlands
- Has thanked: 23 times
- Been thanked: 3 times
Re: Bug Reports (snapshot builds)
by ArsenalNut » 02 Jan 2013, 16:22
This worked correctly for me when I tested with r18898.Bundy wrote:forge-1.3.4-20121226.135209-13
I have Phytohydra in play. Computer enchants it with Ice Cage. Next i equip Phytohydra with Pariah's Shield. Ice Cage is not destroyed.
So many cards, so little time
-
ArsenalNut - Posts: 512
- Joined: 08 Jul 2011, 03:49
- Has thanked: 27 times
- Been thanked: 121 times
Re: Bug Reports (snapshot builds)
by friarsol » 02 Jan 2013, 16:59
Yea it's part of the Trigger work that I've been doing on and off. Those triggers shouldn't be hitting the stack until the next time a player would gain priority, which is basically the Upkeep of the Player who activated Karn. This also affects things like Earthbind and Valakut, the Molten PinnacleArsenalNut wrote:I tried to test ETB effects with Karn Liberated. I exiled a Geist-Honored Monk and Thragtusk with Karn Liberated then activated his ultimate. The ETB triggers for the exiled cards went on the stack. Then I got the prompt for mulligan. The game froze when I responded to the mulligan prompt.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by krevett » 03 Jan 2013, 13:34
I got a crash when selecting New/Load Quest with an empty res\quest\data folder
- | Open
- This is a Crash Report. An error has occurred. Please save this message to a file.
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.
null
Version:
Forge version 1.3.4-SNAPSHOT-r18891
OS: Windows Vista Version: 6.0 Architecture: x86
Java Version: 1.6.0_26 Vendor: Sun Microsystems Inc.
Detailed error trace:
java.lang.NullPointerException
at forge.quest.QuestController.resetDuelsManager(QuestController.java:380)
at forge.quest.QuestController.load(QuestController.java:186)
at forge.gui.home.quest.CSubmenuQuestData.update(CSubmenuQuestData.java:125)
at forge.gui.home.CHomeUI.itemClick(CHomeUI.java:37)
at forge.gui.home.LblMenuItem$1.mousePressed(LblMenuItem.java:50)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$000(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$2.run(Unknown Source)
at java.awt.EventQueue$2.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
- krevett
- Posts: 109
- Joined: 21 Feb 2012, 22:24
- Location: France
- Has thanked: 18 times
- Been thanked: 9 times
Re: Bug Reports (snapshot builds)
by RumbleBBU » 03 Jan 2013, 13:59
Fixed!krevett wrote:I got a crash when selecting New/Load Quest with an empty res\quest\data folder
Thanks for the report, krevett.
Re: Bug Reports (snapshot builds)
by friarsol » 04 Jan 2013, 00:59
r18913
It looks like that Morph with turn face up triggers, trigger when the Morph spell is countered.
It looks like that Morph with turn face up triggers, trigger when the Morph spell is countered.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by ArsenalNut » 04 Jan 2013, 05:10
Issue should be fixed. The majority of the TurnsFaceUp triggers were missing the "TriggerZones$ Battlefield" parameter.friarsol wrote:r18913
It looks like that Morph with turn face up triggers, trigger when the Morph spell is countered.
So many cards, so little time
-
ArsenalNut - Posts: 512
- Joined: 08 Jul 2011, 03:49
- Has thanked: 27 times
- Been thanked: 121 times
Re: Bug Reports (snapshot builds)
by Agetian » 04 Jan 2013, 06:53
Jhoira's Timebug malfunctions, at least in the following scenario: I suspended a Curse of the Cabal, and then tapped my Jhoira's Timebug and targetted it, but it didn't remove a time counter.
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by Agetian » 04 Jan 2013, 16:33
I used a Delve ability of Tombstalker, picked the only card in my graveyard (Lotus Bloom), and got the attached crash:
- Code: Select all
This is a Crash Report. An error has occurred. Please save this message to a file.
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.
null
Version:
Forge version 1.3.4-SNAPSHOT
OS: Windows 7 Version: 6.1 Architecture: x86
Java Version: 1.7.0_09 Vendor: Oracle Corporation
Detailed error trace:
java.lang.UnsupportedOperationException
at java.util.Collections$UnmodifiableCollection.remove(Unknown Source)
at forge.GameAction.getSpellCostChange(GameAction.java:1768)
at forge.card.cost.Cost.changeCost(Cost.java:450)
at forge.card.cost.CostPayment.changeCost(CostPayment.java:316)
at forge.card.spellability.SpellAbilityRequirements.startPaying(SpellAbilityRequirements.java:177)
at forge.card.spellability.SpellAbilityRequirements.needPayment(SpellAbilityRequirements.java:164)
at forge.card.spellability.SpellAbilityRequirements.fillRequirements(SpellAbilityRequirements.java:131)
at forge.card.spellability.SpellAbilityRequirements.fillRequirements(SpellAbilityRequirements.java:95)
at forge.GameAction.playSpellAbility(GameAction.java:2020)
at forge.GameAction.playCard(GameAction.java:1642)
at forge.control.input.InputPassPriority.selectCard(InputPassPriority.java:80)
at forge.gui.GuiInput.selectCard(GuiInput.java:115)
at forge.gui.match.nonsingleton.CHand.cardclickAction(CHand.java:188)
at forge.gui.match.nonsingleton.CHand.access$0(CHand.java:182)
at forge.gui.match.nonsingleton.CHand$1.mousePressed(CHand.java:60)
at java.awt.AWTEventMulticaster.mousePressed(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$200(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by swordshine » 06 Jan 2013, 09:43
The keyword Annihilator is a triggered ability, but it does not use the stack in Forge, and I cannot Stifle it.
Edit: One more issue about Annihilator. It seems cards with Annihilator usually make the first opponent sacrifice, not the defender in multiplayer games.
Edit: One more issue about Annihilator. It seems cards with Annihilator usually make the first opponent sacrifice, not the defender in multiplayer games.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by Agetian » 06 Jan 2013, 09:50
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Who is online
Users browsing this forum: No registered users and 15 guests