Forge Beta: 01-18-2013 ver 1.3.5

[donluca]

Max, due to the changes made in CardFactory now the Lotus Bloom suspends correctly but doesn't come into play when the last time counter is removed.

This is because the change made (methinks) made the spell uncastable, so it will never move from the exiled zone into the battlefield.

EDIT 1:Ok, I've fixed it (that was a bit brutal, but whatever)

Code: Select all

    private void playFromSuspend() {
        final Card c = this;
       
        //Checks if the card is castable. If not, it makes it castable.
        if (c.getManaCost().isNoCost())
        {
            c.addSpellAbility(new SpellPermanent(c));
        }

in Card.java line 1359

EDIT 2: I still have to understand how to commit the changes LOL.
I want to test it a bit though, I'll eventually commit later.

[timmermac]

The deck conformity option does not work for quest mode. I unchecked it, and I'm still limited to 4 of each card.

[Doomlord]

The card Cloud Key gives the option to choose Planesswalker or Tribal, which it should not, as the card does not say "choose a type", but rather gives a list of types to choose from, not including those two.

Also, there is a bug with the display of the secound ability of Jace, the Mind Sculptor. When you click on Jace to activate one of his abilities, the cost of his secound ability is not displayed.

[friarsol]

The deck conformity option does not work for quest mode. I unchecked it, and I'm still limited to 4 of each card.

I'm not really sure that it should. The bypassing restrictions was mostly just for Constructed.

[friarsol]

Also, there is a bug with the display of the secound ability of Jace, the Mind Sculptor. When you click on Jace to activate one of his abilities, the cost of his secound ability is not displayed.

I think Max fixed this already, because I don't see that in the dev version.

[Max mtg]

Max, due to the changes made in CardFactory now the Lotus Bloom suspends correctly but doesn't come into play when the last time counter is removed.

This is because the change made (methinks) made the spell uncastable, so it will never move from the exiled zone into the battlefield.

EDIT 1:Ok, I've fixed it (that was a bit brutal, but whatever)

Code: Select all

    private void playFromSuspend() {
        final Card c = this;
       
        //Checks if the card is castable. If not, it makes it castable.
        if (c.getManaCost().isNoCost())
        {
            c.addSpellAbility(new SpellPermanent(c));
        }

in Card.java line 1359

EDIT 2: I still have to understand how to commit the changes LOL.
I want to test it a bit though, I'll eventually commit later.

Thank you, donluca. Your code does add the needed ability for suspeded spells, yet other cards with no manacost affected by a recent change are still unusable, eg Evermind.

Looks like I took a wrong desicion by not adding the spell that places the permanent onto battlefield to cards with no cost.
When it worked in 1.3.4, the code was checking if spell cost equalled an empty string. And in that case didn't offer that SpellAbility as an option to cast spell from hand. After I changed manacost to use a dedicated class, the comparison against a string calculates to "not equal" at all times, and that ability didn't get filtered out.

To see the changes that made lotus bloom working again, please follow http://svn.slightlymagic.net/websvn/rev ... &peg=19092

As for commiting changes, you may ask any developer to commit your changes (given they are unfrequent), or if you would love to participate in development on a regular basis, come to developers' forum viewforum.php?f=52 and ask for commit rights there.

[donluca]

Max the change is fine, Evermind is the only other exception we need to handle as all the others cards have 0 casting cost so they can be played straight away.

I'm going to look at how Splice into Arcane works in Forge and post a fix.

EDIT: Looks like it'll be harder then initially thought
Because we need to set the card as playable when an arcane spell is on the stack, I really can't figure out how this is handled.

It seems that there's a check for whenever you play a card with arcane that controls your hand for cards that can be spliced and you can select them.

[Max mtg]

Max the change is fine, Evermind is the only other exception we need to handle as all the others cards have 0 casting cost so they can be played straight away.

Is it fine?
Imagine the card was returned into owner's hand (soon after Lotus Bloom resolved Glint Hawk was played). The card already has that spellpermanent ability. The next time it's clicked that recently added option appears in a list. The next time suspend wait os over that ability is added again.

[Max mtg]

The card Cloud Key gives the option to choose Planesswalker or Tribal, which it should not, as the card does not say "choose a type", but rather gives a list of types to choose from, not including those two.

Also, there is a bug with the display of the secound ability of Jace, the Mind Sculptor. When you click on Jace to activate one of his abilities, the cost of his secound ability is not displayed.

1. I've updated the card script for you.
2. Fixed in dev version (grab a daily build to see it fixed or wait for about 2 weeks until next beta)

[donluca]

Is it fine?
Imagine the card was returned into owner's hand (soon after Lotus Bloom resolved Glint Hawk was played). The card already has that spellpermanent ability. The next time it's clicked that recently added option appears in a list. The next time suspend wait os over that ability is added again.

You're absolutely right, didn't think about that case, my bad.
We may remove the spellpermanent ability whenever the card is in your hand, but that's not a good way to solve the problem.

I think that a new property "boolean isCastable" is required in the Card type to handle those null casting cost in the right way (along with some accessory methods to tell Forge how to behave in each case).

[friarsol]

Is it fine?
Imagine the card was returned into owner's hand (soon after Lotus Bloom resolved Glint Hawk was played). The card already has that spellpermanent ability. The next time it's clicked that recently added option appears in a list. The next time suspend wait os over that ability is added again.

You're absolutely right, didn't think about that case, my bad.
We may remove the spellpermanent ability whenever the card is in your hand, but that's not a good way to solve the problem.

I think that a new property "boolean isCastable" is required in the Card type to handle those null casting cost in the right way (along with some accessory methods to tell Forge how to behave in each case).

This was working just fine a few days ago, there's no reason to add all this stuff.

Cards with a cost of 0 just need to be handled differently than cards with no cost. Anyway, donluca it looks like you are new and interested in development, we can move further discussions to the developer's corner so the release thread isn't filled up with coding debugging and poking around.

[Xitax]

One game, AI kept returning 2 islands to his hand presumably to pay the morph cost for Fathom Seer, but it didn't flip. AI did this on the same morphed card 2 turns in a row.

On a related note, AI's morphed card is a black picture. Mine are not.

[friarsol]

One game, AI kept returning 2 islands to his hand presumably to pay the morph cost for Fathom Seer, but it didn't flip. AI did this on the same morphed card 2 turns in a row.

Ok, I just fixed that in the trunk. Should be in the next nightly release.

[gos]

My Turnabout untapped both my lands and my opponent's.

[Devilman06]

When I play Hell's Thunder or Ball Lightning and even Mimic Vat with sundial of the infinite and activate Sundial Of The Infinite at end of turn when the ability goes on the stack, At the end of my opponents turn they are sacrificed. Now it is my understanding that this should not happen. When you Activate Sundial of The Infinite at End of turn after the abilities go on the stack you should be able to keep the card/token.