Bug Reports (snapshot builds)
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by friarsol » 22 Jan 2013, 03:59
r19118
During my upkeep, I have two triggers hitting the stack at the same time. Powder Keg and Aven Riftwatcher (although I also noticed it with Planar Collapse). The DualListBox lists "Play land" as the description for both triggers, which is obviously completely wrong since these cards aren't land, and it should display the trigger description. Selecting either Play land lists the right card its attached to, and after you say ok, they go onto the stack just fine.
During my upkeep, I have two triggers hitting the stack at the same time. Powder Keg and Aven Riftwatcher (although I also noticed it with Planar Collapse). The DualListBox lists "Play land" as the description for both triggers, which is obviously completely wrong since these cards aren't land, and it should display the trigger description. Selecting either Play land lists the right card its attached to, and after you say ok, they go onto the stack just fine.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 22 Jan 2013, 07:20
fixed in 19124 - that's really funny, 'cause placing the code inside or outside of a single brace matters that much
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by myk » 22 Jan 2013, 19:33
I apologize in advance if I'm just misunderstanding something, but I don't seem to be getting a prompt for a damage target when Murasa Pyromancer is in play and I successfully cast a creature spell.
Also, the state of the summon plant checkbox and summon pet combobox on the quest duels and challenges pages is not restored on program start. Thanks!
Also, the state of the summon plant checkbox and summon pet combobox on the quest duels and challenges pages is not restored on program start. Thanks!
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: Bug Reports (snapshot builds)
by Max mtg » 22 Jan 2013, 19:53
Tested in svn build - the trigger works as expected.myk wrote:I apologize in advance if I'm just misunderstanding something, but I don't seem to be getting a prompt for a damage target when Murasa Pyromancer is in play and I successfully cast a creature spell.
Also, the state of the summon plant checkbox and summon pet combobox on the quest duels and challenges pages is not restored on program start. Thanks!
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by myk » 22 Jan 2013, 20:50
here's a screenshot of my battlescape. I just cast Goblin Tunneler, but there was no prompt from Murasa Pyromancer for a damage target. I had cast Murasa Pyromancer the previous turn, and I got a prompt then, but I didn't get one on this turn.
murasa_pyromancer_no_prompt1.jpeg
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: Bug Reports (snapshot builds)
by friarsol » 22 Jan 2013, 20:56
Make sure you read the cards. Goblin Tunneler does not have the creature type Ally.myk wrote:here's a screenshot of my battlescape. I just cast Goblin Tunneler, but there was no prompt from Murasa Pyromancer for a damage target. I had cast Murasa Pyromancer the previous turn, and I got a prompt then, but I didn't get one on this turn.murasa_pyromancer_no_prompt1.jpeg
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: Bug Reports (snapshot builds)
by myk » 23 Jan 2013, 09:40
Would it be alright if I tried a hand at fixing some of the (non-spurious) bugs that I filed -- especially regarding the GUI? If so, what is the procedure for submitting diffs? Who should I coordinate with to ensure effort isn't duplicated?
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: Bug Reports (snapshot builds)
by Chris H. » 23 Jan 2013, 12:54
myk wrote:Would it be alright if I tried a hand at fixing some of the (non-spurious) bugs that I filed -- especially regarding the GUI? If so, what is the procedure for submitting diffs? Who should I coordinate with to ensure effort isn't duplicated?
The getting started wiki has instructions for requesting commit privs. It generally is easier to make your own commits rather than waiting for someone else to merge in your work into the SVN.
You can start a topic on the forge Developer's Corner with a brief description of what you are working on and this should help to coordinate your efforts with the rest of the team.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Bug Reports (snapshot builds)
by Max mtg » 23 Jan 2013, 13:35
Chris, I am prefectly able to commit some early changes of newcomers... just to make some code-review and prevent someChris H. wrote:myk wrote:Would it be alright if I tried a hand at fixing some of the (non-spurious) bugs that I filed -- especially regarding the GUI? If so, what is the procedure for submitting diffs? Who should I coordinate with to ensure effort isn't duplicated?
The getting started wiki has instructions for requesting commit privs. It generally is easier to make your own commits rather than waiting for someone else to merge in your work into the SVN.
You can start a topic on the forge Developer's Corner with a brief description of what you are working on and this should help to coordinate your efforts with the rest of the team.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by myk » 23 Jan 2013, 18:18
very wise (and much appreciated : ) I created a topic hereMax mtg wrote:Chris, I am prefectly able to commit some early changes of newcomers... just to make some code-review and prevent somevery badcode that needs a lot of improvement from being added to the project.
- myk
- Posts: 439
- Joined: 17 Jan 2013, 02:39
- Location: California
- Has thanked: 38 times
- Been thanked: 57 times
Re: Bug Reports (snapshot builds)
by Asellia » 24 Jan 2013, 08:46
I have had this trouble since 1.3.4 or so, I think, but it appears that I cannot partake in challenges. I have been using a series of custom worlds I made, utilizing default enemies/challenges, however, I cannot seem to pick challenges even when I have enough wins:

My World File appears as:
I was using "forge-1.3.6-20130123.120651-5" as reference

My World File appears as:
- Code: Select all
Name:Main world
Name:Shandalar|Dir:shandalar|Sets:2ED, ARN, ATQ, 3ED, LEG, DRK, 4ED|Banned:Chaos Orb; Falling Star
Name:Jamuraa|Dir:jamuraa|Sets:5ED, ARN, MIR, VIS, WTH|Banned:Chaos Orb; Falling Star
Name:The Ancient World|Sets:LEA, LEB, 2ED
Name:Arabia|Sets:ARN, ATQ, LEG
Name:The Dark World|Sets:DRK, FEM, HML
Name:The Frozen Tundra|Sets:3ED, ICE, ALL, CSP
Name:Illusionary Planes|Sets:4ED, MIR, VIS, WTH
Name:The Weathered World|Sets:5ED, TMP, STH, EXO
Name:Urza's Domain|Sets:5ED, USG, ULG, UDS
Name:Phyrexia|Sets:6ED, MMQ, NMS, PCY
Name:The Invasion of Phyrexia|Sets:6ED, INV, PLS, APC
Name:Otaria, The Search for the Mirari|Sets:7ED, ODY, TOR, JUD
Name:Otaria's End|Sets:7ED, ONS, LGN, SCG
Name:Mirrodin|Sets:8ED, MRD, DST, 5DN
Name:Kamigawa|Sets:8ED, CHK, BOK, SOK
Name:The City of Guilds|Sets:9ED, RAV, GPT, DIS
Name:A Portal Through Time|Sets:9ED, TSP, TSB, PLC, FUT
Name:Lorwyn|Sets:10E, LRW, MOR, SHM, EVE
Name:Alara|Sets:10E, ALA, CON, ARB
Name:Zendikar, The Shattered World|Sets:M10, ZEN, WWK, ROE
Name:Return to Mirrodin|Sets:M11, SOM, MBS, NPH
Name:Innistrad, World of Shadow|Sets:M12, ISD, DKA, AVR
Name:Return to Ravicna|Sets:M13, RTR
I was using "forge-1.3.6-20130123.120651-5" as reference
- Asellia
- Posts: 26
- Joined: 30 Apr 2010, 19:02
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by storms » 24 Jan 2013, 13:51
Creeping Renaissance isent working properly most of times i wont let u get back the choosen type from the cemetry
Last edited by Chris H. on 24 Jan 2013, 17:31, edited 1 time in total.
Reason: mouse-over
Reason: mouse-over
- storms
- Posts: 10
- Joined: 12 Jan 2013, 20:42
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by Chris H. » 24 Jan 2013, 17:30
Max mtg wrote:Chris, I am prefectly able to commit some early changes of newcomers...
Thank you Max.
It helps to have the old timers step in and direct the new devs so they can get to a point where they can make contributions to the project.

-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Bug Reports (snapshot builds)
by slowe » 24 Jan 2013, 23:46
r19167
Spells and abilities used by the AI are bypassing the stack, or at least resolving before I'm given priority and a chance to respond.
Spells and abilities used by the AI are bypassing the stack, or at least resolving before I'm given priority and a chance to respond.
Who is online
Users browsing this forum: No registered users and 22 guests