Distribution effects

[moomarc]

I've just added the base for damage and damage prevention distribution for cards like Forked Lightning and Angel of Salvation. Two things I haven't been able to do yet (so any help would be appreciated):
* I have no idea how to go about implementing it for the AI. So for now I'm just converting cards that are already flagged with RemAIDeck:True.
* I can't seem to find a way to pass xPaid to the target (so no Rolling Thunder yet ). I tried adding it in AbilityFactory (I left my effort in there as it forms the basic structure of how it would be applied elsewhere. It looks like setXManaCostPaid should be set as soon as you hit the okay button, but I also tried setting the amount to be divided later in the target process in targetSelection, using a boolean to check if the distribution amount has been set, then try get xpaid directly from the card using hostC.getXManaCostPaid(), but that was no more effective. I'd love to get Rolling Thunder working - it was one of those cards that just made me smile whenever I drew it!

EDIT: Damn, just tested using a defined X value like Valid_Card.OppCtrl. That reminded me that X is only paid after targeting. So I might have to find a way to implement an AnnounceX parameter that's handled in AbilityFactory and lets you pick a number from 0 to 99 (unless we already have a way to calculate the amount of potential mana you have through cards on the battlefield - cards in hand not an issue seeing as you can't play spells while paying the cost).

[Hellfish]

Ideally, we should add an "announcement" step of cost payment where things like X and Multikicker must be decided before any actual targeting/payment is done.Big job, but it would ease other things alot I think.

[Sloth]

* I have no idea how to go about implementing it for the AI. So for now I'm just converting cards that are already flagged with RemAIDeck:True.

I will take a look at improving the AI.

[friarsol]

Ideally, we should add an "announcement" step of cost payment where things like X and Multikicker must be decided before any actual targeting/payment is done.Big job, but it would ease other things alot I think.

Yea this is what really needs to happen. Profane Command is buggy right now due to this issue. While sometimes it's nice that X can just be however much. Things would be much more consistent with an Announce portion. It may be worth doing this piecemeal, adding announce to a few cards (Similar to how Cost and Target have their own specifications). Before adding it to X Spells.

Edit: I may be able to take a look tonight and add a chunk to SA Requirements, that treats Announcement of X as a new entity that happens before targeting.

[moomarc]

Thanks to all of you for the help I love this community!

[swordshine]

Great work! Can this distribution effect be used in counter distributions in future? Cards like Blessings of Nature can be converted, and Forgotten Ancient can be scripted correctly.

[moomarc]

Great work! Can this distribution effect be used in counter distributions in future? Cards like Blessings of Nature can be converted, and Forgotten Ancient can be scripted correctly.

Should be easy enough. It's literally a one-liner in each effect that needs it and a tweak to the stack description. At least, that's true for getting it right for the human player. Sloth has it working for DealDamage for the AI, so far so he should be able to comment more from the AI side. (PS - thanks SLoth, that was quick!)

[Sloth]

(PS - thanks SLoth, that was quick!)

I only did the DealDamage sbilities yet. I will take a look at Damage Prevention later.

[friarsol]

Great work! Can this distribution effect be used in counter distributions in future? Cards like Blessings of Nature can be converted, and Forgotten Ancient can be scripted correctly.

Should be easy enough. It's literally a one-liner in each effect that needs it and a tweak to the stack description. At least, that's true for getting it right for the human player. Sloth has it working for DealDamage for the AI, so far so he should be able to comment more from the AI side. (PS - thanks SLoth, that was quick!)

Looks like there are 8 cards that can be scripted with PutCounter support of Distribute.
http://magiccards.info/query?q=o%3Adist ... rd&s=cname

I'm not sure if Distribute works with Forgotten Ancient, since it a) doesn't target and b) doesn't determine the "other creatures" until resolution. I'll post in the Card Development thread how I think this card might be done.

[moomarc]

Great work! Can this distribution effect be used in counter distributions in future? Cards like Blessings of Nature can be converted, and Forgotten Ancient can be scripted correctly.

Should be easy enough. It's literally a one-liner in each effect that needs it and a tweak to the stack description. At least, that's true for getting it right for the human player. Sloth has it working for DealDamage for the AI, so far so he should be able to comment more from the AI side. (PS - thanks SLoth, that was quick!)

Done! I've converted Blessings of Nature for reference, but it really is the same template. We'll probably need a bit more infrastructure to support the last few cards on Sol's list because we need to remember which cards successfully had counters put on them (and in the case of Bounty of the Hunt, how many counters).

Anyway, with that I bow out for the day.

[friarsol]

We'll probably need a bit more infrastructure to support the last few cards on Sol's list because we need to remember which cards successfully had counters put on them (and in the case of Bounty of the Hunt, how many counters).

Gah, foiled again! How did you know I just wanted more Alliances cards to be scripted?

[moomarc]

Gah, foiled again! How did you know I just wanted more Alliances cards to be scripted?

Haha! Must be getting predictable in your old age. We can at least get one more from Ice Age in the form of Spoils of War.

[friarsol]

After having a bit of difficulty with using variables and distribute. r19583 introduces Announce, which allows for cards like Rolling Thunder. Announce has the ability of fixing the buggy Profane Command and allowing X spells to work as expected with CostReduction cards. I also hope that we can use it with Multikicker to resolve alllll of the problems Multikicker brings about.

Max, from what I understand, I believe I'm using PlayerController the way you were planning on having it be used. But if you don't think this is a good use of that, I can move this code block back into SpellAbilityRequirements like I was originally planning.

[Hellfish]

Posting here since it's part if your dividedasyouchoose work, marc
Meteor Shower got a stray spelldescription in the middle of the file.

[moomarc]

Posting here since it's part if your dividedasyouchoose work, marc
Meteor Shower got a stray spelldescription in the middle of the file.

Already fixed, just not committed yet. Was just testing Serra's Hymn before committing the last few conversions and new cards from DealDamage and PreventDamage. All that's left there is Butcher Orgg. I started doing him based on Cunning Giant, but then realised the distribution is between defined creatures/players. So needs a little more work for that one.

Edit: Oh, Fiery Justice also doesn't seem to work. Can't select one of the players that have been targeted for damage distribution as the gain life target. So I can't even test whether the ruling would be applied about the player surviving if they would receive enough damage to die from the first part, then go above 0 life again due to the life gain part. Here's the script if anyone can think of an easy solution:

Fiery Justice | Open

Code: Select all

Name:Fiery Justice
ManaCost:R G W
Types:Sorcery
Text:no text
A:SP$ DealDamage | Cost$ R G W | ValidTgts$ Creature,Player | TgtPrompt$ Select target creature or player to distribute damage to | NumDmg$ 5 | TargetMin$ 1 | TargetMax$ 5 | DividedAsYouChoose$ 5 | SubAbility$ Justice | SpellDescription$ CARDNAME deals 5 damage divided as you choose among any number of target creatures and/or players. Target opponent gains 5 life.
SVar:Justice:DB$ GainLife | ValidTgts$ Opponent | TgtPrompt$ Select target opponent to gain life | LifeAmount$ 5
SVar:RemAIDeck:True
SVar:Picture:http://www.wizards.com/global/images/magic/general/fiery_justice.jpg
SetInfo:TSB|Special|http://magiccards.info/scans/en/tsts/92.jpg
SetInfo:ICE|Rare|http://magiccards.info/scans/en/ia/366.jpg
Oracle:Fiery Justice deals 5 damage divided as you choose among any number of target creatures and/or players. Target opponent gains 5 life.
End