Changes to card script format

[Max mtg]

SVar:Rarity - ignored during parse (removal from all scripts is highly recommended)
Text: - optional (no need for 'no text' lines)

All Licids use 'Licid' alternative state (name globally changed)


Out of game tokens may be represented by CardToken class (used in quest initial conditions)

[timmermac]

Isn't the rarity SVar used for things like deck editor and spell shop sorting and booster generation? Or is that covered by the setinfo lines?

[Max mtg]

Isn't the rarity SVar used for things like deck editor and spell shop sorting and booster generation? Or is that covered by the setinfo lines?

Deckeditor has not been using svar-rarity for over 9000 revisions - that is ~550 days.

Yes, rarity is taken from setinfo. If setinfo is not supplied some default set and rarity are assigned.

[friarsol]

Looks like the picture field was still being used by Quest Pets, as mine no longer display their images.

[Max mtg]

Looks like the picture field was still being used by Quest Pets, as mine no longer display their images.

1. Tokens are not displayed correctly, I suspect. Should download token pictures and investigate.
2. SVar:Picture was not deprecated.


3. Sol, do not use singletons.getmodel.getgame in classes which already have a game field (such classes as player*, gameaction*)

[friarsol]

3. Sol, do not use singletons.getmodel.getgame in classes which already have a game field (such classes as player*, gameaction*)

Ah didn't realize Player had it already. I added the code to Card first and then just copied over the useful bits. Didn't expect the two GameEntities to be in different states as far as that goes.

Edit: r19826

[Max mtg]

Card should also have a reference to game, but I didn't yet drive the code to that state.

[friarsol]

Card should also have a reference to game, but I didn't yet drive the code to that state.

Makes sense there's only so much mind-numbing conversions one can handle in a short amount of time.

[Max mtg]

Speaking of quest tokens, do you know where to obtain them?

No beta release topic had any link to tokens, neither ones coming from sets, nor custom ones drawn for quest.

[friarsol]

Speaking of quest tokens, do you know where to obtain them?

No beta release topic had any link to tokens, neither ones coming from sets, nor custom ones drawn for quest.

Content Downloaders -> Download Quest Images

[myk]

I know you haven't had a chance to test it yet, but just fyi, r19829 did not get the images back

[Max mtg]

Thanks, I already got the images and could see results by myself.
19834 fixes token images

[myk]

No offense intended. Fix confirmed as of r19836.

[Max mtg]

Here is windows powershell script I applied it to all cardname.txt files

Code: Select all

Get-ChildItem . | ForEach-Object -process { Get-ChildItem $_ | ForEach-Object -process { ( Get-Content $_.FullName ) | Where-Object -FilterScript { $_ -ne "Text:no text" } | Where-Object -FilterScript { $_ -ne "End" } | Set-Content $_.FullName } }


Commited as r19874