It is currently 31 Oct 2025, 22:42
   
Text Size

Sets for tokens

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins

Sets for tokens

Postby Max mtg » 22 Feb 2013, 23:21

I am getting a bit bugged by that messages:
Code: Select all
Bird Pet has no Oracle text.
Bird Pet was not assigned any set.
Soldier Ally was not assigned any set.
Soldier Ally was not assigned any set.
Soldier Ally was not assigned any set.
Bird pet is backed by a text script, so it might obtain a setinfo line to be shown properly in CardDetailsPanel.
Looks like we'll have to add a hardcoded set 'Forge' - what do you think?

For the remaining tokens we should also define sets, but I don't know yet how. Quest challenges provide no sets for tokens to start game on battlefield.
The only input data are name+color+pt, so and I'm supposed to choose a set and a picture. Is that a solid reason to develop TokenDb?
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Sets for tokens

Postby Sloth » 23 Feb 2013, 20:05

From the rules perspective tokens do not belong to any set. I.e. City in a Bottle should not trigger on a token made by Rukh Egg.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Sets for tokens

Postby Max mtg » 23 Feb 2013, 21:44

Sloth wrote:From the rules perspective tokens do not belong to any set. I.e. City in a Bottle should not trigger on a token made by Rukh Egg.
Alright, for the rules enforcement puprose we have
Rule 110.5b wrote:A token doesn’t have any characteristics not defined by the spell or ability that created it.
So I saw no card defining token's set.

It won't break anything even if we do assign expansions to tokens - see http://magiccards.info/query?q=o%3A%22e ... rd&s=cname - all serious cards exclude tokens from their targets.

I am asking about tokens to choose and display a best version of a token, that is closest edition to the card that has originated it. And yes, to make them more alike ordinary cards - that is use less specific code for their creation
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Sets for tokens

Postby Sloth » 24 Feb 2013, 20:20

Max mtg wrote:It won't break anything even if we do assign expansions to tokens - see http://magiccards.info/query?q=o%3A%22e ... rd&s=cname - all serious cards exclude tokens from their targets.
Well, a Clone could become the copy of a Rukh Egg token created by the ARN Rukh Egg and will falsely trigger City in a Bottle.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Sets for tokens

Postby Max mtg » 25 Feb 2013, 03:37

Ok, what if I patch cardfactory so that when the ipapercard parameter is a token, current set is not assigned to resulting card, but the image is assigned correctly - i.e. according to the set of that token?
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Sets for tokens

Postby Sloth » 25 Feb 2013, 09:18

Max mtg wrote:Ok, what if I patch cardfactory so that when the ipapercard parameter is a token, current set is not assigned to resulting card, but the image is assigned correctly - i.e. according to the set of that token?
Sounds good.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Sets for tokens

Postby Xitax » 03 Mar 2013, 19:27

If you guys decide to go ahead and change the tokens, I'd like to volunteer to collect pics, rename tokens, and edit scripts. I've already done an attempt at set-specific tokens (which could be improved on) and I have collected most of the information I would need.
Xitax
 
Posts: 918
Joined: 16 May 2010, 17:19
Has thanked: 183 times
Been thanked: 134 times

Re: Sets for tokens

Postby LordHelmchen » 14 Apr 2013, 18:01

As for the pics, Goblin Hero's picture torrent for Magic Album contains practicall all tokens, sorted by set, inside "ENG TOK.zip" within their respective subdirs. They're HQ, though, but batch-processing them down might be less work than hunting for LQ pics.
LordHelmchen
 
Posts: 125
Joined: 21 Aug 2012, 16:06
Has thanked: 21 times
Been thanked: 32 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 16 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 16 users online :: 0 registered, 0 hidden and 16 guests (based on users active over the past 10 minutes)
Most users ever online was 9298 on 10 Oct 2025, 12:54

Users browsing this forum: No registered users and 16 guests

Login Form