Sets for tokens
Post MTG Forge Related Programming Questions Here
	Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins
			8 posts
			 • Page 1 of 1
		
	
Sets for tokens
 by Max mtg » 22 Feb 2013, 23:21
by Max mtg » 22 Feb 2013, 23:21 
I am getting a bit bugged by that messages:
Looks like we'll have to add a hardcoded set 'Forge' - what do you think?
For the remaining tokens we should also define sets, but I don't know yet how. Quest challenges provide no sets for tokens to start game on battlefield.
The only input data are name+color+pt, so and I'm supposed to choose a set and a picture. Is that a solid reason to develop TokenDb?
			- Code: Select all
- Bird Pet has no Oracle text.
 Bird Pet was not assigned any set.
 Soldier Ally was not assigned any set.
 Soldier Ally was not assigned any set.
 Soldier Ally was not assigned any set.
Looks like we'll have to add a hardcoded set 'Forge' - what do you think?
For the remaining tokens we should also define sets, but I don't know yet how. Quest challenges provide no sets for tokens to start game on battlefield.
The only input data are name+color+pt, so and I'm supposed to choose a set and a picture. Is that a solid reason to develop TokenDb?
Single class for single responsibility.
		- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Sets for tokens
 by Sloth » 23 Feb 2013, 20:05
by Sloth » 23 Feb 2013, 20:05 
From the rules perspective tokens do not belong to any set. I.e. City in a Bottle should not trigger on a token made by Rukh Egg.
			
		- 
				 
 Sloth
- Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Sets for tokens
 by Max mtg » 23 Feb 2013, 21:44
by Max mtg » 23 Feb 2013, 21:44 
Alright, for the rules enforcement puprose we haveSloth wrote:From the rules perspective tokens do not belong to any set. I.e. City in a Bottle should not trigger on a token made by Rukh Egg.
So I saw no card defining token's set.Rule 110.5b wrote:A token doesn’t have any characteristics not defined by the spell or ability that created it.
It won't break anything even if we do assign expansions to tokens - see http://magiccards.info/query?q=o%3A%22e ... rd&s=cname - all serious cards exclude tokens from their targets.
I am asking about tokens to choose and display a best version of a token, that is closest edition to the card that has originated it. And yes, to make them more alike ordinary cards - that is use less specific code for their creation
Single class for single responsibility.
		- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Sets for tokens
 by Sloth » 24 Feb 2013, 20:20
by Sloth » 24 Feb 2013, 20:20 
Well, a Clone could become the copy of a Rukh Egg token created by the ARN Rukh Egg and will falsely trigger City in a Bottle.Max mtg wrote:It won't break anything even if we do assign expansions to tokens - see http://magiccards.info/query?q=o%3A%22e ... rd&s=cname - all serious cards exclude tokens from their targets.
- 
				 
 Sloth
- Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Sets for tokens
 by Max mtg » 25 Feb 2013, 03:37
by Max mtg » 25 Feb 2013, 03:37 
Ok, what if I patch cardfactory so that when the ipapercard parameter is a token, current set is not assigned to resulting card, but the image is assigned correctly - i.e. according to the set of that token?
			Single class for single responsibility.
		- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Sets for tokens
 by Sloth » 25 Feb 2013, 09:18
by Sloth » 25 Feb 2013, 09:18 
Sounds good.Max mtg wrote:Ok, what if I patch cardfactory so that when the ipapercard parameter is a token, current set is not assigned to resulting card, but the image is assigned correctly - i.e. according to the set of that token?
- 
				 
 Sloth
- Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Sets for tokens
 by Xitax » 03 Mar 2013, 19:27
by Xitax » 03 Mar 2013, 19:27 
If you guys decide to go ahead and change the tokens, I'd like to volunteer to collect pics, rename tokens, and edit scripts.  I've already done an attempt at set-specific tokens (which could be improved on) and I have collected most of the information I would need.
			
		Re: Sets for tokens
 by LordHelmchen » 14 Apr 2013, 18:01
by LordHelmchen » 14 Apr 2013, 18:01 
As for the pics, Goblin Hero's picture torrent for Magic Album contains practicall all tokens, sorted by set, inside "ENG TOK.zip" within their respective subdirs. They're HQ, though, but batch-processing them down might be less work than hunting for LQ pics.
			
		- LordHelmchen
- Posts: 125
- Joined: 21 Aug 2012, 16:06
- Has thanked: 21 times
- Been thanked: 32 times
			8 posts
			 • Page 1 of 1
		
	
Who is online
Users browsing this forum: No registered users and 16 guests
