Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by moomarc » 18 Mar 2013, 07:45
There's nothing wrong with the image. It's just that the flipped card's image isn't being updated properly. I also tried with Budoka Gardener and a few others. Doesn't help flipping the cards either so it seems that the new image isn't being set when the card is flipped. Something to do with cacheing?myk wrote:Also, the default alternate pic for nezumi_graverobber_nighteyes_the_desecrator.txt (that is, Nighteyes the Desecrator.full.jpg) is incorrect on the server -- it is not flipped when it should be. Would it be possible to host a corrected card pic?
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Bug Reports (snapshot builds)
by 7543021 » 19 Mar 2013, 06:24
It seems like creature transforming lands'ablity have some problems here.
Activating Celestial Colonnade and Raging Ravine to become a creature will crash the game.
Activating Celestial Colonnade and Raging Ravine to become a creature will crash the game.
- RuntimeException | Open
- 7543021
- Posts: 14
- Joined: 16 Feb 2013, 08:54
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by moomarc » 19 Mar 2013, 08:22
+1 I think it would make the most sense.Max mtg wrote:I suggest to download a single image and filp these cards programmatically.
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Bug Reports (snapshot builds)
by Sloth » 19 Mar 2013, 08:22
Fixed! Thanks 7543021.7543021 wrote:It seems like creature transforming lands'ablity have some problems here.
Activating Celestial Colonnade and Raging Ravine to become a creature will crash the game.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Bug Reports (snapshot builds)
by Chris H. » 19 Mar 2013, 12:43
Description: Launched the local copy of forge from within Eclipse and then clicked on the Deck Editor button. This copy of forge is not set up with pics in the cards folder and I suspect that this lack of pics may have lead to the Null Pointer Exception.
- NullPointerException | Open
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Bug Reports (snapshot builds)
by Chris H. » 19 Mar 2013, 16:54
Max mtg wrote:the culprit is r20476 - you may revert it in any way that pleases you.
I commented out that line in my local copy and that fixed the problem. I looked at this section of the ImageCache class and it is above my level of expertise.
Looks like we are attempting to assign an Image via it's key to a BufferedImage object. If the BufferedImage object is null we then are putting the key + a null into the CACHE.
I can temporarily comment out this one line of code, but I am not sure how this situation should be handled.
At one point Rob created a card image that had no art, no text and no name or other information as part of the image. It was just a blank image that would be displayed for all cards that did not have a picture file associated with that particular card.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Bug Reports (snapshot builds)
by Max mtg » 19 Mar 2013, 19:27
Chris, I remember that blurred image of artifact in old card design. But cannot find the picture file anywhere.
r20484 - I used a placeholder image to add it into cache. It's not null, so looks valid from the cache's PoV. The image lookup method returns to outer code null anyway, because placeholder image could be somewhat invalid and program fails at resize operation.
r20484 - I used a placeholder image to add it into cache. It's not null, so looks valid from the cache's PoV. The image lookup method returns to outer code null anyway, because placeholder image could be somewhat invalid and program fails at resize operation.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Chris H. » 19 Mar 2013, 21:59
Max mtg wrote:Chris, I remember that blurred image of artifact in old card design. But cannot find the picture file anywhere.
r20484 - I used a placeholder image to add it into cache. It's not null, so looks valid from the cache's PoV. The image lookup method returns to outer code null anyway, because placeholder image could be somewhat invalid and program fails at resize operation.
Thank you Max.
Rob at one point created a pic file named "morph.jpg" that is supposed to replace the normal image of a card that is morphed. This pic is downloaded with the quest pics and appears in the
Rob also created a similar card, (may have been named "blank.jog".) This card, unlike the "morph.jpg", did not have the card art, card text, etc and was an empty frame. As such it was a suitable image for a card that did not have a matching jpg image. I have not been able to find it, yet I continue to look for it.
- Attachments
-
- morph.jpg
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Bug Reports (snapshot builds)
by Chris H. » 19 Mar 2013, 22:21
Ah, found the card pics that I was talking about.
I seem to remember that a jpg could be imbedded into the code itself. This way Rob's image would be used for all pics until a pic download could be utilized.
I seem to remember that a jpg could be imbedded into the code itself. This way Rob's image would be used for all pics until a pic download could be utilized.
- Attachments
-
- none.jpg @ 480 x 680
-
- none.jpg @ 200 x 285
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Bug Reports (snapshot builds)
by Max mtg » 20 Mar 2013, 05:39
Chris, I have set up a default image in r20490
Consider adjusting the picture if it is too bright.
Consider adjusting the picture if it is too bright.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Chris H. » 20 Mar 2013, 12:57
Max mtg wrote:Chris, I have set up a default image in r20490
Consider adjusting the picture if it is too bright.
Thank you Max.
Looks good to me.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Bug Reports (snapshot builds)
by moomarc » 20 Mar 2013, 14:10
Opponents aren't being assigned avatars in constructed duels - this also includes the various multiplayer variants, normal constructed, sealed/booster and gauntlets.
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Who is online
Users browsing this forum: No registered users and 24 guests