Card Creation Request Thread

[RiiakShiNal]

PS how do you add an attachment?

In "Post a reply" (or when editing a post) below the "Save draft", "Preview", and "Submit" buttons you will see an "Options" tab and right next to it is "Upload attachment". Once you click the "Upload attachment" tab you will be able to specify which file to upload (up to a maximum of about 2 MB) and a comment for the file. If you need to upload a large file (or group of files) it is generally recommended that you upload them elsewhere and just include a link to them.

After a certain number of posts you will be able to post links directly without having the system flag them as "too spammy".

[nivmizzet1]

One card that I have tried and definitely can't get to work is Pristine Angel. I would love it if someone could create this card.

[thefiremind]

One card that I have tried and definitely can't get to work is Pristine Angel. I would love it if someone could create this card.

I made it for DotP2012 so it didn't take me long to convert it.

[Honeybear]

I tried my best, but the triggered ability won´t work. Anything else should be fine.

Here is the text for the ability:

<TRIGGERED_ABILITY auto_skip="1" filter_zone="ZONE_IN_PLAY">
<LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Whenever Kaalia of the Vast attacks an opponent, you may put an Angel, Demon, or Dragon creature card from your hand onto the battlefield tapped and attacking that opponent.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Whenever Kaalia of the Vast attacks an opponent, you may put an Angel, Demon, or Dragon creature card from your hand onto the battlefield tapped and attacking that opponent.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Whenever Kaalia of the Vast attacks an opponent, you may put an Angel, Demon, or Dragon creature card from your hand onto the battlefield tapped and attacking that opponent.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Whenever Kaalia of the Vast attacks an opponent, you may put an Angel, Demon, or Dragon creature card from your hand onto the battlefield tapped and attacking that opponent.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Ogniqualvolta Kaalia della Vastità attacca un avversario, puoi mettere sul campo di battaglia una carta creatura Angelo, Demone o Drago dalla tua mano TAPpata e che attacca quell’avversario.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Whenever Kaalia of the Vast attacks an opponent, you may put an Angel, Demon, or Dragon creature card from your hand onto the battlefield tapped and attacking that opponent.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Whenever Kaalia of the Vast attacks an opponent, you may put an Angel, Demon, or Dragon creature card from your hand onto the battlefield tapped and attacking that opponent.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Whenever Kaalia of the Vast attacks an opponent, you may put an Angel, Demon, or Dragon creature card from your hand onto the battlefield tapped and attacking that opponent.]]></LOCALISED_TEXT>
<LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Whenever Kaalia of the Vast attacks an opponent, you may put an Angel, Demon, or Dragon creature card from your hand onto the battlefield tapped and attacking that opponent.]]></LOCALISED_TEXT>
<TRIGGER value="ATTACKING" simple_qualifier="self" />
<TARGET_DEFINITION id="0">
local player = EffectController()
local filter = Object():GetFilter()
filter:Clear()
filter:NotTargetted()
filter:May()
filter:SetPlayer( player )
filter:SetZone( ZONE_HAND )
filter:AddCardType( CARD_TYPE_CREATURE )
filter:AddSubType( CREATURE_TYPE_ANGEL )
filter:AddSubType( CREATURE_TYPE_DEMON )
filter:AddSubType( CREATURE_TYPE_DRAGON )
player:ChooseTarget(NO_VALIDATION, "CARD_QUERY_CHOOSE_CREATURE_TO_PUT_ONTO_BATTLEFIELD", EffectDC():Make_Targets(0))
</RESOLUTION_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
local player = EffectController()
local target = EffectDC():Get_Targets(0)
if player ~= nil then
if target ~= nil then
local card = target:Get_CardPtr(0)
if (card ~= nil and card:GetZone() == ZONE_HAND) then
card:PutIntoPlay( player )
end
end
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>

I´d really appreciate any help on this.

[Honeybear]

I also need help with the tap ability for Tree of Redemption. I searched all cards in the Editor, but I did not found anything that could be of help. Here is the ability:

Tap: Exchange your life total with Tree of Redemption's toughness.

[thefiremind]

Kaalia of the Vast can't work that way: you need to use PutIntoPlayTappedAndAttacking (see the cards with ninjutsu in my mod for reference) and since that function needs the player to attack, you also need to store the attacked player in a register (better if inside the trigger condition, so even if Kaalia leaves the battlefield before resolution, your reference will still be there).
But the most important thing is that you can't do this:

Code: Select all

    <TARGET_DEFINITION id="0">
    ...
    </RESOLUTION_TIME_ACTION>

if you open an XML block, you need to close that block, not another one that you didn't open yet.
Here's how I would code Kaalia:

Code: Select all

    <TRIGGER value="ATTACKING" simple_qualifier="self">
    local defending = Object():GetPlayerAttacked()
    -- the following check shouldn't be needed (how can I attack an ally?) but let's follow the text...
    if defending ~= nil and defending:GetTeam() ~= EffectController():GetTeam() then
       EffectDC():Set_PlayerPtr(1, defending)
       return true
    end
    return false
    </TRIGGER>
    <RESOLUTION_TIME_ACTION>
    local player = EffectController()
    local filter = Object():GetFilter()
    filter:Clear()
    filter:NotTargetted()
    filter:May()
    filter:SetPlayer( player )
    filter:SetZone( ZONE_HAND )
    filter:AddCardType( CARD_TYPE_CREATURE )
    filter:AddSubType( CREATURE_TYPE_ANGEL )
    filter:AddSubType( CREATURE_TYPE_DEMON )
    filter:AddSubType( CREATURE_TYPE_DRAGON )
    filter:AddExtra( FILTER_EXTRA_ANY_SUB_TYPE )
    if filter:CountStopAt(1) == 1 then
       player:ChooseTarget( NO_VALIDATION, "CARD_QUERY_CHOOSE_CREATURE_TO_PUT_ONTO_BATTLEFIELD", EffectDC():Make_Targets(0) )
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target = EffectDC():Get_Targets(0) and EffectDC():Get_Targets(0):Get_CardPtr(0)
    local defending = EffectDC():Get_PlayerPtr(1)
    if target ~= nil and defending ~= nil then
       target:PutIntoPlayTappedAndAttacking( EffectController(), defending )
    end
    </RESOLUTION_TIME_ACTION>

I also need help with the tap ability for Tree of Redemption. I searched all cards in the Editor, but I did not found anything that could be of help.

I coded Tree of Redemption recently, it will be in the next release of my mod (release date not available ). Here is how:

Code: Select all

  <ACTIVATED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[{T}: Exchange your life total with Tree of Redemption’s toughness.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[{T}: Scambia i tuoi punti vita con la costituzione dell’Albero della Redenzione.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[{T}: Tausche deine Lebenspunktezahl mit der Widerstandskraft des Baums der Erlösung.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[{T} : Échangez votre total de points de vie contre l’endurance de l’Arbre de la rédemption.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[{T}: Intercambia tu total de vidas con la resistencia del Árbol de la redención.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[{T}：あなたのライフの総量と解放の樹のタフネスを交換する。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[{T}: Exchange your life total with Tree of Redemption’s toughness.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[{T}: обменяйте количество ваших жизней на выносливость Древа Искупления.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[{T}: Permute seu total de pontos de vida com a resistência de Árvore da Redenção.]]></LOCALISED_TEXT>
    <COST type="TapSelf" />
    <RESOLUTION_TIME_ACTION>
    if EffectSource() ~= nil then
       local player = EffectController()
       local toughness = EffectSource():GetCurrentCharacteristics():Toughness_Get()
       EffectDC():Set_Int( 0, player:GetLifeTotal() )
       player:SetLifeTotal( toughness )
    end
    </RESOLUTION_TIME_ACTION>
    <CONTINUOUS_ACTION layer="7B">
    if EffectSource() ~= nil then
       EffectSource():GetCurrentCharacteristics():Toughness_Set( EffectDC():Get_Int(0) )
    end
    </CONTINUOUS_ACTION>
    <DURATION>
    return EffectSource() == nil
    </DURATION>
    <AI_AVAILABILITY step="end_of_turn" turn="their_turn" />
    <AI_AVAILABILITY step="declare_blockers" blocking_or_blocked="1" />
    <AI_AVAILABILITY type="in_response_dangerous" />
  </ACTIVATED_ABILITY>

Obviously you can't treat your life total and a creature's toughness the same way: a creature's statistics need CONTINUOUS_ACTIONs to be changed.

[Honeybear]

Thanks a lot for your help and your card creator, which is quite useful

So, Dotp 2014 has been finally announced and it makes we wounder, how much work will be required in order to convert our cards all over again. How difficult is it to convert cards from dotp 2012 to 2013 anyway, Firemind?

[thefiremind]

How difficult is it to convert cards from dotp 2012 to 2013 anyway, Firemind?

Well, it depends... if you are familiar with both DotP2012 and DotP2013 coding, really easy. If you are familiar with DotP2013 coding only, a bit less easy, but you don't need much to make the leap and understand the differences. If you aren't familiar with any of them... well look at AriesKiki's posts starting from this one and you'll have a fitting example.

[nivmizzet1]

I would really love if someone could code Kalastria Highborn -- she's doing my head in.

I thought she wouldn't be too hard -- just a mix of a modified mentor of the meek and blood artist or something (those are the two main cards I used to pilfer code from).

Boy was I wrong. I realised she has so many more conditions and ifs, thens, etc. and I just can't get my head around it all.

At the moment, her trigger is wrong -- she triggers whenever a creature dies, but she should only trigger when a "vampire you control dies". When she triggers she gives the choice to pay to gain 2 life and have target player lose 2 life, but when you make your choice nothing happens (actually, a resolution event happens, but nothing is actually resolving). Anyway, I've made a complete mess of it. I'll post what I have so far, but basically just so the localised text and art don't need to be redone.

[thefiremind]

In this case, you are strongly encouraged to use the automatic conditional cost because you must choose a target, so the earlier you get to be asked if you want to pay, the better.

Here's my code:

Code: Select all

    <TRIGGER value="ZONECHANGE_BEGIN" simple_qualifier="objectyoucontrol" to_zone="ZONE_GRAVEYARD" from_zone="ZONE_IN_PLAY">
    return TriggerObject() == Object() or TriggerObject():GetSubType():Test( CARD_TYPE_VAMPIRE ) ~= 0
    </TRIGGER>
    <COST type="Mana" cost="{B}" qualifier="conditional" />
    <TARGET_DEFINITION id="0">
    local filter = Object():GetFilter()
    filter:Clear()
    filter:SetFilterType( FILTER_TYPE_PLAYERS )
    filter:SetHint( HINT_ENEMY_ONLY, EffectController() )
    </TARGET_DEFINITION>
    <TARGET_DETERMINATION>
    return AtLeastOneTargetFromDefinition(0)
    </TARGET_DETERMINATION>
    <PLAY_TIME_ACTION target_choosing="1">
    EffectController():ChooseTarget( 0, "CARD_QUERY_CHOOSE_PLAYER_LOSE_2", EffectDC():Make_Targets(0) )
    </PLAY_TIME_ACTION>
    <RESOLUTION_TIME_ACTION conditional="if">
    local target = EffectDC():Get_Targets(0):Get_PlayerPtr(0)
    if target ~= nil then
       target:LoseLife( 2 )
       EffectController():GainLife( 2 )
    end
    </RESOLUTION_TIME_ACTION>

With this code you will be probably asked for a target before being asked to pay, but I think that those should be the real rules, even if it's boring to choose a target even if you aren't planning to pay (all the conditional costs in DotP2012 were working like that).

Some errors in your code that you may want to know about:

• Those are probably distractions, anyway you used "{1}" in the first CanAfford instead of "{B}", and the "if" in the last PLAY_TIME_ACTION doesn't have its "end".
• You have set the trigger condition for any creature, but the text says "Kalastria Highborn or another Vampire you control"... so let's split this into pieces and code them one by one:
  • Kalastria Highborn: the creature itself. When this condition is alone, you can use simple_qualifier="self" but this is not the case, so the first condition is TriggerObject() == Object().
  • or another Vampire: note that it doesn't say "creature"... if there was a Tribal Enchantment - Vampire, it would count. The second condition is TriggerObject():GetSubType():Test( CARD_TYPE_VAMPIRE ) ~= 0.
  • you control: we didn't use a simple_qualifier yet, so we can use simple_qualifier="objectyoucontrol".
  Done! All the trigger conditions are the right ones now.
• You chose not to ask the AI about paying or not, but then you aren't setting a specific case for the AI in the next actions... anyway choices about paying mana to get a benefit should be left for the AI to decide because they are too situational to be able to decide for it all the times.

[nivmizzet1]

...snip...

Thanks again! I definitely learnt some things from your tips, hopefully some of it will stick and allow me to make more complex cards in future. Cheers!

[RiiakShiNal]

For Kalastria Highborn probably something along these lines for the Triggered Ability (took your code and cleaned it up and fixed it):

Code: Select all

  <TRIGGERED_ABILITY dangerous="1" filter_zone="ZONE_IN_PLAY">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Whenever Kalastria Highborn or another Vampire you control dies, you may pay {B}. If you do, target player loses 2 life and you gain 2 life.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Ogniqualvolta la Nobile Kalastria o un altro Vampiro che controlli viene messa in un cimitero dal campo di battaglia, puoi pagare {B}. Se lo fai, un giocatore bersaglio perde 2 punti vita e tu guadagni 2 punti vita.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Immer wenn die Hochgeborene Kalastria oder ein anderer Vampir, den du kontrollierst, aus dem Spiel auf einen Friedhof gelegt wird, kannst du {B} bezahlen. Falls du dies tust, verliert ein Spieler deiner Wahl 2 Lebenspunkte, und du erhältst 2 Lebenspunkte dazu.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[À chaque fois que la Patricienne des Kalastria ou qu’un autre vampire que vous contrôlez est mis dans un cimetière depuis le champ de bataille, vous pouvez payer {B}. Si vous faites ainsi, le joueur ciblé perd 2 points de vie et vous gagnez 2 points de vie.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Siempre que la Aristócrata Kalastria u otro Vampiro que controles vaya a un cementerio desde el campo de batalla, puedes pagar {B}. Si lo haces, el jugador objetivo pierde 2 vidas y tú ganas 2 vidas.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[カラストリアの貴人かあなたがコントロールする他の吸血鬼が１体戦場からいずれかの墓地に置かれるたび、プレイヤー１人を対象とする。あなたは{B}を支払ってもよい。 そうした場合、そのプレイヤーは２点のライフを失い、あなたは２点のライフを得る。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Whenever Kalastria Highborn or another Vampire you control is put into a graveyard from the battlefield, you may pay {B}. If you do, target player loses 2 life and you gain 2 life.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Каждый раз когда Аристократка из Рода Каластрия или другой Вампир под вашим контролем попадает с поля битвы на кладбище, вы можете заплатить {B}. Если вы это делаете, целевой игрок теряет 2 жизни, а вы получаете 2 жизни.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Toda vez que Fidalga Kalastria ou outro Vampiro que você controla é colocado num cemitério vindo do campo de batalha, você pode pagar {B}. Se fizer isso, o jogador alvo perderá 2 pontos de vida e você ganhará 2 pontos de vida.]]></LOCALISED_TEXT>
    <TRIGGER value="ZONECHANGE_BEGIN" to_zone="ZONE_GRAVEYARD" from_zone="ZONE_IN_PLAY">
      return (TriggerObject():GetSubType():Test( CREATURE_TYPE_VAMPIRE ) ~= 0) and
             (TriggerObject():GetController() == EffectController()) and
             (EffectController():CanAfford("{B}") ~= 0)
    </TRIGGER>
    <TARGET_DEFINITION id="0">
      local filter = Object():GetFilter()
      filter:Clear()
      filter:SetFilterType( FILTER_TYPE_PLAYERS )
      filter:SetHint( HINT_ENEMY_ONLY, EffectController() )
    </TARGET_DEFINITION>
    <TARGET_DETERMINATION>
      return AtLeastOneTargetFromDefinition(0)
    </TARGET_DETERMINATION>
    <PLAY_TIME_ACTION>
      local player = EffectController()
      if player ~= nil then
        if player:CanAfford("{B}") ~= 0 then
          if player:IsAI() == 0 then
            player:BeginNewMultipleChoice()   
            player:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_YES" )   
            player:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_NO" )   
            player:AskMultipleChoiceQuestion( "CARD_QUERY_PAY_FOR_TARGET_PLAYER_LOSE_2" )
          end
        end
      end
    </PLAY_TIME_ACTION>
    <PLAY_TIME_ACTION target_choosing="1">
      if Object():GetMultipleChoiceResult() == 0 then
        EffectDC():Int_Set( 1, 1 )
        local player = EffectController()
        player:TapLand("{B}")
        player:ChooseTarget( 0, "CARD_QUERY_CHOOSE_PLAYER_LOSE_2", EffectDC():Make_Targets(0) )
      end
    </PLAY_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
      if EffectDC():Int_Get( 1 ) == 1 then
        local target = EffectDC():Get_Targets(0):Get_PlayerPtr(0)
        if target ~= nil then
          target:LoseLife( 2 )
          EffectController():GainLife( 2 )
        end
      end
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>

Among the problems, in your trigger you were not checking to see if the creature was a vampire, whether it was controlled by the player controlling Kalastria Highborn, or whether they had enough mana to even worry about it.

In your first PLAY_TIME_ACTION you were checking to see if the player could afford instead of .

In the second PLAY_TIME_ACTION you did not set anything in the EffectDC() to indicate if the player answered yes or no. Object():GetMultipleChoiceResult() can only be called once per multiple choice question asked as it will clear the result afterward leading to unknown results. You also did not terminate your if blocks with end statements (required). The check in this block to see if there is AtLeastOneTargetFromDefinition(0) and checking for available mana is not necessary (mainly because it needs to be checked before this point).

In the RESOLUTION_TIME_ACTION when you are trying to get the target, if the user selected "No" in the first question then this line will throw an error because EffectDC():Get_Targets(0) will be nil and can't be referenced to try and Get_PlayerPtr(0). So to prevent errors in the SCRIPT_LOG you need to add either a check to make sure Get_Targets(0) is not nil or check to make sure the user answered "Yes" to the first question. I prefer the latter because then I am checking what the user wanted instead of whether I created targets or not, though the result essentially is the same.

Edit: I was already writing this before thefiremind posted his answer, but since my answer is different I will leave it for reference purposes.

[Vasht]

Hi,

is it possible to create Sphere of the Suns ?

[RiiakShiNal]

is it possible to create Sphere of the Suns ?

It is possible, but only with mana tokens and it will suffer from triggering abilities that trigger on a player activating an activated ability (like Burning-Tree Shaman).

[nivmizzet1]

can someone get fastbond working? I have everything working except the damage effect that should trigger for each land you play after the first in a single turn.

In my current version I have a trigger activating whenever a land enters the battlefield, but it should only trigger whenever a land after the first enters the battlefield. Also, the damage effect that should be triggered isn't happening.

I tried using code from groundswell as part of the trigger condition (to only activate after a land has already been played), but I don't know enough about coding to get it right. I'm certain it's possible though.